From wwwrun@oss.sgi.com Thu Jan 1 17:13:38 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n01NDbmN003122 for ; Thu, 1 Jan 2009 17:13:38 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n01NDa0L003121; Thu, 1 Jan 2009 17:13:36 -0600 Date: Thu, 1 Jan 2009 17:13:36 -0600 Message-Id: <200901012313.n01NDa0L003121@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 805] Lockup when copying large file to XFS partition X-Bugzilla-Reason: AssignedTo http://oss.sgi.com/bugzilla/show_bug.cgi?id=805 ------- Additional Comments From hch@xfs.org 2009-01-01 17:13 CST ------- Would you be able to test a patch to narrow down what's causing this inside find_get_pages? -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Fri Jan 2 01:55:58 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n027twDd007535 for ; Fri, 2 Jan 2009 01:55:58 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n027twNF007534; Fri, 2 Jan 2009 01:55:58 -0600 Date: Fri, 2 Jan 2009 01:55:58 -0600 Message-Id: <200901020755.n027twNF007534@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 805] Lockup when copying large file to XFS partition X-Bugzilla-Reason: AssignedTo http://oss.sgi.com/bugzilla/show_bug.cgi?id=805 ------- Additional Comments From peter.klotz@aon.at 2009-01-02 01:55 CST ------- I'll do my best. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Fri Jan 2 11:22:44 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n02HMisV016145 for ; Fri, 2 Jan 2009 11:22:44 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n02HMinK016143; Fri, 2 Jan 2009 11:22:44 -0600 Date: Fri, 2 Jan 2009 11:22:44 -0600 Message-Id: <200901021722.n02HMinK016143@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 805] Lockup when copying large file to XFS partition X-Bugzilla-Reason: AssignedTo http://oss.sgi.com/bugzilla/show_bug.cgi?id=805 hch@xfs.org changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|xfs-masters@oss.sgi.com |hch@xfs.org Status|NEW |ASSIGNED ------- Additional Comments From hch@xfs.org 2009-01-02 11:22 CST ------- Created an attachment (id=254) --> (http://oss.sgi.com/bugzilla/attachment.cgi?id=254&action=view) find_get_pages debug patch Thanks a lot! Please report what messages you get with the following patch. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From viro@ftp.linux.org.uk Fri Jan 2 12:28:43 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n02ISgRh021346 for ; Fri, 2 Jan 2009 12:28:43 -0600 X-ASG-Debug-ID: 1230920917-507802540000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from ZenIV.linux.org.uk (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 08A6E1BFA636 for ; Fri, 2 Jan 2009 10:28:38 -0800 (PST) Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [195.92.253.2]) by cuda.sgi.com with ESMTP id YNyF3HJilGA1ipBe for ; Fri, 02 Jan 2009 10:28:38 -0800 (PST) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.68 #1 (Red Hat Linux)) id 1LIokX-00060t-Lu; Fri, 02 Jan 2009 18:27:57 +0000 Date: Fri, 2 Jan 2009 18:27:57 +0000 From: Al Viro To: Christoph Hellwig Cc: Jonathan Corbet , LKML , Oleg Nesterov , bfields@fieldses.org, xfs-masters@oss.sgi.com, Andi Kleen , Alan Cox X-ASG-Orig-Subj: Re: [xfs-masters] RFC: Fix f_flags races without the BKL Subject: Re: [xfs-masters] RFC: Fix f_flags races without the BKL Message-ID: <20090102182757.GF28946@ZenIV.linux.org.uk> References: <20081229041352.6bbdf57c@tpl> <20081229125050.GA22909@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081229125050.GA22909@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: Al Viro X-Barracuda-Connect: zeniv.linux.org.uk[195.92.253.2] X-Barracuda-Start-Time: 1230920922 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14252 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On Mon, Dec 29, 2008 at 01:50:50PM +0100, Christoph Hellwig wrote: > On Mon, Dec 29, 2008 at 04:13:52AM -0700, Jonathan Corbet wrote: > > Accesses to the f_flags field have always involved a read-modify-write > > operation, and have always been racy in the absence of the BKL. The recent > > BKL-removal work made this problem worse, but it has been there for a very > > long time. The race is quite small, and, arguably, has never affected > > anybody, but it's still worth fixing. > > > > After pondering for a while, I couldn't come up with anything better than a > > global file->f_flags mutex. There's no point in bloating struct file with > > a mutex just for this purpose; it's hard to imagine that there will be any > > real contention for this lock. > > What speaks against having on in fs_struct so that it's at least not > globally serialized? WTF? References to struct file can be shared by tasks with different associated fs_struct; how the devil can that ever work? From viro@ftp.linux.org.uk Fri Jan 2 12:29:17 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n02ITH8b021380 for ; Fri, 2 Jan 2009 12:29:17 -0600 X-ASG-Debug-ID: 1230920956-5be801250000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from ZenIV.linux.org.uk (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 210385A53B for ; Fri, 2 Jan 2009 10:29:16 -0800 (PST) Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [195.92.253.2]) by cuda.sgi.com with ESMTP id G0HORpRDvlfYr73u for ; Fri, 02 Jan 2009 10:29:16 -0800 (PST) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.68 #1 (Red Hat Linux)) id 1LIolj-00063R-PN; Fri, 02 Jan 2009 18:29:11 +0000 Date: Fri, 2 Jan 2009 18:29:11 +0000 From: Al Viro To: Andi Kleen Cc: Christoph Hellwig , Jonathan Corbet , LKML , Oleg Nesterov , bfields@fieldses.org, xfs-masters@oss.sgi.com, Alan Cox X-ASG-Orig-Subj: Re: [xfs-masters] RFC: Fix f_flags races without the BKL Subject: Re: [xfs-masters] RFC: Fix f_flags races without the BKL Message-ID: <20090102182911.GG28946@ZenIV.linux.org.uk> References: <20081229041352.6bbdf57c@tpl> <20081229125050.GA22909@lst.de> <20081229151555.GG496@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081229151555.GG496@one.firstfloor.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: Al Viro X-Barracuda-Connect: zeniv.linux.org.uk[195.92.253.2] X-Barracuda-Start-Time: 1230920957 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14252 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On Mon, Dec 29, 2008 at 04:15:55PM +0100, Andi Kleen wrote: > > What speaks against having on in fs_struct so that it's at least not > > globally serialized? > > That would not handle fds passed between processes? Doesn't need to be passed; just inherited from common ancestor... From viro@ftp.linux.org.uk Fri Jan 2 12:43:18 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n02IhG7V022087 for ; Fri, 2 Jan 2009 12:43:18 -0600 X-ASG-Debug-ID: 1230921794-5c5a01360000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from ZenIV.linux.org.uk (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 884375A74A for ; Fri, 2 Jan 2009 10:43:15 -0800 (PST) Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [195.92.253.2]) by cuda.sgi.com with ESMTP id IDeaEdny9O8xGmG4 for ; Fri, 02 Jan 2009 10:43:15 -0800 (PST) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.68 #1 (Red Hat Linux)) id 1LIoye-0006HA-90; Fri, 02 Jan 2009 18:42:32 +0000 Date: Fri, 2 Jan 2009 18:42:32 +0000 From: Al Viro To: Jonathan Corbet Cc: LKML , Andi Kleen , Alan Cox , Oleg Nesterov , bfields@fieldses.org, xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: RFC: Fix f_flags races without the BKL Subject: Re: RFC: Fix f_flags races without the BKL Message-ID: <20090102184232.GH28946@ZenIV.linux.org.uk> References: <20081229041352.6bbdf57c@tpl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081229041352.6bbdf57c@tpl> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: Al Viro X-Barracuda-Connect: zeniv.linux.org.uk[195.92.253.2] X-Barracuda-Start-Time: 1230921795 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14252 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On Mon, Dec 29, 2008 at 04:13:52AM -0700, Jonathan Corbet wrote: > Accesses to the f_flags field have always involved a read-modify-write > operation, and have always been racy in the absence of the BKL. The recent > BKL-removal work made this problem worse, but it has been there for a very > long time. The race is quite small, and, arguably, has never affected > anybody, but it's still worth fixing. > > After pondering for a while, I couldn't come up with anything better than a > global file->f_flags mutex. There's no point in bloating struct file with > a mutex just for this purpose; it's hard to imagine that there will be any > real contention for this lock. Bloating with mutex is over the top, indeed, but why can't we simply keep a pointer to fasync_struct in there? Do we ever have a struct file with several fasync_struct? They'd have to be on different queues and I don't see any cases where that would happen... From onestero@redhat.com Fri Jan 2 13:11:12 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n02JBAR1024757 for ; Fri, 2 Jan 2009 13:11:12 -0600 X-ASG-Debug-ID: 1230923469-3a4e00490000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx2.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 329AD5A935 for ; Fri, 2 Jan 2009 11:11:09 -0800 (PST) Received: from mx2.redhat.com (mx2.redhat.com [66.187.237.31]) by cuda.sgi.com with ESMTP id jMkZZcAvNz3LiAE7 for ; Fri, 02 Jan 2009 11:11:09 -0800 (PST) Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n02JAuoj025131; Fri, 2 Jan 2009 14:10:57 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n02JAr36007713; Fri, 2 Jan 2009 14:10:54 -0500 Received: from dhcp-lab-139.englab.brq.redhat.com (tranklukator.englab.brq.redhat.com [10.34.32.241]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with SMTP id n02JAnxK027256; Fri, 2 Jan 2009 14:10:50 -0500 Received: by dhcp-lab-139.englab.brq.redhat.com (nbSMTP-1.00) for uid 500 onestero@redhat.com; Fri, 2 Jan 2009 20:09:07 +0100 (CET) Date: Fri, 2 Jan 2009 20:09:03 +0100 From: Oleg Nesterov To: Al Viro Cc: Jonathan Corbet , LKML , Andi Kleen , Alan Cox , bfields@fieldses.org, xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: RFC: Fix f_flags races without the BKL Subject: Re: RFC: Fix f_flags races without the BKL Message-ID: <20090102190902.GA25969@redhat.com> References: <20081229041352.6bbdf57c@tpl> <20090102184232.GH28946@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090102184232.GH28946@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.18 (2008-05-17) X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-Barracuda-Connect: mx2.redhat.com[66.187.237.31] X-Barracuda-Start-Time: 1230923470 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14254 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On 01/02, Al Viro wrote: > > Bloating with mutex is over the top, indeed, but why can't we simply keep > a pointer to fasync_struct in there? Do we ever have a struct file with > several fasync_struct? pipe_rdwr_fasync() ? Oleg. From viro@ftp.linux.org.uk Fri Jan 2 13:54:58 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n02JsviF027734 for ; Fri, 2 Jan 2009 13:54:58 -0600 X-ASG-Debug-ID: 1230926095-44f800f70000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from ZenIV.linux.org.uk (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5CFB01BFA90C for ; Fri, 2 Jan 2009 11:54:55 -0800 (PST) Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [195.92.253.2]) by cuda.sgi.com with ESMTP id moY3dB5QDe1Il5sg for ; Fri, 02 Jan 2009 11:54:55 -0800 (PST) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.68 #1 (Red Hat Linux)) id 1LIq6Y-00074o-MR; Fri, 02 Jan 2009 19:54:46 +0000 Date: Fri, 2 Jan 2009 19:54:46 +0000 From: Al Viro To: Oleg Nesterov Cc: Jonathan Corbet , LKML , Andi Kleen , Alan Cox , bfields@fieldses.org, xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: RFC: Fix f_flags races without the BKL Subject: Re: RFC: Fix f_flags races without the BKL Message-ID: <20090102195446.GJ28946@ZenIV.linux.org.uk> References: <20081229041352.6bbdf57c@tpl> <20090102184232.GH28946@ZenIV.linux.org.uk> <20090102190902.GA25969@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090102190902.GA25969@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: Al Viro X-Barracuda-Connect: zeniv.linux.org.uk[195.92.253.2] X-Barracuda-Start-Time: 1230926096 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14257 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On Fri, Jan 02, 2009 at 08:09:03PM +0100, Oleg Nesterov wrote: > On 01/02, Al Viro wrote: > > > > Bloating with mutex is over the top, indeed, but why can't we simply keep > > a pointer to fasync_struct in there? Do we ever have a struct file with > > several fasync_struct? > > pipe_rdwr_fasync() ? Ho-hum... Right you are ;-/ FWIW, it's still bloody tempting to try. How about hlist from struct file through fasync_struct? Possibly with reference from fasync_struct back to the queue it's on, while we are at it - would make fasync_helper simpler... From wwwrun@oss.sgi.com Fri Jan 2 20:18:51 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n032Ip0V021214 for ; Fri, 2 Jan 2009 20:18:51 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n032IpOc021213; Fri, 2 Jan 2009 20:18:51 -0600 Date: Fri, 2 Jan 2009 20:18:51 -0600 Message-Id: <200901030218.n032IpOc021213@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 810] shutdown xfs filesystem. X-Bugzilla-Reason: AssignedTo http://oss.sgi.com/bugzilla/show_bug.cgi?id=810 ------- Additional Comments From ammartinez@coitt.es 2009-01-02 20:18 CST ------- xfs_repair is not able to end the task with 1 Gbyte RAM memory. Trying with parameter -o bhash=8192 works ok. Now, I am going to make a proof with kernel you comment. Thanks. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From onestero@redhat.com Sat Jan 3 10:47:52 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n03GlqpH017827 for ; Sat, 3 Jan 2009 10:47:52 -0600 X-ASG-Debug-ID: 1231001271-151d03a00000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx2.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1C9975C236 for ; Sat, 3 Jan 2009 08:47:51 -0800 (PST) Received: from mx2.redhat.com (mx2.redhat.com [66.187.237.31]) by cuda.sgi.com with ESMTP id Kg20oFHvKWomzSiq for ; Sat, 03 Jan 2009 08:47:51 -0800 (PST) Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n03Gla2i031180; Sat, 3 Jan 2009 11:47:36 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n03GlXPT020836; Sat, 3 Jan 2009 11:47:34 -0500 Received: from dhcp-lab-139.englab.brq.redhat.com (tranklukator.englab.brq.redhat.com [10.34.32.241]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with SMTP id n03GlUCR010329; Sat, 3 Jan 2009 11:47:31 -0500 Received: by dhcp-lab-139.englab.brq.redhat.com (nbSMTP-1.00) for uid 500 onestero@redhat.com; Sat, 3 Jan 2009 17:45:46 +0100 (CET) Date: Sat, 3 Jan 2009 17:45:44 +0100 From: Oleg Nesterov To: Al Viro Cc: Jonathan Corbet , LKML , Andi Kleen , Alan Cox , bfields@fieldses.org, xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: RFC: Fix f_flags races without the BKL Subject: Re: RFC: Fix f_flags races without the BKL Message-ID: <20090103164544.GA17282@redhat.com> References: <20081229041352.6bbdf57c@tpl> <20090102184232.GH28946@ZenIV.linux.org.uk> <20090102190902.GA25969@redhat.com> <20090102195446.GJ28946@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090102195446.GJ28946@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.18 (2008-05-17) X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-Barracuda-Connect: mx2.redhat.com[66.187.237.31] X-Barracuda-Start-Time: 1231001272 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14330 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On 01/02, Al Viro wrote: > > FWIW, it's still bloody tempting to try. How about hlist from struct file > through fasync_struct? Possibly with reference from fasync_struct back > to the queue it's on, while we are at it - would make fasync_helper simpler... Well, don't ask me ;) I don't know whether this change is good or bad... Let's forget about files with several fasync_struct's, suppose we have a pointer ->f_xxx to fasync_struct in struct file. Now __fput() can check f_xxx != NULL and call ->fasync() if true. But how can we ensure that (->f_flags & FASYNC) matches (->f_xxx != NULL) ? Looks like we should kill FASYNC and uglify the code which sets/gets ->f_flags, for example do_fcntl(F_GETFL) should do case F_GETFL: err = filp->f_flags | (filp->f_xxx ? FASYNC : 0) And what if some strange driver doesn't use the "standard" fasync_helper/ kill_fasync helpers? Offtopic, but while we are here... pipe_rdwr_fasync: retval = fasync_helper(fd, filp, on, &pipe->fasync_readers); if (retval >= 0) retval = fasync_helper(fd, filp, on, &pipe->fasync_writers); Suppose that on == 1 and the first fasync_helper(fasync_readers) succeeds, but the second fasync_helper(fasync_writers) fails. We return the error and this file doesn't get FASYNC, but still it is placed on ->fasync_readers. This looks just wrong, we return the error to the user-space, but the file owner can receive the notifications from ->fasync_readers. And. Don't we leak fasync_struct in this case? With the recent changes, pipe_rdwr_release() does not call pipe_rdwr_fasync(on => 0) unconditionally. Instead, __fput() does this, but depending on ->f_flags & FASYNC. IOW, perhaps we need something like the patch below? --- a/fs/pipe.c +++ b/fs/pipe.c @@ -702,9 +702,11 @@ pipe_rdwr_fasync(int fd, struct file *fi retval = fasync_helper(fd, filp, on, &pipe->fasync_readers); - if (retval >= 0) + if (retval >= 0) { retval = fasync_helper(fd, filp, on, &pipe->fasync_writers); - + if (retval < 0) /* can only happen if on == true */ + fasync_helper(-1, filp, 0, &pipe->fasync_readers); + } mutex_unlock(&inode->i_mutex); if (retval < 0) And why pipe_xxx_fasync() take ->i_mutex around fasync_helper() ? Afaics, nothing bad can happen if pipe_xxx_fasync() races with, say, pipe_read(). Oleg. From wwwrun@oss.sgi.com Sun Jan 4 11:11:45 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n04HBj79021267 for ; Sun, 4 Jan 2009 11:11:45 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n04HBjEU021266; Sun, 4 Jan 2009 11:11:45 -0600 Date: Sun, 4 Jan 2009 11:11:45 -0600 Message-Id: <200901041711.n04HBjEU021266@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 802] (m_active_trans == 0) assertion failure while remounting readonly X-Bugzilla-Reason: AssignedTo http://oss.sgi.com/bugzilla/show_bug.cgi?id=802 ------- Additional Comments From hch@xfs.org 2009-01-04 11:11 CST ------- The problem is that the MS_RDONLY flag in the VFS only gets set after the ->remount method has finished. In the meantime new metadata operations can kick in and create new transactions. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Sun Jan 4 15:35:00 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n04LZ08D029254 for ; Sun, 4 Jan 2009 15:35:00 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n04LZ00Y029252; Sun, 4 Jan 2009 15:35:00 -0600 Date: Sun, 4 Jan 2009 15:35:00 -0600 Message-Id: <200901042135.n04LZ00Y029252@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 757] cache_node_purge: refcount was 1, not zero X-Bugzilla-Reason: AssignedTo http://oss.sgi.com/bugzilla/show_bug.cgi?id=757 hch@xfs.org changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|xfs-masters@oss.sgi.com |hch@xfs.org ------- Additional Comments From hch@xfs.org 2009-01-04 15:35 CST ------- I have a metadump image with which I can reproduce the warning. I'll investigate it once I get some time. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Mon Jan 5 07:38:49 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_33 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n05DcnIM023229 for ; Mon, 5 Jan 2009 07:38:49 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n05Dcnnj023228; Mon, 5 Jan 2009 07:38:49 -0600 Date: Mon, 5 Jan 2009 07:38:49 -0600 Message-Id: <200901051338.n05Dcnnj023228@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 400] lvm2 snapshots? X-Bugzilla-Reason: AssignedTo http://oss.sgi.com/bugzilla/show_bug.cgi?id=400 ------- Additional Comments From walter@sara.nl 2009-01-05 07:38 CST ------- I no longer have access to a test system with lvm+xfs, sorry. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Mon Jan 5 11:14:57 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n05HEvpp003589 for ; Mon, 5 Jan 2009 11:14:57 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n05HEvqK003588; Mon, 5 Jan 2009 11:14:57 -0600 Date: Mon, 5 Jan 2009 11:14:57 -0600 Message-Id: <200901051714.n05HEvqK003588@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 400] lvm2 snapshots? X-Bugzilla-Reason: AssignedTo http://oss.sgi.com/bugzilla/show_bug.cgi?id=400 hch@xfs.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |WORKSFORME ------- Additional Comments From hch@xfs.org 2009-01-05 11:14 CST ------- Closing as it's not reproducible anymore. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Wed Jan 7 10:20:01 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n07GK06H013409 for ; Wed, 7 Jan 2009 10:20:00 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n07GK0Ve013408; Wed, 7 Jan 2009 10:20:00 -0600 Date: Wed, 7 Jan 2009 10:20:00 -0600 Message-Id: <200901071620.n07GK0Ve013408@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 799] xfsdump fails for large page sizes X-Bugzilla-Reason: AssignedTo X-Virus-Scanned: ClamAV 0.91.2/8842/Wed Jan 7 08:06:50 2009 on oss.sgi.com X-Virus-Status: Clean http://oss.sgi.com/bugzilla/show_bug.cgi?id=799 sandeen-xfs@sandeen.net changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|xfs-masters@oss.sgi.com |wkendall@sgi.com ------- Additional Comments From sandeen-xfs@sandeen.net 2009-01-07 10:19 CST ------- Bill posted a patch for this. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From cattelan@thebarn.com Thu Jan 8 19:31:47 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n091VlRW031158 for ; Thu, 8 Jan 2009 19:31:47 -0600 X-ASG-Debug-ID: 1231464704-2fac00980000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from slurp.thebarn.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5625217C0EB8; Thu, 8 Jan 2009 17:31:44 -0800 (PST) Received: from slurp.thebarn.com (cattelan-host202.dsl.visi.com [208.42.117.202]) by cuda.sgi.com with ESMTP id i5OqYHFVBzgdJOzV; Thu, 08 Jan 2009 17:31:44 -0800 (PST) Received: from funky.thebarn.com (slurp.thebarn.com [208.42.117.201]) (authenticated bits=0) by slurp.thebarn.com (8.14.3/8.14.0) with ESMTP id n091Vm0i088419; Thu, 8 Jan 2009 19:31:48 -0600 (CST) (envelope-from cattelan@xfs.org) Message-ID: <4966A8FF.3080000@xfs.org> Date: Thu, 08 Jan 2009 19:31:43 -0600 From: Russell Cattelan User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: lachlan@sgi.com CC: xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: xfs list converted to mailman Subject: Re: xfs list converted to mailman References: <4964F31C.9000409@houseofnate.net> <4966A63B.8090201@sgi.com> In-Reply-To: <4966A63B.8090201@sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.91.2/8845/Thu Jan 8 10:52:13 2009 on oss.sgi.com X-Virus-Scanned: ClamAV 0.91.2/8835/Sun Jan 4 21:47:36 2009 on slurp.thebarn.com X-Virus-Status: Clean X-Barracuda-Connect: cattelan-host202.dsl.visi.com[208.42.117.202] X-Barracuda-Start-Time: 1231464706 X-Barracuda-Bayes: INNOCENT GLOBAL 0.1136 1.0000 -1.3118 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.31 X-Barracuda-Spam-Status: No, SCORE=-1.31 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14742 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Lachlan McIlroy wrote: > Nathaniel W. Turner wrote: >> *Hi, >> >> Russell Cattelan wrote */Wed Nov 12 22:49:54 CST 2008:/ >>> Please let me know of any issues that arise or any adjustments >>> to the list config that might be useful. >>> >> Would it be possible to update the page at >> http://oss.sgi.com/projects/xfs/mail.html ? >> >> It took me a little hunting to find >> http://oss.sgi.com/mailman/listinfo/xfs =) >> >> Cheers, >> nate >> > > Russ, if you wouldn't mind doing this could you also add > xfs-masters to http://oss.sgi.com/mailman/listinfo? Actually that list is purposely not publicized, it isn't suppose to be available to the general public. > > Thanks. > From cattelan@thebarn.com Thu Jan 8 19:46:48 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n091kmLS031821 for ; Thu, 8 Jan 2009 19:46:48 -0600 X-ASG-Debug-ID: 1231465606-1a6701fd0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from slurp.thebarn.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id E7B8D120CD33 for ; Thu, 8 Jan 2009 17:46:47 -0800 (PST) Received: from slurp.thebarn.com (cattelan-host202.dsl.visi.com [208.42.117.202]) by cuda.sgi.com with ESMTP id PHOO4F6MxgHZq8fE for ; Thu, 08 Jan 2009 17:46:47 -0800 (PST) Received: from funky.thebarn.com (slurp.thebarn.com [208.42.117.201]) (authenticated bits=0) by slurp.thebarn.com (8.14.3/8.14.0) with ESMTP id n091ko8n088622 for ; Thu, 8 Jan 2009 19:46:51 -0600 (CST) (envelope-from cattelan@xfs.org) Message-ID: <4966AC85.9070505@xfs.org> Date: Thu, 08 Jan 2009 19:46:45 -0600 From: Russell Cattelan User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Updated web info Subject: Updated web info Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.91.2/8845/Thu Jan 8 10:52:13 2009 on oss.sgi.com X-Virus-Scanned: ClamAV 0.91.2/8835/Sun Jan 4 21:47:36 2009 on slurp.thebarn.com X-Virus-Status: Clean X-Barracuda-Connect: cattelan-host202.dsl.visi.com[208.42.117.202] X-Barracuda-Start-Time: 1231465607 X-Barracuda-Bayes: INNOCENT GLOBAL 0.2688 1.0000 -0.4867 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.39 X-Barracuda-Spam-Status: No, SCORE=-0.39 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_SC0_SA085 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14742 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 BSF_SC0_SA085 Custom Rule SA085 I've done some work to update the xfs.org pages to reflect the recent changes to the mail list and the source management. http://xfs.org/index.php/XFS_email_list_and_archives http://xfs.org/index.php/Getting_the_latest_source_code I've also updated the main http://oss.sgi.com/projects/xfs page, (staged at this point) http://oss.sgi.com/projects/xfs-website/index.html I set most of the side links to point to xfs.org pages since that is current now. Let me know how it looks, or change it if you like. Oh also note: I turned off the cron job that updates the web site from the ptools -> cvs path. The website source has been imported into git, and we can use that now to update things. (which probably won't be much now that most things are in the wiki) http://oss.sgi.com/cgi-bin/gitweb.cgi?p=cattelan/xfs-website/.git;a=summary -Russell From lachlan@sgi.com Thu Jan 8 21:33:02 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n093X1El005302 for ; Thu, 8 Jan 2009 21:33:02 -0600 Received: from [134.14.55.78] (redback.melbourne.sgi.com [134.14.55.78]) by relay1.corp.sgi.com (Postfix) with ESMTP id 088158F80A5; Thu, 8 Jan 2009 19:32:56 -0800 (PST) Message-ID: <4966C5F5.70809@sgi.com> Date: Fri, 09 Jan 2009 14:35:17 +1100 From: Lachlan McIlroy Reply-To: lachlan@sgi.com Organization: SGI User-Agent: Thunderbird 2.0.0.19 (X11/20081209) MIME-Version: 1.0 To: Russell Cattelan CC: xfs-masters@oss.sgi.com Subject: Re: [xfs-masters] Updated web info References: <4966AC85.9070505@xfs.org> In-Reply-To: <4966AC85.9070505@xfs.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.91.2/8845/Thu Jan 8 10:52:13 2009 on oss.sgi.com X-Virus-Status: Clean Thanks for doing this Russ. On this page: http://xfs.org/index.php/XFS_email_list_and_archives The link to the mailman web interface is incorrect, it has this: http://oss.sgi.com/mailmain/listinfo/xfs Russell Cattelan wrote: > I've done some work to update the xfs.org pages to reflect the recent > changes to > the mail list and the source management. > > http://xfs.org/index.php/XFS_email_list_and_archives > > http://xfs.org/index.php/Getting_the_latest_source_code > > I've also updated the main http://oss.sgi.com/projects/xfs page, > (staged at this point) > > http://oss.sgi.com/projects/xfs-website/index.html > > I set most of the side links to point to xfs.org pages since > that is current now. > > Let me know how it looks, or change it if you like. > > Oh also note: I turned off the cron job that updates the web site from > the ptools -> cvs path. > > The website source has been imported into git, and we can use that > now to update things. (which probably won't be much now that most things > are in the wiki) > > http://oss.sgi.com/cgi-bin/gitweb.cgi?p=cattelan/xfs-website/.git;a=summary > > -Russell > > > > _______________________________________________ > xfs-masters mailing list > xfs-masters@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs-masters From a.beregalov@gmail.com Thu Jan 8 22:41:34 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=5.0 tests=BAYES_00,HEADER_ESQ, J_CHICKENPOX_23 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n094fXnI008646 for ; Thu, 8 Jan 2009 22:41:34 -0600 X-ASG-Debug-ID: 1231476091-32c302ca0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from fg-out-1718.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4DD807327C; Thu, 8 Jan 2009 20:41:31 -0800 (PST) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.155]) by cuda.sgi.com with ESMTP id 8g3d6V3Ih5udlz1X; Thu, 08 Jan 2009 20:41:31 -0800 (PST) Received: by fg-out-1718.google.com with SMTP id 19so1160331fgg.8 for ; Thu, 08 Jan 2009 20:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=yIKjG+u7I1JIjKCcTM9686mjp9XsDdDKxP3MsZ7XREQ=; b=IqqQFVovNki8Z0cHyjDkI8k8JCf7BO+mPi1AF2d88lBTG85MC94fz5kXS8SJ44/PMW F6hih5pIXroOhyMN8bGJyhWQU6SI04kKGNCoesqX1ojS0dGOwF77+OLAnLhdjTt3/fVU RQmZiBcbvauvlNCHbpGhflK1+LLt5FbTKAY20= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=vv/ztC2pnIPRaIS2EQiRC7l0kR5Su1WxBa3W8/NRyT7GTGiT7LI2Mjp+K+VNsCg9Ux kGNs7IftUHGSrPuwOj1U03graxgffBO5Z5icbv5MzFi6UfsFZIueuax7mSP8kEEx2yUX 5zAsEUsac5St7hCOw05uN85819W2UpX9pq8ps= Received: by 10.86.4.14 with SMTP id 14mr7261631fgd.27.1231476090932; Thu, 08 Jan 2009 20:41:30 -0800 (PST) Received: from @ (ppp91-78-18-183.pppoe.mtu-net.ru [91.78.18.183]) by mx.google.com with ESMTPS id e20sm3769989fga.23.2009.01.08.20.41.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 08 Jan 2009 20:41:27 -0800 (PST) Date: Fri, 9 Jan 2009 07:41:21 +0300 From: Alexander Beregalov To: xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090109044121.GA31280@orion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.16 (2007-06-09) X-Barracuda-Connect: fg-out-1718.google.com[72.14.220.155] X-Barracuda-Start-Time: 1231476093 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14754 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV 0.91.2/8845/Thu Jan 8 10:52:13 2009 on oss.sgi.com X-Virus-Status: Clean Hi I got this with the latest git (2150edc6c5cf00f7adb54538b9ea2a3e9cedca3f). Assertion failed: fs_is_ok, file: fs/xfs/xfs_btree.c, line: 3327 ------------[ cut here ]------------ kernel BUG at fs/xfs/support/debug.c:108! invalid opcode: 0000 [#1] PREEMPT DEBUG_PAGEALLOC last sysfs file: /sys/devices/platform/w83627hf.656/name Modules linked in: w83627hf hwmon_vid i2c_nforce2 Pid: 250, comm: pdflush Not tainted (2.6.28-07966-g2150edc #1) EIP: 0060:[] EFLAGS: 00010282 CPU: 0 EIP is at assfail+0x1e/0x30 EAX: 00000053 EBX: ef2ed170 ECX: 10000000 EDX: 10000000 ESI: 00000000 EDI: f6b158a4 EBP: f6b15838 ESP: f6b15828 DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068 Process pdflush (pid: 250, ti=f6b14000 task=f6b0d1c0 task.ti=f6b14000) Stack: c04bbeb0 c049ba44 c049c4d3 00000cff f6b158f0 c024f3ed 00000008 f0ba7000 f6b15894 f6b15878 f6b158e0 f0ba7000 00000010 f6b158fc 00000000 ef2ed170 00000000 f0b98000 f0ba7000 00000000 0000000b c024bb8d f6b158e8 f6b15890 Call Trace: [] ? xfs_btree_delrec+0xebd/0x1270 [] ? xfs_btree_lookup_get_block+0x9d/0x100 [] ? xfs_bmbt_init_key_from_rec+0xd/0x20 [] ? xfs_lookup_get_search_key+0x40/0x80 [] ? xfs_btree_delete+0x2c/0xa0 [] ? xfs_bmap_add_extent_delay_real+0x14bb/0x16f0 [] ? slab_pad_check+0x3c/0x120 [] ? check_object+0x13d/0x200 [] ? xfs_bmap_add_extent+0x626/0x670 [] ? xfs_bmbt_init_cursor+0x2c/0x100 [] ? xfs_bmapi+0xfc8/0x1c80 [] ? __lock_acquire+0x2b6/0x1190 [] ? __lock_acquire+0x2b6/0x1190 [] ? xfs_iomap_write_allocate+0x254/0x450 [] ? xfs_log_move_tail+0x190/0x1d0 [] ? xfs_iomap+0x3a7/0x3f0 [] ? __lock_acquire+0x2b6/0x1190 [] ? xfs_page_state_convert+0x32d/0x7b0 [] ? mark_held_locks+0x4c/0x90 [] ? xfs_vm_writepage+0x5e/0xf0 [] ? __writepage+0xb/0x40 [] ? write_cache_pages+0x1ab/0x370 [] ? __writepage+0x0/0x40 [] ? generic_writepages+0x23/0x30 [] ? xfs_vm_writepages+0x41/0x50 [] ? xfs_vm_writepages+0x0/0x50 [] ? do_writepages+0x2e/0x50 [] ? __writeback_single_inode+0x82/0x340 [] ? generic_sync_sb_inodes+0x26/0x390 [] ? _spin_lock+0x66/0x70 [] ? generic_sync_sb_inodes+0x2f2/0x390 [] ? writeback_inodes+0x56/0xe0 [] ? wb_kupdate+0x7b/0xf0 [] ? pdflush+0x0/0x190 [] ? pdflush+0xd0/0x190 [] ? wb_kupdate+0x0/0xf0 [] ? kthread+0x3a/0x70 [] ? kthread+0x0/0x70 [] ? kernel_thread_helper+0x7/0x14 Code: 00 e8 17 87 02 00 c9 c3 90 8d 74 26 00 55 89 e5 83 ec 10 89 4c 24 0c 89 54 24 08 89 44 24 04 c7 04 24 b0 be 4b c0 e8 fb 48 17 00 <0f> 0b eb fe 8d b4 26 00 00 00 00 8d bc 27 00 00 00 00 55 89 e5 EIP: [] assfail+0x1e/0x30 SS:ESP 0068:f6b15828 From david@fromorbit.com Thu Jan 8 23:39:15 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n095dEEc011729 for ; Thu, 8 Jan 2009 23:39:15 -0600 X-ASG-Debug-ID: 1231479545-13e8001a0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5BFEA17C17DD; Thu, 8 Jan 2009 21:39:05 -0800 (PST) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id l18vNB7n6b2VzFyH; Thu, 08 Jan 2009 21:39:05 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAB9wZkl5LDnl/2dsb2JhbADPYoV0 X-IronPort-AV: E=Sophos;i="4.37,238,1231075800"; d="scan'208";a="289630104" Received: from ppp121-44-57-229.lns10.syd7.internode.on.net (HELO disturbed) ([121.44.57.229]) by ipmail05.adl2.internode.on.net with ESMTP; 09 Jan 2009 16:09:01 +1030 Received: from dave by disturbed with local (Exim 4.69) (envelope-from ) id 1LLA5C-0007eJ-QH; Fri, 09 Jan 2009 16:38:58 +1100 Date: Fri, 9 Jan 2009 16:38:58 +1100 From: Dave Chinner To: Alexander Beregalov Cc: xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090109053858.GP9448@disturbed> Mail-Followup-To: Alexander Beregalov , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org References: <20090109044121.GA31280@orion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090109044121.GA31280@orion> User-Agent: Mutt/1.5.18 (2008-05-17) X-Barracuda-Connect: ipmail05.adl2.internode.on.net[203.16.214.145] X-Barracuda-Start-Time: 1231479554 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14757 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV 0.91.2/8845/Thu Jan 8 10:52:13 2009 on oss.sgi.com X-Virus-Status: Clean On Fri, Jan 09, 2009 at 07:41:21AM +0300, Alexander Beregalov wrote: > Hi > > I got this with the latest git (2150edc6c5cf00f7adb54538b9ea2a3e9cedca3f). > > Assertion failed: fs_is_ok, file: fs/xfs/xfs_btree.c, line: 3327 > ------------[ cut here ]------------ > kernel BUG at fs/xfs/support/debug.c:108! > invalid opcode: 0000 [#1] PREEMPT DEBUG_PAGEALLOC > last sysfs file: /sys/devices/platform/w83627hf.656/name > Modules linked in: w83627hf hwmon_vid i2c_nforce2 > > Pid: 250, comm: pdflush Not tainted (2.6.28-07966-g2150edc #1) > EIP: 0060:[] EFLAGS: 00010282 CPU: 0 > EIP is at assfail+0x1e/0x30 > EAX: 00000053 EBX: ef2ed170 ECX: 10000000 EDX: 10000000 > ESI: 00000000 EDI: f6b158a4 EBP: f6b15838 ESP: f6b15828 > DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068 > Process pdflush (pid: 250, ti=f6b14000 task=f6b0d1c0 task.ti=f6b14000) > Stack: > c04bbeb0 c049ba44 c049c4d3 00000cff f6b158f0 c024f3ed 00000008 f0ba7000 > f6b15894 f6b15878 f6b158e0 f0ba7000 00000010 f6b158fc 00000000 ef2ed170 > 00000000 f0b98000 f0ba7000 00000000 0000000b c024bb8d f6b158e8 f6b15890 > Call Trace: > [] ? xfs_btree_delrec+0xebd/0x1270 > [] ? xfs_btree_lookup_get_block+0x9d/0x100 > [] ? xfs_bmbt_init_key_from_rec+0xd/0x20 > [] ? xfs_lookup_get_search_key+0x40/0x80 > [] ? xfs_btree_delete+0x2c/0xa0 Looks like the same btree corruption problem as this: http://oss.sgi.com/archives/xfs/2009-01/msg00118.html We're working to find the cause right now, but I find it interesting that you are running a CONFIG_XFS_DEBUG=y kernel and the first point that something is found wrong is the same place that the above non-debug case is detecting corruption. Can you reproduce it/have a reproducable test case? Cheers, Dave. -- Dave Chinner david@fromorbit.com From a.beregalov@gmail.com Fri Jan 9 15:53:44 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n09LriSb026228 for ; Fri, 9 Jan 2009 15:53:44 -0600 X-ASG-Debug-ID: 1231538022-3f3e02bc0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from yw-out-1718.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 601DD76AE4; Fri, 9 Jan 2009 13:53:43 -0800 (PST) Received: from yw-out-1718.google.com (yw-out-1718.google.com [74.125.46.156]) by cuda.sgi.com with ESMTP id MGVyOuyLLNWuRnEe; Fri, 09 Jan 2009 13:53:43 -0800 (PST) Received: by yw-out-1718.google.com with SMTP id 5so3997967ywm.32 for ; Fri, 09 Jan 2009 13:53:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=xK8GCcl0L5UHGTt4D0/ZIUUJRR7h1CyTAAylMkFr63Y=; b=DggYtH1jbZkhfa5Ml5JmJXOjo+e+UiRrx/QKIJYJyxjyKOueoR7be+yxHLe+U6OtvG SxoPmIcwywx7SFi4+iVEeReJMWUCq05pYQkSxGwzsBeJL1mHlGfknJGejrvJbCg21aV7 7B4VPXuQg0rS05oT9+MrVMraTsFUkefJ91VXk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=B46YRlMKo9DXyn1DF3f/KqGr+zkHeZxEfT9vVg+OeGKVPCPzm5JeViDvMVdQetA6OZ XUAnjWt/ljA0zcw9KzFNa295zdpEVKb68C2uUSsu6HV92ZuaCuXUrGp5/Z2cl/6xQJ4J 0DExWlnbNVCGKrCEyaKPuT+caVgqBZAKyejbg= Received: by 10.100.106.12 with SMTP id e12mr14058593anc.18.1231538022653; Fri, 09 Jan 2009 13:53:42 -0800 (PST) Received: by 10.100.3.15 with HTTP; Fri, 9 Jan 2009 13:53:42 -0800 (PST) Message-ID: Date: Sat, 10 Jan 2009 00:53:42 +0300 From: "Alexander Beregalov" To: "Dave Chinner" , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 In-Reply-To: <20090109053858.GP9448@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> X-Barracuda-Connect: yw-out-1718.google.com[74.125.46.156] X-Barracuda-Start-Time: 1231538023 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14809 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8848/Fri Jan 9 07:16:38 2009 on oss.sgi.com X-Virus-Status: Clean 2009/1/9 Dave Chinner : > On Fri, Jan 09, 2009 at 07:41:21AM +0300, Alexander Beregalov wrote: > Looks like the same btree corruption problem as this: > > http://oss.sgi.com/archives/xfs/2009-01/msg00118.html > > We're working to find the cause right now, but I find it interesting > that you are running a CONFIG_XFS_DEBUG=y kernel and the first > point that something is found wrong is the same place that the > above non-debug case is detecting corruption. > > Can you reproduce it/have a reproducable test case? Yes, it is easy reproducible for me, it happens every time I run `rtorrent` during few minutes after boot. I will try to provide simpler testcase. From a.beregalov@gmail.com Fri Jan 9 17:20:39 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n09NKcxZ001341 for ; Fri, 9 Jan 2009 17:20:38 -0600 X-ASG-Debug-ID: 1231543236-30f101680000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from yx-out-1718.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 77F1717C9AB6 for ; Fri, 9 Jan 2009 15:20:36 -0800 (PST) Received: from yx-out-1718.google.com (yx-out-1718.google.com [74.125.44.158]) by cuda.sgi.com with ESMTP id mDKKuBbBGMPzUBZu for ; Fri, 09 Jan 2009 15:20:36 -0800 (PST) Received: by yx-out-1718.google.com with SMTP id 36so4013249yxh.32 for ; Fri, 09 Jan 2009 15:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=g3G8V9UgjMLOiURluV6ba7eLwK47+PcsyUqYjDyEwaE=; b=d7WMaxfbqczZwCfwNWlXDxXoQQCBB+1l6d/lMyQGR0yMmkuxCeDE4b50VKMn7OGS1z T5SeZmLWIPfpMAUjNdJ7nI1iuSI9H7e85FaUg0WaRSJ53y70OQMpuDUBxsD8RJ8UFKO0 FmYUJT1yM0ZJWiqnxuPZpS5OnX8V5z7NsD9nc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=GtV356WShyjhuJSQIRiPBGTFd+spqM2UnGLo3sUGBofAKGDhtkqa/5YBEEXiEWTHX6 A8b+fYYq/mab0TbpN9GOsW3QI9tfsOmhfKJJnOrquWzRxN92aoz2xRkZTJx/Ds1ahSKZ mBxrlDCjNIVrEaeCL2/KQ3jRkzx0blpfQ9ssE= Received: by 10.100.166.10 with SMTP id o10mr14058116ane.126.1231542664101; Fri, 09 Jan 2009 15:11:04 -0800 (PST) Received: by 10.100.3.15 with HTTP; Fri, 9 Jan 2009 15:11:03 -0800 (PST) Message-ID: Date: Sat, 10 Jan 2009 02:11:03 +0300 From: "Alexander Beregalov" To: "Dave Chinner" , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> X-Barracuda-Connect: yx-out-1718.google.com[74.125.44.158] X-Barracuda-Start-Time: 1231543237 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14815 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8848/Fri Jan 9 07:16:38 2009 on oss.sgi.com X-Virus-Status: Clean 2009/1/10 Alexander Beregalov : > 2009/1/10 Alexander Beregalov : >> 2009/1/9 Dave Chinner : >>> On Fri, Jan 09, 2009 at 07:41:21AM +0300, Alexander Beregalov wrote: >>> Looks like the same btree corruption problem as this: >>> >>> http://oss.sgi.com/archives/xfs/2009-01/msg00118.html >>> >>> We're working to find the cause right now, but I find it interesting >>> that you are running a CONFIG_XFS_DEBUG=y kernel and the first >>> point that something is found wrong is the same place that the >>> above non-debug case is detecting corruption. >>> >>> Can you reproduce it/have a reproducable test case? >> Yes, it is easy reproducible for me, it happens every time I run >> `rtorrent` during few minutes after boot. >> I will try to provide simpler testcase. >> > > This time I get it during log replaing before mounting. > > * Mounting local filesystems... > [ 214.039447] XFS mounting filesystem sda3 > [ 214.190773] Ending clean XFS mount for filesystem: sda3 > [ 214.321525] XFS mounting filesystem sdb1 > [ 214.453029] Starting XFS recovery on filesystem: sdb1 (logdev: internal) > [ 215.062964] Ending XFS recovery on filesystem: sdb1 (logdev: internal) > [ 215.163358] Assertion failed: fs_is_ok, file: fs/xfs/xfs_btree.c, line: 3327 Dave, how can I extract useful information from the log? How can I replay it by one transaction? Perhaps it is possibly to find the trasaction which triggers the bug. I used `xfs_logprint -C` to save the log, but it is more than 100Mb. From akpm@linux-foundation.org Fri Jan 9 18:41:30 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,J_CHICKENPOX_53, LOCAL_GNU_PATCH autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0A0fOvG006786 for ; Fri, 9 Jan 2009 18:41:30 -0600 X-ASG-Debug-ID: 1231548082-58e903ac0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2DF8D17C9DBB for ; Fri, 9 Jan 2009 16:41:22 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id 5DgbtYhbR7SE02CJ for ; Fri, 09 Jan 2009 16:41:22 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0A0f0hu013718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 9 Jan 2009 16:41:01 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0A0f0Xi013791; Fri, 9 Jan 2009 16:41:00 -0800 Message-Id: <200901100041.n0A0f0Xi013791@imap1.linux-foundation.org> X-ASG-Orig-Subj: [patch 6/8] filesystem freeze: implement generic freeze feature Subject: [patch 6/8] filesystem freeze: implement generic freeze feature To: torvalds@linux-foundation.org Cc: akpm@linux-foundation.org, t-sato@yk.jp.nec.com, agk@redhat.com, david@fromorbit.com, hch@lst.de, linux-ext4@vger.kernel.org, m-hamaguchi@ys.jp.nec.com, shaggy@austin.ibm.com, viro@zeniv.linux.org.uk, xfs-masters@oss.sgi.com From: akpm@linux-foundation.org Date: Fri, 09 Jan 2009 16:40:59 -0800 X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231548083 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.42 X-Barracuda-Spam-Status: No, SCORE=-1.42 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=MARKETING_SUBJECT, NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14818 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name 0.60 MARKETING_SUBJECT Subject contains popular marketing words X-Virus-Scanned: ClamAV 0.91.2/8848/Fri Jan 9 07:16:38 2009 on oss.sgi.com X-Virus-Status: Clean From: Takashi Sato The ioctls for the generic freeze feature are below. o Freeze the filesystem int ioctl(int fd, int FIFREEZE, arg) fd: The file descriptor of the mountpoint FIFREEZE: request code for the freeze arg: Ignored Return value: 0 if the operation succeeds. Otherwise, -1 o Unfreeze the filesystem int ioctl(int fd, int FITHAW, arg) fd: The file descriptor of the mountpoint FITHAW: request code for unfreeze arg: Ignored Return value: 0 if the operation succeeds. Otherwise, -1 Error number: If the filesystem has already been unfrozen, errno is set to EINVAL. [akpm@linux-foundation.org: fix CONFIG_BLOCK=n] Signed-off-by: Takashi Sato Signed-off-by: Masayuki Hamaguchi Cc: Cc: Cc: Christoph Hellwig Cc: Dave Kleikamp Cc: Dave Chinner Cc: Alasdair G Kergon Cc: Al Viro Signed-off-by: Andrew Morton --- fs/block_dev.c | 2 fs/buffer.c | 74 +++++++++++++++++++++++++++++----- fs/ioctl.c | 46 +++++++++++++++++++++ include/linux/buffer_head.h | 11 ++++- include/linux/fs.h | 7 +++ 5 files changed, 130 insertions(+), 10 deletions(-) diff -puN fs/block_dev.c~filesystem-freeze-implement-generic-freeze-feature fs/block_dev.c --- a/fs/block_dev.c~filesystem-freeze-implement-generic-freeze-feature +++ a/fs/block_dev.c @@ -285,6 +285,8 @@ static void init_once(void *foo) INIT_LIST_HEAD(&bdev->bd_holder_list); #endif inode_init_once(&ei->vfs_inode); + /* Initialize mutex for freeze. */ + mutex_init(&bdev->bd_fsfreeze_mutex); } static inline void __bd_forget(struct inode *inode) diff -puN fs/buffer.c~filesystem-freeze-implement-generic-freeze-feature fs/buffer.c --- a/fs/buffer.c~filesystem-freeze-implement-generic-freeze-feature +++ a/fs/buffer.c @@ -203,10 +203,25 @@ int fsync_bdev(struct block_device *bdev * happen on bdev until thaw_bdev() is called. * If a superblock is found on this device, we take the s_umount semaphore * on it to make sure nobody unmounts until the snapshot creation is done. + * The reference counter (bd_fsfreeze_count) guarantees that only the last + * unfreeze process can unfreeze the frozen filesystem actually when multiple + * freeze requests arrive simultaneously. It counts up in freeze_bdev() and + * count down in thaw_bdev(). When it becomes 0, thaw_bdev() will unfreeze + * actually. */ struct super_block *freeze_bdev(struct block_device *bdev) { struct super_block *sb; + int error = 0; + + mutex_lock(&bdev->bd_fsfreeze_mutex); + if (bdev->bd_fsfreeze_count > 0) { + bdev->bd_fsfreeze_count++; + sb = get_super(bdev); + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return sb; + } + bdev->bd_fsfreeze_count++; down(&bdev->bd_mount_sem); sb = get_super(bdev); @@ -221,11 +236,24 @@ struct super_block *freeze_bdev(struct b sync_blockdev(sb->s_bdev); - if (sb->s_op->freeze_fs) - sb->s_op->freeze_fs(sb); + if (sb->s_op->freeze_fs) { + error = sb->s_op->freeze_fs(sb); + if (error) { + printk(KERN_ERR + "VFS:Filesystem freeze failed\n"); + sb->s_frozen = SB_UNFROZEN; + drop_super(sb); + up(&bdev->bd_mount_sem); + bdev->bd_fsfreeze_count--; + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return ERR_PTR(error); + } + } } sync_blockdev(bdev); + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return sb; /* thaw_bdev releases s->s_umount and bd_mount_sem */ } EXPORT_SYMBOL(freeze_bdev); @@ -237,20 +265,48 @@ EXPORT_SYMBOL(freeze_bdev); * * Unlocks the filesystem and marks it writeable again after freeze_bdev(). */ -void thaw_bdev(struct block_device *bdev, struct super_block *sb) +int thaw_bdev(struct block_device *bdev, struct super_block *sb) { + int error = 0; + + mutex_lock(&bdev->bd_fsfreeze_mutex); + if (!bdev->bd_fsfreeze_count) { + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return -EINVAL; + } + + bdev->bd_fsfreeze_count--; + if (bdev->bd_fsfreeze_count > 0) { + if (sb) + drop_super(sb); + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return 0; + } + if (sb) { BUG_ON(sb->s_bdev != bdev); - - if (sb->s_op->unfreeze_fs) - sb->s_op->unfreeze_fs(sb); - sb->s_frozen = SB_UNFROZEN; - smp_wmb(); - wake_up(&sb->s_wait_unfrozen); + if (!(sb->s_flags & MS_RDONLY)) { + if (sb->s_op->unfreeze_fs) { + error = sb->s_op->unfreeze_fs(sb); + if (error) { + printk(KERN_ERR + "VFS:Filesystem thaw failed\n"); + sb->s_frozen = SB_FREEZE_TRANS; + bdev->bd_fsfreeze_count++; + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return error; + } + } + sb->s_frozen = SB_UNFROZEN; + smp_wmb(); + wake_up(&sb->s_wait_unfrozen); + } drop_super(sb); } up(&bdev->bd_mount_sem); + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return 0; } EXPORT_SYMBOL(thaw_bdev); diff -puN fs/ioctl.c~filesystem-freeze-implement-generic-freeze-feature fs/ioctl.c --- a/fs/ioctl.c~filesystem-freeze-implement-generic-freeze-feature +++ a/fs/ioctl.c @@ -439,6 +439,43 @@ static int ioctl_fioasync(unsigned int f return error; } +static int ioctl_fsfreeze(struct file *filp) +{ + struct super_block *sb = filp->f_path.dentry->d_inode->i_sb; + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + /* If filesystem doesn't support freeze feature, return. */ + if (sb->s_op->freeze_fs == NULL) + return -EOPNOTSUPP; + + /* If a blockdevice-backed filesystem isn't specified, return. */ + if (sb->s_bdev == NULL) + return -EINVAL; + + /* Freeze */ + sb = freeze_bdev(sb->s_bdev); + if (IS_ERR(sb)) + return PTR_ERR(sb); + return 0; +} + +static int ioctl_fsthaw(struct file *filp) +{ + struct super_block *sb = filp->f_path.dentry->d_inode->i_sb; + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + /* If a blockdevice-backed filesystem isn't specified, return EINVAL. */ + if (sb->s_bdev == NULL) + return -EINVAL; + + /* Thaw */ + return thaw_bdev(sb->s_bdev, sb); +} + /* * When you add any new common ioctls to the switches above and below * please update compat_sys_ioctl() too. @@ -486,6 +523,15 @@ int do_vfs_ioctl(struct file *filp, unsi } else error = -ENOTTY; break; + + case FIFREEZE: + error = ioctl_fsfreeze(filp); + break; + + case FITHAW: + error = ioctl_fsthaw(filp); + break; + default: if (S_ISREG(filp->f_path.dentry->d_inode->i_mode)) error = file_ioctl(filp, cmd, arg); diff -puN include/linux/buffer_head.h~filesystem-freeze-implement-generic-freeze-feature include/linux/buffer_head.h --- a/include/linux/buffer_head.h~filesystem-freeze-implement-generic-freeze-feature +++ a/include/linux/buffer_head.h @@ -171,7 +171,7 @@ void __wait_on_buffer(struct buffer_head wait_queue_head_t *bh_waitq_head(struct buffer_head *bh); int fsync_bdev(struct block_device *); struct super_block *freeze_bdev(struct block_device *); -void thaw_bdev(struct block_device *, struct super_block *); +int thaw_bdev(struct block_device *, struct super_block *); int fsync_super(struct super_block *); int fsync_no_super(struct block_device *); struct buffer_head *__find_get_block(struct block_device *bdev, sector_t block, @@ -346,6 +346,15 @@ static inline int remove_inode_buffers(s static inline int sync_mapping_buffers(struct address_space *mapping) { return 0; } static inline void invalidate_bdev(struct block_device *bdev) {} +static inline struct super_block *freeze_bdev(struct block_device *sb) +{ + return NULL; +} + +static inline int thaw_bdev(struct block_device *bdev, struct super_block *sb) +{ + return 0; +} #endif /* CONFIG_BLOCK */ #endif /* _LINUX_BUFFER_HEAD_H */ diff -puN include/linux/fs.h~filesystem-freeze-implement-generic-freeze-feature include/linux/fs.h --- a/include/linux/fs.h~filesystem-freeze-implement-generic-freeze-feature +++ a/include/linux/fs.h @@ -234,6 +234,8 @@ struct inodes_stat_t { #define BMAP_IOCTL 1 /* obsolete - kept for compatibility */ #define FIBMAP _IO(0x00,1) /* bmap access */ #define FIGETBSZ _IO(0x00,2) /* get the block size used for bmap */ +#define FIFREEZE _IOWR('X', 119, int) /* Freeze */ +#define FITHAW _IOWR('X', 120, int) /* Thaw */ #define FS_IOC_GETFLAGS _IOR('f', 1, long) #define FS_IOC_SETFLAGS _IOW('f', 2, long) @@ -591,6 +593,11 @@ struct block_device { * care to not mess up bd_private for that case. */ unsigned long bd_private; + + /* The counter of freeze processes */ + int bd_fsfreeze_count; + /* Mutex for freeze */ + struct mutex bd_fsfreeze_mutex; }; /* _ From akpm@linux-foundation.org Fri Jan 9 18:41:30 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0A0fULY006790 for ; Fri, 9 Jan 2009 18:41:30 -0600 X-ASG-Debug-ID: 1231548083-01ec009f0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id CE1E67799C for ; Fri, 9 Jan 2009 16:41:23 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id 0Vp72c5n5mjNBoM9 for ; Fri, 09 Jan 2009 16:41:23 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0A0exVu013710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 9 Jan 2009 16:41:00 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0A0ewXd013787; Fri, 9 Jan 2009 16:40:58 -0800 Message-Id: <200901100040.n0A0ewXd013787@imap1.linux-foundation.org> X-ASG-Orig-Subj: [patch 5/8] filesystem freeze: add error handling of write_super_lockfs/unlockfs Subject: [patch 5/8] filesystem freeze: add error handling of write_super_lockfs/unlockfs To: torvalds@linux-foundation.org Cc: akpm@linux-foundation.org, t-sato@yk.jp.nec.com, agk@redhat.com, david@fromorbit.com, hch@lst.de, linux-ext4@vger.kernel.org, m-hamaguchi@ys.jp.nec.com, shaggy@austin.ibm.com, viro@zeniv.linux.org.uk, xfs-masters@oss.sgi.com From: akpm@linux-foundation.org Date: Fri, 09 Jan 2009 16:40:58 -0800 X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231548088 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14818 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8848/Fri Jan 9 07:16:38 2009 on oss.sgi.com X-Virus-Status: Clean From: Takashi Sato Currently, ext3 in mainline Linux doesn't have the freeze feature which suspends write requests. So, we cannot take a backup which keeps the filesystem's consistency with the storage device's features (snapshot and replication) while it is mounted. In many case, a commercial filesystem (e.g. VxFS) has the freeze feature and it would be used to get the consistent backup. If Linux's standard filesystem ext3 has the freeze feature, we can do it without a commercial filesystem. So I have implemented the ioctls of the freeze feature. I think we can take the consistent backup with the following steps. 1. Freeze the filesystem with the freeze ioctl. 2. Separate the replication volume or create the snapshot with the storage device's feature. 3. Unfreeze the filesystem with the unfreeze ioctl. 4. Take the backup from the separated replication volume or the snapshot. This patch: VFS: Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that they can return an error. Rename write_super_lockfs and unlockfs of the super block operation freeze_fs and unfreeze_fs to avoid a confusion. ext3, ext4, xfs, gfs2, jfs: Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that write_super_lockfs returns an error if needed, and unlockfs always returns 0. reiserfs: Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that they always return 0 (success) to keep a current behavior. Signed-off-by: Takashi Sato Signed-off-by: Masayuki Hamaguchi Cc: Cc: Cc: Christoph Hellwig Cc: Dave Kleikamp Cc: Dave Chinner Cc: Alasdair G Kergon Cc: Al Viro Signed-off-by: Andrew Morton --- Documentation/filesystems/Locking | 8 ++-- Documentation/filesystems/vfs.txt | 8 ++-- fs/buffer.c | 8 ++-- fs/ext3/super.c | 45 ++++++++++++++++++---------- fs/ext4/super.c | 45 +++++++++++++++++++--------- fs/gfs2/ops_super.c | 16 +++++---- fs/jfs/super.c | 10 +++--- fs/reiserfs/super.c | 10 +++--- fs/xfs/linux-2.6/xfs_super.c | 8 ++-- fs/xfs/xfs_fsops.c | 11 ++++-- fs/xfs/xfs_fsops.h | 2 - include/linux/fs.h | 4 +- 12 files changed, 107 insertions(+), 68 deletions(-) diff -puN Documentation/filesystems/Locking~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs Documentation/filesystems/Locking --- a/Documentation/filesystems/Locking~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/Documentation/filesystems/Locking @@ -97,8 +97,8 @@ prototypes: void (*put_super) (struct super_block *); void (*write_super) (struct super_block *); int (*sync_fs)(struct super_block *sb, int wait); - void (*write_super_lockfs) (struct super_block *); - void (*unlockfs) (struct super_block *); + int (*freeze_fs) (struct super_block *); + int (*unfreeze_fs) (struct super_block *); int (*statfs) (struct dentry *, struct kstatfs *); int (*remount_fs) (struct super_block *, int *, char *); void (*clear_inode) (struct inode *); @@ -119,8 +119,8 @@ delete_inode: no put_super: yes yes no write_super: no yes read sync_fs: no no read -write_super_lockfs: ? -unlockfs: ? +freeze_fs: ? +unfreeze_fs: ? statfs: no no no remount_fs: yes yes maybe (see below) clear_inode: no diff -puN Documentation/filesystems/vfs.txt~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs Documentation/filesystems/vfs.txt --- a/Documentation/filesystems/vfs.txt~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/Documentation/filesystems/vfs.txt @@ -210,8 +210,8 @@ struct super_operations { void (*put_super) (struct super_block *); void (*write_super) (struct super_block *); int (*sync_fs)(struct super_block *sb, int wait); - void (*write_super_lockfs) (struct super_block *); - void (*unlockfs) (struct super_block *); + int (*freeze_fs) (struct super_block *); + int (*unfreeze_fs) (struct super_block *); int (*statfs) (struct dentry *, struct kstatfs *); int (*remount_fs) (struct super_block *, int *, char *); void (*clear_inode) (struct inode *); @@ -270,11 +270,11 @@ or bottom half). a superblock. The second parameter indicates whether the method should wait until the write out has been completed. Optional. - write_super_lockfs: called when VFS is locking a filesystem and + freeze_fs: called when VFS is locking a filesystem and forcing it into a consistent state. This method is currently used by the Logical Volume Manager (LVM). - unlockfs: called when VFS is unlocking a filesystem and making it writable + unfreeze_fs: called when VFS is unlocking a filesystem and making it writable again. statfs: called when the VFS needs to get filesystem statistics. This diff -puN fs/buffer.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/buffer.c --- a/fs/buffer.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/buffer.c @@ -221,8 +221,8 @@ struct super_block *freeze_bdev(struct b sync_blockdev(sb->s_bdev); - if (sb->s_op->write_super_lockfs) - sb->s_op->write_super_lockfs(sb); + if (sb->s_op->freeze_fs) + sb->s_op->freeze_fs(sb); } sync_blockdev(bdev); @@ -242,8 +242,8 @@ void thaw_bdev(struct block_device *bdev if (sb) { BUG_ON(sb->s_bdev != bdev); - if (sb->s_op->unlockfs) - sb->s_op->unlockfs(sb); + if (sb->s_op->unfreeze_fs) + sb->s_op->unfreeze_fs(sb); sb->s_frozen = SB_UNFROZEN; smp_wmb(); wake_up(&sb->s_wait_unfrozen); diff -puN fs/ext3/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/ext3/super.c --- a/fs/ext3/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/ext3/super.c @@ -48,8 +48,8 @@ static int ext3_load_journal(struct supe unsigned long journal_devnum); static int ext3_create_journal(struct super_block *, struct ext3_super_block *, unsigned int); -static void ext3_commit_super (struct super_block * sb, - struct ext3_super_block * es, +static int ext3_commit_super(struct super_block *sb, + struct ext3_super_block *es, int sync); static void ext3_mark_recovery_complete(struct super_block * sb, struct ext3_super_block * es); @@ -60,9 +60,9 @@ static const char *ext3_decode_error(str char nbuf[16]); static int ext3_remount (struct super_block * sb, int * flags, char * data); static int ext3_statfs (struct dentry * dentry, struct kstatfs * buf); -static void ext3_unlockfs(struct super_block *sb); +static int ext3_unfreeze(struct super_block *sb); static void ext3_write_super (struct super_block * sb); -static void ext3_write_super_lockfs(struct super_block *sb); +static int ext3_freeze(struct super_block *sb); /* * Wrappers for journal_start/end. @@ -759,8 +759,8 @@ static const struct super_operations ext .put_super = ext3_put_super, .write_super = ext3_write_super, .sync_fs = ext3_sync_fs, - .write_super_lockfs = ext3_write_super_lockfs, - .unlockfs = ext3_unlockfs, + .freeze_fs = ext3_freeze, + .unfreeze_fs = ext3_unfreeze, .statfs = ext3_statfs, .remount_fs = ext3_remount, .clear_inode = ext3_clear_inode, @@ -2311,21 +2311,23 @@ static int ext3_create_journal(struct su return 0; } -static void ext3_commit_super (struct super_block * sb, - struct ext3_super_block * es, +static int ext3_commit_super(struct super_block *sb, + struct ext3_super_block *es, int sync) { struct buffer_head *sbh = EXT3_SB(sb)->s_sbh; + int error = 0; if (!sbh) - return; + return error; es->s_wtime = cpu_to_le32(get_seconds()); es->s_free_blocks_count = cpu_to_le32(ext3_count_free_blocks(sb)); es->s_free_inodes_count = cpu_to_le32(ext3_count_free_inodes(sb)); BUFFER_TRACE(sbh, "marking dirty"); mark_buffer_dirty(sbh); if (sync) - sync_dirty_buffer(sbh); + error = sync_dirty_buffer(sbh); + return error; } @@ -2439,12 +2441,14 @@ static int ext3_sync_fs(struct super_blo * LVM calls this function before a (read-only) snapshot is created. This * gives us a chance to flush the journal completely and mark the fs clean. */ -static void ext3_write_super_lockfs(struct super_block *sb) +static int ext3_freeze(struct super_block *sb) { + int error = 0; + journal_t *journal; sb->s_dirt = 0; if (!(sb->s_flags & MS_RDONLY)) { - journal_t *journal = EXT3_SB(sb)->s_journal; + journal = EXT3_SB(sb)->s_journal; /* Now we set up the journal barrier. */ journal_lock_updates(journal); @@ -2453,20 +2457,28 @@ static void ext3_write_super_lockfs(stru * We don't want to clear needs_recovery flag when we failed * to flush the journal. */ - if (journal_flush(journal) < 0) - return; + error = journal_flush(journal); + if (error < 0) + goto out; /* Journal blocked and flushed, clear needs_recovery flag. */ EXT3_CLEAR_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER); - ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1); + error = ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1); + if (error) + goto out; } + return 0; + +out: + journal_unlock_updates(journal); + return error; } /* * Called by LVM after the snapshot is done. We need to reset the RECOVER * flag here, even though the filesystem is not technically dirty yet. */ -static void ext3_unlockfs(struct super_block *sb) +static int ext3_unfreeze(struct super_block *sb) { if (!(sb->s_flags & MS_RDONLY)) { lock_super(sb); @@ -2476,6 +2488,7 @@ static void ext3_unlockfs(struct super_b unlock_super(sb); journal_unlock_updates(EXT3_SB(sb)->s_journal); } + return 0; } static int ext3_remount (struct super_block * sb, int * flags, char * data) diff -puN fs/ext4/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/ext4/super.c --- a/fs/ext4/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/ext4/super.c @@ -51,7 +51,7 @@ struct proc_dir_entry *ext4_proc_root; static int ext4_load_journal(struct super_block *, struct ext4_super_block *, unsigned long journal_devnum); -static void ext4_commit_super(struct super_block *sb, +static int ext4_commit_super(struct super_block *sb, struct ext4_super_block *es, int sync); static void ext4_mark_recovery_complete(struct super_block *sb, struct ext4_super_block *es); @@ -62,9 +62,9 @@ static const char *ext4_decode_error(str char nbuf[16]); static int ext4_remount(struct super_block *sb, int *flags, char *data); static int ext4_statfs(struct dentry *dentry, struct kstatfs *buf); -static void ext4_unlockfs(struct super_block *sb); +static int ext4_unfreeze(struct super_block *sb); static void ext4_write_super(struct super_block *sb); -static void ext4_write_super_lockfs(struct super_block *sb); +static int ext4_freeze(struct super_block *sb); ext4_fsblk_t ext4_block_bitmap(struct super_block *sb, @@ -978,8 +978,8 @@ static const struct super_operations ext .put_super = ext4_put_super, .write_super = ext4_write_super, .sync_fs = ext4_sync_fs, - .write_super_lockfs = ext4_write_super_lockfs, - .unlockfs = ext4_unlockfs, + .freeze_fs = ext4_freeze, + .unfreeze_fs = ext4_unfreeze, .statfs = ext4_statfs, .remount_fs = ext4_remount, .clear_inode = ext4_clear_inode, @@ -2888,13 +2888,14 @@ static int ext4_load_journal(struct supe return 0; } -static void ext4_commit_super(struct super_block *sb, +static int ext4_commit_super(struct super_block *sb, struct ext4_super_block *es, int sync) { struct buffer_head *sbh = EXT4_SB(sb)->s_sbh; + int error = 0; if (!sbh) - return; + return error; if (buffer_write_io_error(sbh)) { /* * Oh, dear. A previous attempt to write the @@ -2918,14 +2919,19 @@ static void ext4_commit_super(struct sup BUFFER_TRACE(sbh, "marking dirty"); mark_buffer_dirty(sbh); if (sync) { - sync_dirty_buffer(sbh); - if (buffer_write_io_error(sbh)) { + error = sync_dirty_buffer(sbh); + if (error) + return error; + + error = buffer_write_io_error(sbh); + if (error) { printk(KERN_ERR "EXT4-fs: I/O error while writing " "superblock for %s.\n", sb->s_id); clear_buffer_write_io_error(sbh); set_buffer_uptodate(sbh); } } + return error; } @@ -3058,12 +3064,14 @@ static int ext4_sync_fs(struct super_blo * LVM calls this function before a (read-only) snapshot is created. This * gives us a chance to flush the journal completely and mark the fs clean. */ -static void ext4_write_super_lockfs(struct super_block *sb) +static int ext4_freeze(struct super_block *sb) { + int error = 0; + journal_t *journal; sb->s_dirt = 0; if (!(sb->s_flags & MS_RDONLY)) { - journal_t *journal = EXT4_SB(sb)->s_journal; + journal = EXT4_SB(sb)->s_journal; if (journal) { /* Now we set up the journal barrier. */ @@ -3073,21 +3081,29 @@ static void ext4_write_super_lockfs(stru * We don't want to clear needs_recovery flag when we * failed to flush the journal. */ - if (jbd2_journal_flush(journal) < 0) - return; + error = jbd2_journal_flush(journal); + if (error < 0) + goto out; } /* Journal blocked and flushed, clear needs_recovery flag. */ EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER); ext4_commit_super(sb, EXT4_SB(sb)->s_es, 1); + error = ext4_commit_super(sb, EXT4_SB(sb)->s_es, 1); + if (error) + goto out; } + return 0; +out: + jbd2_journal_unlock_updates(journal); + return error; } /* * Called by LVM after the snapshot is done. We need to reset the RECOVER * flag here, even though the filesystem is not technically dirty yet. */ -static void ext4_unlockfs(struct super_block *sb) +static int ext4_unfreeze(struct super_block *sb) { if (EXT4_SB(sb)->s_journal && !(sb->s_flags & MS_RDONLY)) { lock_super(sb); @@ -3097,6 +3113,7 @@ static void ext4_unlockfs(struct super_b unlock_super(sb); jbd2_journal_unlock_updates(EXT4_SB(sb)->s_journal); } + return 0; } static int ext4_remount(struct super_block *sb, int *flags, char *data) diff -puN fs/gfs2/ops_super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/gfs2/ops_super.c --- a/fs/gfs2/ops_super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/gfs2/ops_super.c @@ -211,18 +211,18 @@ static int gfs2_sync_fs(struct super_blo } /** - * gfs2_write_super_lockfs - prevent further writes to the filesystem + * gfs2_freeze - prevent further writes to the filesystem * @sb: the VFS structure for the filesystem * */ -static void gfs2_write_super_lockfs(struct super_block *sb) +static int gfs2_freeze(struct super_block *sb) { struct gfs2_sbd *sdp = sb->s_fs_info; int error; if (test_bit(SDF_SHUTDOWN, &sdp->sd_flags)) - return; + return -EINVAL; for (;;) { error = gfs2_freeze_fs(sdp); @@ -242,17 +242,19 @@ static void gfs2_write_super_lockfs(stru fs_err(sdp, "retrying...\n"); msleep(1000); } + return 0; } /** - * gfs2_unlockfs - reallow writes to the filesystem + * gfs2_unfreeze - reallow writes to the filesystem * @sb: the VFS structure for the filesystem * */ -static void gfs2_unlockfs(struct super_block *sb) +static int gfs2_unfreeze(struct super_block *sb) { gfs2_unfreeze_fs(sb->s_fs_info); + return 0; } /** @@ -688,8 +690,8 @@ const struct super_operations gfs2_super .put_super = gfs2_put_super, .write_super = gfs2_write_super, .sync_fs = gfs2_sync_fs, - .write_super_lockfs = gfs2_write_super_lockfs, - .unlockfs = gfs2_unlockfs, + .freeze_fs = gfs2_freeze, + .unfreeze_fs = gfs2_unfreeze, .statfs = gfs2_statfs, .remount_fs = gfs2_remount_fs, .clear_inode = gfs2_clear_inode, diff -puN fs/jfs/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/jfs/super.c --- a/fs/jfs/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/jfs/super.c @@ -543,7 +543,7 @@ out_kfree: return ret; } -static void jfs_write_super_lockfs(struct super_block *sb) +static int jfs_freeze(struct super_block *sb) { struct jfs_sb_info *sbi = JFS_SBI(sb); struct jfs_log *log = sbi->log; @@ -553,9 +553,10 @@ static void jfs_write_super_lockfs(struc lmLogShutdown(log); updateSuper(sb, FM_CLEAN); } + return 0; } -static void jfs_unlockfs(struct super_block *sb) +static int jfs_unfreeze(struct super_block *sb) { struct jfs_sb_info *sbi = JFS_SBI(sb); struct jfs_log *log = sbi->log; @@ -568,6 +569,7 @@ static void jfs_unlockfs(struct super_bl else txResume(sb); } + return 0; } static int jfs_get_sb(struct file_system_type *fs_type, @@ -735,8 +737,8 @@ static const struct super_operations jfs .delete_inode = jfs_delete_inode, .put_super = jfs_put_super, .sync_fs = jfs_sync_fs, - .write_super_lockfs = jfs_write_super_lockfs, - .unlockfs = jfs_unlockfs, + .freeze_fs = jfs_freeze, + .unfreeze_fs = jfs_unfreeze, .statfs = jfs_statfs, .remount_fs = jfs_remount, .show_options = jfs_show_options, diff -puN fs/reiserfs/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/reiserfs/super.c --- a/fs/reiserfs/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/reiserfs/super.c @@ -83,7 +83,7 @@ static void reiserfs_write_super(struct reiserfs_sync_fs(s, 1); } -static void reiserfs_write_super_lockfs(struct super_block *s) +static int reiserfs_freeze(struct super_block *s) { struct reiserfs_transaction_handle th; reiserfs_write_lock(s); @@ -101,11 +101,13 @@ static void reiserfs_write_super_lockfs( } s->s_dirt = 0; reiserfs_write_unlock(s); + return 0; } -static void reiserfs_unlockfs(struct super_block *s) +static int reiserfs_unfreeze(struct super_block *s) { reiserfs_allow_writes(s); + return 0; } extern const struct in_core_key MAX_IN_CORE_KEY; @@ -613,8 +615,8 @@ static const struct super_operations rei .put_super = reiserfs_put_super, .write_super = reiserfs_write_super, .sync_fs = reiserfs_sync_fs, - .write_super_lockfs = reiserfs_write_super_lockfs, - .unlockfs = reiserfs_unlockfs, + .freeze_fs = reiserfs_freeze, + .unfreeze_fs = reiserfs_unfreeze, .statfs = reiserfs_statfs, .remount_fs = reiserfs_remount, .show_options = generic_show_options, diff -puN fs/xfs/linux-2.6/xfs_super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/xfs/linux-2.6/xfs_super.c --- a/fs/xfs/linux-2.6/xfs_super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/xfs/linux-2.6/xfs_super.c @@ -1269,14 +1269,14 @@ xfs_fs_remount( * need to take care of the metadata. Once that's done write a dummy * record to dirty the log in case of a crash while frozen. */ -STATIC void -xfs_fs_lockfs( +STATIC int +xfs_fs_freeze( struct super_block *sb) { struct xfs_mount *mp = XFS_M(sb); xfs_quiesce_attr(mp); - xfs_fs_log_dummy(mp); + return -xfs_fs_log_dummy(mp); } STATIC int @@ -1557,7 +1557,7 @@ static struct super_operations xfs_super .put_super = xfs_fs_put_super, .write_super = xfs_fs_write_super, .sync_fs = xfs_fs_sync_super, - .write_super_lockfs = xfs_fs_lockfs, + .freeze_fs = xfs_fs_freeze, .statfs = xfs_fs_statfs, .remount_fs = xfs_fs_remount, .show_options = xfs_fs_show_options, diff -puN fs/xfs/xfs_fsops.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/xfs/xfs_fsops.c --- a/fs/xfs/xfs_fsops.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/xfs/xfs_fsops.c @@ -595,17 +595,19 @@ out: return 0; } -void +int xfs_fs_log_dummy( xfs_mount_t *mp) { xfs_trans_t *tp; xfs_inode_t *ip; + int error; tp = _xfs_trans_alloc(mp, XFS_TRANS_DUMMY1); - if (xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0)) { + error = xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0); + if (error) { xfs_trans_cancel(tp, 0); - return; + return error; } ip = mp->m_rootip; @@ -615,9 +617,10 @@ xfs_fs_log_dummy( xfs_trans_ihold(tp, ip); xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); xfs_trans_set_sync(tp); - xfs_trans_commit(tp, 0); + error = xfs_trans_commit(tp, 0); xfs_iunlock(ip, XFS_ILOCK_EXCL); + return error; } int diff -puN fs/xfs/xfs_fsops.h~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/xfs/xfs_fsops.h --- a/fs/xfs/xfs_fsops.h~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/xfs/xfs_fsops.h @@ -25,6 +25,6 @@ extern int xfs_fs_counts(xfs_mount_t *mp extern int xfs_reserve_blocks(xfs_mount_t *mp, __uint64_t *inval, xfs_fsop_resblks_t *outval); extern int xfs_fs_goingdown(xfs_mount_t *mp, __uint32_t inflags); -extern void xfs_fs_log_dummy(xfs_mount_t *mp); +extern int xfs_fs_log_dummy(xfs_mount_t *mp); #endif /* __XFS_FSOPS_H__ */ diff -puN include/linux/fs.h~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs include/linux/fs.h --- a/include/linux/fs.h~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/include/linux/fs.h @@ -1377,8 +1377,8 @@ struct super_operations { void (*put_super) (struct super_block *); void (*write_super) (struct super_block *); int (*sync_fs)(struct super_block *sb, int wait); - void (*write_super_lockfs) (struct super_block *); - void (*unlockfs) (struct super_block *); + int (*freeze_fs) (struct super_block *); + int (*unfreeze_fs) (struct super_block *); int (*statfs) (struct dentry *, struct kstatfs *); int (*remount_fs) (struct super_block *, int *, char *); void (*clear_inode) (struct inode *); _ From a.beregalov@gmail.com Fri Jan 9 18:45:23 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0A0jNWx006932 for ; Fri, 9 Jan 2009 18:45:23 -0600 X-ASG-Debug-ID: 1231548322-45c0000f0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from an-out-0708.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 92B8F1BA264B for ; Fri, 9 Jan 2009 16:45:22 -0800 (PST) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.251]) by cuda.sgi.com with ESMTP id HS6r3VjqX0k59HNt for ; Fri, 09 Jan 2009 16:45:22 -0800 (PST) Received: by an-out-0708.google.com with SMTP id c37so4006390anc.32 for ; Fri, 09 Jan 2009 16:45:21 -0800 (PST) Received: by 10.100.93.17 with SMTP id q17mr11872011anb.45.1231539521712; Fri, 09 Jan 2009 14:18:41 -0800 (PST) Received: by 10.100.3.15 with HTTP; Fri, 9 Jan 2009 14:18:41 -0800 (PST) Message-ID: Date: Sat, 10 Jan 2009 01:18:41 +0300 From: "Alexander Beregalov" To: "Dave Chinner" , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> X-Barracuda-Connect: an-out-0708.google.com[209.85.132.251] X-Barracuda-Start-Time: 1231548322 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14818 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8848/Fri Jan 9 07:16:38 2009 on oss.sgi.com X-Virus-Status: Clean 2009/1/10 Alexander Beregalov : > 2009/1/9 Dave Chinner : >> On Fri, Jan 09, 2009 at 07:41:21AM +0300, Alexander Beregalov wrote: >> Looks like the same btree corruption problem as this: >> >> http://oss.sgi.com/archives/xfs/2009-01/msg00118.html >> >> We're working to find the cause right now, but I find it interesting >> that you are running a CONFIG_XFS_DEBUG=y kernel and the first >> point that something is found wrong is the same place that the >> above non-debug case is detecting corruption. >> >> Can you reproduce it/have a reproducable test case? > Yes, it is easy reproducible for me, it happens every time I run > `rtorrent` during few minutes after boot. > I will try to provide simpler testcase. > This time I get it during log replaing before mounting. * Mounting local filesystems... [ 214.039447] XFS mounting filesystem sda3 [ 214.190773] Ending clean XFS mount for filesystem: sda3 [ 214.321525] XFS mounting filesystem sdb1 [ 214.453029] Starting XFS recovery on filesystem: sdb1 (logdev: internal) [ 215.062964] Ending XFS recovery on filesystem: sdb1 (logdev: internal) [ 215.163358] Assertion failed: fs_is_ok, file: fs/xfs/xfs_btree.c, line: 3327 [ 215.248223] ------------[ cut here ]------------ [ 215.257815] kernel BUG at fs/xfs/support/debug.c:108! [ 215.257815] invalid opcode: 0000 [#1] PREEMPT DEBUG_PAGEALLOC [ 215.257815] last sysfs file: /sys/kernel/uevent_seqnum [ 215.257815] Modules linked in: i2c_nforce2 [ 215.257815] [ 215.257815] Pid: 764, comm: async/1 Not tainted (2.6.28-08160-g7c51d57 #1) It seems I need to downgrade the kernel to boot the machine. From a.beregalov@gmail.com Sat Jan 10 06:19:01 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0ACJ16M019745 for ; Sat, 10 Jan 2009 06:19:01 -0600 X-ASG-Debug-ID: 1231589940-1c8003370000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from an-out-0708.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0076378738; Sat, 10 Jan 2009 04:19:00 -0800 (PST) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.242]) by cuda.sgi.com with ESMTP id 6QKQgHlxWsyAYN2C; Sat, 10 Jan 2009 04:19:00 -0800 (PST) Received: by an-out-0708.google.com with SMTP id c37so4053730anc.32 for ; Sat, 10 Jan 2009 04:19:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=CBKdAvLvF3le/UEQGURnuc681C4Z/72G27uzl8oVeFw=; b=lb9rhOUNmGCP0Bv6RLOrBtO0jYxwW8eyKXUW6n/ohaBRX9zikPFMcBT46SQpiTeYDL gb5JvSkoLuwYcrZaV3mcaoj596spo8AgzgDy9mAMJQMHdy0xX5TIkOofjEnXB/DKPN/H LpQg+n/pvF0/fnjLyZo0nYEmg0MM90rhP2+08= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=jyWVeCHI7YWf5Sd/5NxX0gxYJMdNH7pi89h/Tbn7snRMXLqXFTrPCDNN4cv6xK2ySJ PM/+4L/o0z4K0PmrImL+AFVCr4pJFQuO4J6Ymsg9lCqGxnbd/6Bt0N/8e7+0DoggqCpL ygSxI+Gv3IoybquGvvfJR6lurYcur3rSy/hbQ= Received: by 10.100.3.13 with SMTP id 13mr14285294anc.26.1231589940093; Sat, 10 Jan 2009 04:19:00 -0800 (PST) Received: by 10.100.3.15 with HTTP; Sat, 10 Jan 2009 04:19:00 -0800 (PST) Message-ID: Date: Sat, 10 Jan 2009 15:19:00 +0300 From: "Alexander Beregalov" To: "Dave Chinner" , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> X-Barracuda-Connect: an-out-0708.google.com[209.85.132.242] X-Barracuda-Start-Time: 1231589941 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14857 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8849/Fri Jan 9 22:18:40 2009 on oss.sgi.com X-Virus-Status: Clean 2009/1/10 Alexander Beregalov : > 2009/1/10 Alexander Beregalov : >> 2009/1/10 Alexander Beregalov : >>> 2009/1/9 Dave Chinner : >>>> On Fri, Jan 09, 2009 at 07:41:21AM +0300, Alexander Beregalov wrote: >>>> Looks like the same btree corruption problem as this: >>>> >>>> http://oss.sgi.com/archives/xfs/2009-01/msg00118.html >>>> >>>> We're working to find the cause right now, but I find it interesting >>>> that you are running a CONFIG_XFS_DEBUG=y kernel and the first >>>> point that something is found wrong is the same place that the >>>> above non-debug case is detecting corruption. >>>> >>>> Can you reproduce it/have a reproducable test case? >>> Yes, it is easy reproducible for me, it happens every time I run >>> `rtorrent` during few minutes after boot. >>> I will try to provide simpler testcase. It is hard to bisect it, These are last good and bad commits: good: [854929f05831d3a290a802815ee955b96c740c61] [XFS] add new btree statistics bad: [7f7c39ccb6045cf1fd5e7684a484c445291b44d4] [XFS] make btree tracing generic From SRS0+f6cdad15be370b6168ab+1966+infradead.org+hch@bombadil.srs.infradead.org Sat Jan 10 08:39:30 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0AEdQUt029071 for ; Sat, 10 Jan 2009 08:39:30 -0600 X-ASG-Debug-ID: 1231598366-042c03ab0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7771578980; Sat, 10 Jan 2009 06:39:26 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id fgkDgfZj8Zk4qpoy; Sat, 10 Jan 2009 06:39:26 -0800 (PST) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1LLezk-0007HX-Qt; Sat, 10 Jan 2009 14:39:24 +0000 Date: Sat, 10 Jan 2009 09:39:24 -0500 From: Christoph Hellwig To: Alexander Beregalov Cc: Dave Chinner , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090110143924.GA25900@infradead.org> References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1231598366 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV 0.91.2/8849/Fri Jan 9 22:18:40 2009 on oss.sgi.com X-Virus-Status: Clean On Sat, Jan 10, 2009 at 03:19:00PM +0300, Alexander Beregalov wrote: > It is hard to bisect it, > These are last good and bad commits: > good: [854929f05831d3a290a802815ee955b96c740c61] [XFS] add new btree statistics > bad: [7f7c39ccb6045cf1fd5e7684a484c445291b44d4] [XFS] make btree tracing generic That would be odd as 7f7c39ccb6045cf1fd5e7684a484c445291b44d4 only changes the tracing code which currently isn't enabled. Or we get some sort of miscompilation due slightly different noop macros. How big is the filesystem where you see this corruption? Maybe I could reproduce it locally with a xfs_metadump image. > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs ---end quoted text--- From a.beregalov@gmail.com Sat Jan 10 09:09:07 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0AF97vr030746 for ; Sat, 10 Jan 2009 09:09:07 -0600 X-ASG-Debug-ID: 1231600145-4fe201880000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from yw-out-1718.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id EE4551BA2605; Sat, 10 Jan 2009 07:09:06 -0800 (PST) Received: from yw-out-1718.google.com (yw-out-1718.google.com [74.125.46.153]) by cuda.sgi.com with ESMTP id wkhLCGiTI0PLnHQH; Sat, 10 Jan 2009 07:09:06 -0800 (PST) Received: by yw-out-1718.google.com with SMTP id 5so4074377ywm.32 for ; Sat, 10 Jan 2009 07:09:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=UFeQuA6YaNfi22iRnva7wcUemHsI94jU+sJkI6khmxc=; b=bv1/9pEoNXHDVxqQI49xBNyAK8mcoitu48WAkrWZTLzGLdfYVVmoYCJAZ4f+ONhFyH c1TKWg/LkR0tbmQ5RqZ1qg5EQ/Bne4Ejv3KZ+9EFD+pjO7yA53pPpQaSP/vRc4U9wRgs T8RsZ4jKHDnmApHTSFigzE+NqRU2eTZ+McZD4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=kbg7sNkpGWzq5z/xclOodWe8g42V53uNf1Yjt4f7fGpMEokP4Y64411R2SuqiUFwFW yFl+U6Ql9JgGp44mopnVug5GuLlpJihLuWIsiTa/PNaidq40dXzyk/RcU5AcqnlmO0PL 0s5vJ9GnPSZKkEcwxdJQClmKgvcJlFx5f3G5k= Received: by 10.100.125.9 with SMTP id x9mr6290116anc.139.1231600145584; Sat, 10 Jan 2009 07:09:05 -0800 (PST) Received: by 10.100.3.15 with HTTP; Sat, 10 Jan 2009 07:09:05 -0800 (PST) Message-ID: Date: Sat, 10 Jan 2009 18:09:05 +0300 From: "Alexander Beregalov" To: "Christoph Hellwig" X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Cc: "Dave Chinner" , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org In-Reply-To: <20090110143924.GA25900@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> <20090110143924.GA25900@infradead.org> X-Barracuda-Connect: yw-out-1718.google.com[74.125.46.153] X-Barracuda-Start-Time: 1231600146 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE_7582B X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14868 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE_7582B Custom Rule 7582B X-Virus-Scanned: ClamAV 0.91.2/8849/Fri Jan 9 22:18:40 2009 on oss.sgi.com X-Virus-Status: Clean 2009/1/10 Christoph Hellwig : > On Sat, Jan 10, 2009 at 03:19:00PM +0300, Alexander Beregalov wrote: >> It is hard to bisect it, >> These are last good and bad commits: >> good: [854929f05831d3a290a802815ee955b96c740c61] [XFS] add new btree statistics >> bad: [7f7c39ccb6045cf1fd5e7684a484c445291b44d4] [XFS] make btree tracing generic > > That would be odd as 7f7c39ccb6045cf1fd5e7684a484c445291b44d4 only > changes the tracing code which currently isn't enabled. Or we > get some sort of miscompilation due slightly different noop > macros. I meant the first bad commit is between these two commits. All of them fail to compile as is, I added xfs_btree_trace.h manually to compile it, I got different bugs on these commits, but I am not sure if they are really different. Like this: Filesystem "sdb1": XFS internal error xfs_btree_check_lblock at line 84 of file fs/xfs/xfs_btree.c. Caller 0xc0247322 Pid: 247, comm: pdflush Not tainted 2.6.28-rc2-00219-g3cc7524 #3 Call Trace: [] ? xfs_cmn_err+0x32/0x60 [] xfs_error_report+0x4e/0x50 [] ? xfs_btree_check_block+0x32/0x40 [] xfs_btree_check_lblock+0x4d/0x190 [] ? xfs_btree_check_block+0x32/0x40 [] ? xfs_trans_read_buf+0x46d/0x530 [] xfs_btree_check_block+0x32/0x40 [] xfs_btree_read_buf_block+0xe4/0x100 [] xfs_btree_rshift+0xcf/0x540 [] ? xfs_error_test+0x1b/0xc0 [] ? xfs_error_test+0x1b/0xc0 [] xfs_btree_make_block_unfull+0x32/0x140 [] ? xfs_bmbt_recs_inorder+0x32/0x70 [] xfs_btree_insrec+0x63e/0x6c0 [] xfs_btree_insert+0x69/0x190 [] xfs_bmap_add_extent_delay_real+0x142d/0x1700 [] ? slab_pad_check+0x3c/0x120 [] ? xfs_alloc_vextent+0x2e9/0x760 [] ? check_object+0x13d/0x200 [] xfs_bmap_add_extent+0x626/0x670 [] ? xfs_bmbt_init_cursor+0x2c/0x100 [] xfs_bmapi+0xfcb/0x1c90 [] ? __lock_acquire+0x2c5/0x1000 [] ? __lock_acquire+0x2c5/0x1000 [] ? __lock_acquire+0x2c5/0x1000 [] xfs_iomap_write_allocate+0x254/0x450 [] ? xfs_log_move_tail+0x190/0x1d0 [] ? xfs_log_move_tail+0x190/0x1d0 [] xfs_iomap+0x3a7/0x3f0 [] ? trace_hardirqs_on_caller+0x7c/0x160 [] xfs_map_blocks+0x3e/0x90 [] xfs_page_state_convert+0x2ea/0x740 [] ? _local_bh_enable+0x52/0xa0 Anyway, If they are different, I can not catch the bug at xfs_btree_delrec() beacuse the bug xfs_btree.c:84 happens earlierly. > > How big is the filesystem where you see this corruption? Maybe I could > reproduce it locally with a xfs_metadump image. They are big enough, I have four such FS's for >200Gb From SRS0+f6cdad15be370b6168ab+1966+infradead.org+hch@bombadil.srs.infradead.org Sat Jan 10 09:29:06 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0AFT5pI031882 for ; Sat, 10 Jan 2009 09:29:06 -0600 X-ASG-Debug-ID: 1231601345-590801e80000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 91A0878BF1; Sat, 10 Jan 2009 07:29:05 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id Gx7WFYE2rHyvHDsJ; Sat, 10 Jan 2009 07:29:05 -0800 (PST) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1LLfkp-0000TD-Fj; Sat, 10 Jan 2009 15:28:03 +0000 Date: Sat, 10 Jan 2009 10:28:03 -0500 From: Christoph Hellwig To: Alexander Beregalov Cc: Christoph Hellwig , Dave Chinner , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090110152803.GA7469@infradead.org> References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> <20090110143924.GA25900@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1231601345 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV 0.91.2/8849/Fri Jan 9 22:18:40 2009 on oss.sgi.com X-Virus-Status: Clean On Sat, Jan 10, 2009 at 06:09:05PM +0300, Alexander Beregalov wrote: > > That would be odd as 7f7c39ccb6045cf1fd5e7684a484c445291b44d4 only > > changes the tracing code which currently isn't enabled. Or we > > get some sort of miscompilation due slightly different noop > > macros. > I meant the first bad commit is between these two commits. All of them > fail to compile as is, > I added xfs_btree_trace.h manually to compile it, I got different bugs > on these commits, > but I am not sure if they are really different. Like this: Ah crap. When lachlan checked in the btree tracing he forgot to add that header and it only got in after that. Can you bisect further between those commit by just using xfs_btree_trce.h from a newer version? It hasn't had a single change yet since it was commited. This is quite important as all changes between these two revisions are quite large and deal with consolidating the btree code. From sandeen@sandeen.net Sat Jan 10 10:27:39 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0AGRZWZ003097 for ; Sat, 10 Jan 2009 10:27:35 -0600 X-ASG-Debug-ID: 1231604853-512d03b30000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.sandeen.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 3C9E51BA29C4; Sat, 10 Jan 2009 08:27:33 -0800 (PST) Received: from mail.sandeen.net (sandeen.net [209.173.210.139]) by cuda.sgi.com with ESMTP id ONlrfFuCevZIifEF; Sat, 10 Jan 2009 08:27:33 -0800 (PST) Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sandeen.net (Postfix) with ESMTP id B4117A9FEA3; Sat, 10 Jan 2009 10:27:31 -0600 (CST) Message-ID: <4968CC73.4070700@sandeen.net> Date: Sat, 10 Jan 2009 10:27:31 -0600 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: Alexander Beregalov CC: Christoph Hellwig , xfs-masters@oss.sgi.com, kernel-testers@vger.kernel.org, xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> <20090110143924.GA25900@infradead.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: sandeen.net[209.173.210.139] X-Barracuda-Start-Time: 1231604854 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14873 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8849/Fri Jan 9 22:18:40 2009 on oss.sgi.com X-Virus-Status: Clean Alexander Beregalov wrote: > 2009/1/10 Christoph Hellwig : >> How big is the filesystem where you see this corruption? Maybe I could >> reproduce it locally with a xfs_metadump image. > > They are big enough, I have four such FS's for >200Gb An xfs_metadump should not be so large, though. But bisecting as hch suggested (keepin the "working" header for each bisection point) would be great. -Eric From akpm@linux-foundation.org Sat Jan 10 16:17:02 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0AMGxiZ009389 for ; Sat, 10 Jan 2009 16:17:01 -0600 X-ASG-Debug-ID: 1231625816-57ab03050000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 21657792F9 for ; Sat, 10 Jan 2009 14:16:56 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id L8WqEVyQfNEy5UXB for ; Sat, 10 Jan 2009 14:16:56 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0A0f1BO013726 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 9 Jan 2009 16:41:02 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0A0f06e013797; Fri, 9 Jan 2009 16:41:00 -0800 Message-Id: <200901100041.n0A0f06e013797@imap1.linux-foundation.org> X-ASG-Orig-Subj: [patch 7/8] filesystem freeze: remove XFS specific ioctl interfaces for freeze feature Subject: [patch 7/8] filesystem freeze: remove XFS specific ioctl interfaces for freeze feature To: torvalds@linux-foundation.org Cc: akpm@linux-foundation.org, t-sato@yk.jp.nec.com, agk@redhat.com, david@fromorbit.com, dgc@sgi.com, hch@lst.de, linux-ext4@vger.kernel.org, shaggy@austin.ibm.com, viro@zeniv.linux.org.uk, xfs-masters@oss.sgi.com From: akpm@linux-foundation.org Date: Fri, 09 Jan 2009 16:41:00 -0800 X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231625819 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14890 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on oss.sgi.com X-Virus-Status: Clean From: Takashi Sato It removes XFS specific ioctl interfaces and request codes for freeze feature. This patch has been supplied by David Chinner. Signed-off-by: Dave Chinner Signed-off-by: Takashi Sato Cc: Dave Chinner Cc: Cc: Cc: Christoph Hellwig Cc: Dave Kleikamp Cc: Alasdair G Kergon Cc: Al Viro Signed-off-by: Andrew Morton --- fs/xfs/linux-2.6/xfs_ioctl.c | 15 --------------- fs/xfs/linux-2.6/xfs_ioctl32.c | 2 -- fs/xfs/xfs_fs.h | 4 ++-- 3 files changed, 2 insertions(+), 19 deletions(-) diff -puN fs/xfs/linux-2.6/xfs_ioctl.c~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature fs/xfs/linux-2.6/xfs_ioctl.c --- a/fs/xfs/linux-2.6/xfs_ioctl.c~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature +++ a/fs/xfs/linux-2.6/xfs_ioctl.c @@ -1546,21 +1546,6 @@ xfs_file_ioctl( return -error; } - case XFS_IOC_FREEZE: - if (!capable(CAP_SYS_ADMIN)) - return -EPERM; - - if (inode->i_sb->s_frozen == SB_UNFROZEN) - freeze_bdev(inode->i_sb->s_bdev); - return 0; - - case XFS_IOC_THAW: - if (!capable(CAP_SYS_ADMIN)) - return -EPERM; - if (inode->i_sb->s_frozen != SB_UNFROZEN) - thaw_bdev(inode->i_sb->s_bdev, inode->i_sb); - return 0; - case XFS_IOC_GOINGDOWN: { __uint32_t in; diff -puN fs/xfs/linux-2.6/xfs_ioctl32.c~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature fs/xfs/linux-2.6/xfs_ioctl32.c --- a/fs/xfs/linux-2.6/xfs_ioctl32.c~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature +++ a/fs/xfs/linux-2.6/xfs_ioctl32.c @@ -632,8 +632,6 @@ xfs_file_compat_ioctl( case XFS_IOC_SET_RESBLKS: case XFS_IOC_GET_RESBLKS: case XFS_IOC_FSGROWFSLOG: - case XFS_IOC_FREEZE: - case XFS_IOC_THAW: case XFS_IOC_GOINGDOWN: case XFS_IOC_ERROR_INJECTION: case XFS_IOC_ERROR_CLEARALL: diff -puN fs/xfs/xfs_fs.h~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature fs/xfs/xfs_fs.h --- a/fs/xfs/xfs_fs.h~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature +++ a/fs/xfs/xfs_fs.h @@ -465,8 +465,8 @@ typedef struct xfs_handle { #define XFS_IOC_ERROR_INJECTION _IOW ('X', 116, struct xfs_error_injection) #define XFS_IOC_ERROR_CLEARALL _IOW ('X', 117, struct xfs_error_injection) /* XFS_IOC_ATTRCTL_BY_HANDLE -- deprecated 118 */ -#define XFS_IOC_FREEZE _IOWR('X', 119, int) -#define XFS_IOC_THAW _IOWR('X', 120, int) +/* XFS_IOC_FREEZE -- FIFREEZE 119 */ +/* XFS_IOC_THAW -- FITHAW 120 */ #define XFS_IOC_FSSETDM_BY_HANDLE _IOW ('X', 121, struct xfs_fsop_setdm_handlereq) #define XFS_IOC_ATTRLIST_BY_HANDLE _IOW ('X', 122, struct xfs_fsop_attrlist_handlereq) #define XFS_IOC_ATTRMULTI_BY_HANDLE _IOW ('X', 123, struct xfs_fsop_attrmulti_handlereq) _ From bugme-daemon@bugzilla.kernel.org Sat Jan 10 16:18:12 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0AMICQ7009494 for ; Sat, 10 Jan 2009 16:18:12 -0600 X-ASG-Debug-ID: 1231625891-749d01880000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id F03B179310 for ; Sat, 10 Jan 2009 14:18:11 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id AyKVi0jDBKOg9P7S for ; Sat, 10 Jan 2009 14:18:11 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0ALwmPr014006 for ; Sat, 10 Jan 2009 13:58:49 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 7500F108041; Sat, 10 Jan 2009 13:58:48 -0800 (PST) X-ASG-Orig-Subj: [Bug 12402] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: [Bug 12402] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090110215848.7500F108041@picon.linux-foundation.org> Date: Sat, 10 Jan 2009 13:58:48 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231625891 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14890 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12402 rjw@sisk.pl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.beregalov@gmail.com -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 10 16:18:15 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0AMIFYM009505 for ; Sat, 10 Jan 2009 16:18:15 -0600 X-ASG-Debug-ID: 1231625891-749d01880002-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 915237930D for ; Sat, 10 Jan 2009 14:18:12 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id FX9g7VUrsBCQMZJr for ; Sat, 10 Jan 2009 14:18:12 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0ALwb1b013888 for ; Sat, 10 Jan 2009 13:58:38 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 3843B108041; Sat, 10 Jan 2009 13:58:37 -0800 (PST) X-ASG-Orig-Subj: [Bug 12402] New: 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: [Bug 12402] New: 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: Message-Id: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Date: Sat, 10 Jan 2009 13:58:37 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231625892 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14890 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12402 Summary: 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Product: File System Version: 2.5 KernelVersion: 2.6.29-rc Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: XFS AssignedTo: xfs-masters@oss.sgi.com ReportedBy: rjw@sisk.pl OtherBugsDependingO 12398 nThis: Regression: 1 Subject : 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Submitter : Alexander Beregalov Date : kernel-testers@vger.kernel.org References : http://thread.gmane.org/gmane.comp.file-systems.xfs.general/27548 Handled-By : Christoph Hellwig Notify-Also : Eric Sandeen This entry is being used for tracking a regression from 2.6.28. Please don't close it until the problem is fixed in the mainline. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From a.beregalov@gmail.com Sat Jan 10 16:22:57 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,J_CHICKENPOX_23 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0AMMvJo009879 for ; Sat, 10 Jan 2009 16:22:57 -0600 X-ASG-Debug-ID: 1231626175-5fb502d00000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from fg-out-1718.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 55B4276D9C for ; Sat, 10 Jan 2009 14:22:55 -0800 (PST) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.159]) by cuda.sgi.com with ESMTP id NYnAoQY1s0rh9SG6 for ; Sat, 10 Jan 2009 14:22:55 -0800 (PST) Received: by fg-out-1718.google.com with SMTP id 19so1478270fgg.8 for ; Sat, 10 Jan 2009 14:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=/WgC2Ch9IXIZXbAcj7NrYEMOIQGvja4AnSISRI5bzpk=; b=HOxM4s25oCPcD1CjZLq9LMuIzROOasgDzz5NdVfnBoyRvZtHta4RGu8g85wfBn1TFq +XOIPiQzhF49X9cHaLsTeGY92jtQ9y7d7NXxVFYvuAQNodPzuamNUX0tXg40lTY0+UVs dANsXadVKCL3iLooci4eDyaan1qhioDgjoInw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=sD0N5fb+O69cnk/vT+sv6OzDKpX/SND/8tTPnlBs06FrsD6hlZkDufZxTUIDi5W3Qw PkNqvh4IpgAaXHRtHtVoNqMpfrea5NH2Aso5feT/sefWStEuMYJbXXJo9UrGUshnRlO6 Jp/DXzvuOi8E+KUd8fOUYTqjCyWNFo3uzn25s= Received: by 10.86.79.19 with SMTP id c19mr15711859fgb.26.1231625704387; Sat, 10 Jan 2009 14:15:04 -0800 (PST) Received: from @ ([91.78.16.173]) by mx.google.com with ESMTPS id e20sm7238707fga.33.2009.01.10.14.15.02 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 10 Jan 2009 14:15:03 -0800 (PST) Date: Sun, 11 Jan 2009 01:14:59 +0300 From: Alexander Beregalov To: Christoph Hellwig Cc: Dave Chinner , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090110221459.GA8873@orion> References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090110152803.GA7469@infradead.org> User-Agent: Mutt/1.5.16 (2007-06-09) X-Barracuda-Connect: fg-out-1718.google.com[72.14.220.159] X-Barracuda-Start-Time: 1231626176 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14891 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on oss.sgi.com X-Virus-Status: Clean On Sat, Jan 10, 2009 at 10:28:03AM -0500, Christoph Hellwig wrote: > On Sat, Jan 10, 2009 at 06:09:05PM +0300, Alexander Beregalov wrote: > > > That would be odd as 7f7c39ccb6045cf1fd5e7684a484c445291b44d4 only > > > changes the tracing code which currently isn't enabled. Or we > > > get some sort of miscompilation due slightly different noop > > > macros. > > I meant the first bad commit is between these two commits. All of them > > fail to compile as is, > > I added xfs_btree_trace.h manually to compile it, I got different bugs > > on these commits, > > but I am not sure if they are really different. Like this: > > Ah crap. When lachlan checked in the btree tracing he forgot to > add that header and it only got in after that. Can you bisect > further between those commit by just using xfs_btree_trce.h from > a newer version? It hasn't had a single change yet since it was > commited. > > This is quite important as all changes between these two revisions > are quite large and deal with consolidating the btree code. > I can not reproduce it now, I get the following message instead: I will try to repair the filesystem. Filesystem "sdb1": XFS internal error xfs_btree_check_lblock at line 86 of file fs/xfs/xfs_btree.c. Caller 0xc024af42 Pid: 251, comm: pdflush Not tainted 2.6.28-09244-g3d14bda #4 Call Trace: [] ? xfs_cmn_err+0x32/0x60 [] xfs_error_report+0x4e/0x50 [] ? xfs_btree_check_block+0x32/0x40 [] xfs_btree_check_lblock+0x4d/0x190 [] ? xfs_btree_check_block+0x32/0x40 [] ? xfs_trans_read_buf+0x470/0x530 [] xfs_btree_check_block+0x32/0x40 [] xfs_btree_read_buf_block+0xe4/0x100 [] xfs_btree_lshift+0xbd/0x580 [] ? xfs_error_test+0x1b/0xc0 [] xfs_btree_make_block_unfull+0x5b/0x140 [] ? xfs_bmbt_recs_inorder+0x32/0x70 [] xfs_btree_insrec+0x63e/0x6c0 [] xfs_btree_insert+0x69/0x190 [] xfs_bmap_add_extent_delay_real+0x141b/0x16f0 [] ? slab_pad_check+0x3c/0x120 [] ? xfs_alloc_vextent+0x2d4/0x730 [] ? check_object+0x13d/0x200 [] xfs_bmap_add_extent+0x626/0x670 [] ? xfs_bmbt_init_cursor+0x2c/0x100 [] xfs_bmapi+0xfc8/0x1c80 [] ? __lock_acquire+0x2b6/0x1190 [] ? __lock_acquire+0x2b6/0x1190 [] xfs_iomap_write_allocate+0x254/0x450 [] ? xfs_log_move_tail+0x190/0x1d0 [] xfs_iomap+0x3a7/0x3f0 [] ? __lock_acquire+0x2b6/0x1190 [] xfs_page_state_convert+0x3fd/0x790 [] ? mark_held_locks+0x4c/0x90 [] xfs_vm_writepage+0x5a/0xf0 [] __writepage+0xb/0x40 [] write_cache_pages+0x19b/0x350 [] ? __writepage+0x0/0x40 [] generic_writepages+0x23/0x30 [] xfs_vm_writepages+0x41/0x50 [] ? xfs_vm_writepages+0x0/0x50 [] do_writepages+0x2e/0x50 [] __writeback_single_inode+0x82/0x340 [] ? generic_sync_sb_inodes+0x26/0x390 [] ? _spin_lock+0x66/0x70 [] generic_sync_sb_inodes+0x2f2/0x390 [] writeback_inodes+0x56/0xe0 [] wb_kupdate+0x7b/0xf0 [] ? pdflush+0x0/0x190 [] pdflush+0xd0/0x190 [] ? wb_kupdate+0x0/0xf0 [] kthread+0x3a/0x70 [] ? kthread+0x0/0x70 [] kernel_thread_helper+0x7/0x14 Filesystem "sdb1": XFS internal error xfs_trans_cancel at line 1164 of file fs/xfs/xfs_trans.c. Caller 0xc0270c1c Pid: 251, comm: pdflush Not tainted 2.6.28-09244-g3d14bda #4 Call Trace: [] ? xfs_cmn_err+0x32/0x60 [] xfs_error_report+0x4e/0x50 [] ? xfs_iomap_write_allocate+0x34c/0x450 [] xfs_trans_cancel+0x106/0x1e0 [] ? xfs_iomap_write_allocate+0x34c/0x450 [] xfs_iomap_write_allocate+0x34c/0x450 [] ? xfs_log_move_tail+0x190/0x1d0 [] xfs_iomap+0x3a7/0x3f0 [] ? __lock_acquire+0x2b6/0x1190 [] xfs_page_state_convert+0x3fd/0x790 [] ? mark_held_locks+0x4c/0x90 [] xfs_vm_writepage+0x5a/0xf0 [] __writepage+0xb/0x40 [] write_cache_pages+0x19b/0x350 [] ? __writepage+0x0/0x40 [] generic_writepages+0x23/0x30 [] xfs_vm_writepages+0x41/0x50 [] ? xfs_vm_writepages+0x0/0x50 [] do_writepages+0x2e/0x50 [] __writeback_single_inode+0x82/0x340 [] ? generic_sync_sb_inodes+0x26/0x390 [] ? _spin_lock+0x66/0x70 [] generic_sync_sb_inodes+0x2f2/0x390 [] writeback_inodes+0x56/0xe0 [] wb_kupdate+0x7b/0xf0 [] ? pdflush+0x0/0x190 [] pdflush+0xd0/0x190 [] ? wb_kupdate+0x0/0xf0 [] kthread+0x3a/0x70 [] ? kthread+0x0/0x70 [] kernel_thread_helper+0x7/0x14 xfs_force_shutdown(sdb1,0x8) called from line 1165 of file fs/xfs/xfs_trans.c. Return address = 0xc02843ff XFS: Transforming an alert into a BUG. Filesystem "sdb1": Corruption of in-memory data detected. Shutting down filesystem: sdb1 ------------[ cut here ]------------ kernel BUG at fs/xfs/support/debug.c:101! invalid opcode: 0000 [#1] PREEMPT DEBUG_PAGEALLOC last sysfs file: /sys/devices/platform/w83627hf.656/name Modules linked in: w83627hf hwmon_vid i2c_nforce2 Pid: 251, comm: pdflush Not tainted (2.6.28-09244-g3d14bda #4) EIP: 0060:[] EFLAGS: 00010246 CPU: 0 EIP is at xfs_fs_vcmn_err+0xc9/0xd0 EAX: f6b06000 EBX: f73e3aa0 ECX: 10000000 EDX: 10000000 ESI: 00000000 EDI: c04b9fc8 EBP: f6b07b74 ESP: f6b07b58 DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068 Process pdflush (pid: 251, ti=f6b06000 task=f6b0bd50 task.ti=f6b06000) Stack: c04c2605 c0488fe5 c0aeafc0 00000292 00000008 00000000 f73e3aa0 f6b07b84 c0261462 f6b07b9c c04b4c58 f6b07bb8 c028e2c2 00000010 00000000 f73e3aa0 c04b9fc8 f7345cb0 c049d105 c02843ff 00000000 00000008 f6b07c70 00000001 Call Trace: [] ? xfs_cmn_err+0x32/0x60 [] ? xfs_do_force_shutdown+0x152/0x1e0 [] ? xfs_trans_cancel+0x11f/0x1e0 [] ? xfs_trans_cancel+0x11f/0x1e0 [] ? xfs_iomap_write_allocate+0x34c/0x450 [] ? xfs_iomap_write_allocate+0x34c/0x450 [] ? xfs_log_move_tail+0x190/0x1d0 [] ? xfs_iomap+0x3a7/0x3f0 [] ? __lock_acquire+0x2b6/0x1190 [] ? xfs_page_state_convert+0x3fd/0x790 [] ? mark_held_locks+0x4c/0x90 [] ? xfs_vm_writepage+0x5a/0xf0 [] ? __writepage+0xb/0x40 [] ? write_cache_pages+0x19b/0x350 [] ? __writepage+0x0/0x40 [] ? generic_writepages+0x23/0x30 [] ? xfs_vm_writepages+0x41/0x50 [] ? xfs_vm_writepages+0x0/0x50 [] ? do_writepages+0x2e/0x50 [] ? __writeback_single_inode+0x82/0x340 [] ? generic_sync_sb_inodes+0x26/0x390 [] ? _spin_lock+0x66/0x70 [] ? generic_sync_sb_inodes+0x2f2/0x390 [] ? writeback_inodes+0x56/0xe0 [] ? wb_kupdate+0x7b/0xf0 [] ? pdflush+0x0/0x190 [] ? pdflush+0xd0/0x190 [] ? wb_kupdate+0x0/0xf0 [] ? kthread+0x3a/0x70 [] ? kthread+0x0/0x70 [] ? kernel_thread_helper+0x7/0x14 Code: e8 06 43 17 00 8b 55 f0 b8 20 b0 51 c0 e8 f0 75 17 00 85 f6 74 15 83 c4 10 5b 5e 5f c9 c3 8d 74 26 00 c6 81 c0 af ae c0 00 eb bb <0f> 0b eb fe 8d 76 00 55 b8 20 b0 51 c0 89 e5 57 56 53 83 ec 0c EIP: [] xfs_fs_vcmn_err+0xc9/0xd0 SS:ESP 0068:f6b07b58 e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang Tx Queue <0> TDH <3f> TDT <3f> next_to_use <3f> next_to_clean buffer_info[next_to_clean] time_stamp next_to_watch jiffies next_to_watch.status <1> ---[ end trace 81071308b66cb6c7 ]--- From david@fromorbit.com Sun Jan 11 04:47:10 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0BAl9NW013974 for ; Sun, 11 Jan 2009 04:47:09 -0600 X-ASG-Debug-ID: 1231670826-208500290000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1FA5B7A44C; Sun, 11 Jan 2009 02:47:07 -0800 (PST) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id biIMBe7EMLFJZG90; Sun, 11 Jan 2009 02:47:07 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAPJcaUl5LDnl/2dsb2JhbADQO4Vv X-IronPort-AV: E=Sophos;i="4.37,248,1231075800"; d="scan'208";a="291013240" Received: from ppp121-44-57-229.lns10.syd7.internode.on.net (HELO disturbed) ([121.44.57.229]) by ipmail05.adl2.internode.on.net with ESMTP; 11 Jan 2009 21:17:01 +1030 Received: from dave by disturbed with local (Exim 4.69) (envelope-from ) id 1LLxqN-0004Nl-LO; Sun, 11 Jan 2009 21:46:59 +1100 Date: Sun, 11 Jan 2009 21:46:59 +1100 From: Dave Chinner To: Alexander Beregalov Cc: Christoph Hellwig , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090111104659.GB8071@disturbed> Mail-Followup-To: Alexander Beregalov , Christoph Hellwig , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org References: <20090109044121.GA31280@orion> <20090109053858.GP9448@disturbed> <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090110221459.GA8873@orion> User-Agent: Mutt/1.5.18 (2008-05-17) X-Barracuda-Connect: ipmail05.adl2.internode.on.net[203.16.214.145] X-Barracuda-Start-Time: 1231670829 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14931 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8850/Sat Jan 10 17:20:01 2009 on oss.sgi.com X-Virus-Status: Clean On Sun, Jan 11, 2009 at 01:14:59AM +0300, Alexander Beregalov wrote: > On Sat, Jan 10, 2009 at 10:28:03AM -0500, Christoph Hellwig wrote: > > On Sat, Jan 10, 2009 at 06:09:05PM +0300, Alexander Beregalov wrote: > > > > That would be odd as 7f7c39ccb6045cf1fd5e7684a484c445291b44d4 only > > > > changes the tracing code which currently isn't enabled. Or we > > > > get some sort of miscompilation due slightly different noop > > > > macros. > > > I meant the first bad commit is between these two commits. All of them > > > fail to compile as is, > > > I added xfs_btree_trace.h manually to compile it, I got different bugs > > > on these commits, > > > but I am not sure if they are really different. Like this: > > > > Ah crap. When lachlan checked in the btree tracing he forgot to > > add that header and it only got in after that. Can you bisect > > further between those commit by just using xfs_btree_trce.h from > > a newer version? It hasn't had a single change yet since it was > > commited. > > > > This is quite important as all changes between these two revisions > > are quite large and deal with consolidating the btree code. > > > > I can not reproduce it now, I get the following message instead: > I will try to repair the filesystem. > > Filesystem "sdb1": XFS internal error xfs_btree_check_lblock at line 86 of file fs/xfs/xfs_btree.c. Caller 0xc024af42 > > Pid: 251, comm: pdflush Not tainted 2.6.28-09244-g3d14bda #4 > Call Trace: > [] ? xfs_cmn_err+0x32/0x60 > [] xfs_error_report+0x4e/0x50 > [] ? xfs_btree_check_block+0x32/0x40 > [] xfs_btree_check_lblock+0x4d/0x190 > [] ? xfs_btree_check_block+0x32/0x40 > [] ? xfs_trans_read_buf+0x470/0x530 > [] xfs_btree_check_block+0x32/0x40 > [] xfs_btree_read_buf_block+0xe4/0x100 > [] xfs_btree_lshift+0xbd/0x580 > [] ? xfs_error_test+0x1b/0xc0 > [] xfs_btree_make_block_unfull+0x5b/0x140 > [] ? xfs_bmbt_recs_inorder+0x32/0x70 > [] xfs_btree_insrec+0x63e/0x6c0 > [] xfs_btree_insert+0x69/0x190 Hmmmm - this might be getting closer to the source of the bug. It's being detecting when reading in the buffer to do a left shift now, not during the delete of a record. I'd suggest that you treat this as the same failure and continue the bisect to try to find when no problems show up at all. Cheers, Dave. -- Dave Chinner david@fromorbit.com From bugme-daemon@bugzilla.kernel.org Sun Jan 11 07:18:08 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0BDI83F023836 for ; Sun, 11 Jan 2009 07:18:08 -0600 X-ASG-Debug-ID: 1231679886-433b00b00000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 75D5A13D1829 for ; Sun, 11 Jan 2009 05:18:06 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id zXFDcfyJ5LICTrHI for ; Sun, 11 Jan 2009 05:18:06 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0BDHaps024829 for ; Sun, 11 Jan 2009 05:17:37 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id EF19A108040; Sun, 11 Jan 2009 05:17:35 -0800 (PST) X-ASG-Orig-Subj: [Bug 12402] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: [Bug 12402] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090111131735.EF19A108040@picon.linux-foundation.org> Date: Sun, 11 Jan 2009 05:17:35 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231679887 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14939 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8850/Sat Jan 10 17:20:01 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12402 ------- Comment #1 from rjw@sisk.pl 2009-01-11 05:17 ------- Date : 2009-01-09 04:41 -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Sun Jan 11 10:36:37 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED,BAYES_00, J_CHICKENPOX_63 autolearn=unavailable version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0BGab6o007180 for ; Sun, 11 Jan 2009 10:36:37 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n0BGabjD007179; Sun, 11 Jan 2009 10:36:37 -0600 Date: Sun, 11 Jan 2009 10:36:37 -0600 Message-Id: <200901111636.n0BGabjD007179@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 807] read-only mount attempts write on umount X-Bugzilla-Reason: AssignedTo X-Virus-Scanned: ClamAV 0.91.2/8851/Sun Jan 11 08:41:56 2009 on oss.sgi.com X-Virus-Status: Clean http://oss.sgi.com/bugzilla/show_bug.cgi?id=807 hch@xfs.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From hch@xfs.org 2009-01-11 10:36 CST ------- As mentioned before this doesn't happen anymore on current kernels, and we now have a xfsqa testcase (200) to test for this as part of automatic QA. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Sun Jan 11 10:37:33 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0BGbXLO007289 for ; Sun, 11 Jan 2009 10:37:33 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n0BGbXrn007288; Sun, 11 Jan 2009 10:37:33 -0600 Date: Sun, 11 Jan 2009 10:37:33 -0600 Message-Id: <200901111637.n0BGbXrn007288@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 428] xfs_freeze/thaw potential problem. X-Bugzilla-Reason: AssignedTo X-Virus-Scanned: ClamAV 0.91.2/8851/Sun Jan 11 08:41:56 2009 on oss.sgi.com X-Virus-Status: Clean http://oss.sgi.com/bugzilla/show_bug.cgi?id=428 hch@xfs.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From hch@xfs.org 2009-01-11 10:37 CST ------- Fixed by the new generic implementation of these ioctls: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fcccf502540e3d752d33b2d8e976034dee81f9f7 -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From a.beregalov@gmail.com Sun Jan 11 18:48:17 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0C0mFLP019431 for ; Sun, 11 Jan 2009 18:48:17 -0600 X-ASG-Debug-ID: 1231721293-3c8203880000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from yw-out-1718.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4657517D8105; Sun, 11 Jan 2009 16:48:13 -0800 (PST) Received: from yw-out-1718.google.com (yw-out-1718.google.com [74.125.46.153]) by cuda.sgi.com with ESMTP id qoFZKCTHYZGSLg7e; Sun, 11 Jan 2009 16:48:13 -0800 (PST) Received: by yw-out-1718.google.com with SMTP id 5so4239731ywm.32 for ; Sun, 11 Jan 2009 16:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=2dNfTEqdMcZqggnRdCn2EZILYdHyU0KVSvYkzD8WelM=; b=pcc/uwlInOEWwq5yAjvSD63Y80o7ODr1MiKVoP3k2Jsu7nSTWYDYSRwoAPbljunWq3 7NxPjij2iwgyGuuR7olgEzviqUNZGs24n5VqlQ+727z3XOurDxnKEK5AWBAJTZPJUfCU 23KpOnGLOVPA1jvMQWNj+xyBm434qqZWbvGsk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=jkiSPZad0921SWqSNYQR/8AZDB/kZwWE27y6Txt04Gmd6DOtdaXQYLvhGsIK80r14B /suk8B40Ti2gbLwKjYOVizYtlKJ/YsjkVbhTJEjsObe+vLnPLZCPI3uTdJJvMQVv7Ptz RKGkBmbS4BzGVpclnNc3z+Cc9rhZ6a3lX2fVc= Received: by 10.100.126.15 with SMTP id y15mr14899545anc.38.1231721293258; Sun, 11 Jan 2009 16:48:13 -0800 (PST) Received: by 10.100.3.15 with HTTP; Sun, 11 Jan 2009 16:48:13 -0800 (PST) Message-ID: Date: Mon, 12 Jan 2009 03:48:13 +0300 From: "Alexander Beregalov" To: "Dave Chinner" , "Christoph Hellwig" , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 In-Reply-To: <20090111104659.GB8071@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090109044121.GA31280@orion> <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> X-Barracuda-Connect: yw-out-1718.google.com[74.125.46.153] X-Barracuda-Start-Time: 1231721295 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14983 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8852/Sun Jan 11 13:31:01 2009 on oss.sgi.com X-Virus-Status: Clean > Hmmmm - this might be getting closer to the source of the bug. > It's being detecting when reading in the buffer to do a left shift > now, not during the delete of a record. > > I'd suggest that you treat this as the same failure and continue > the bisect to try to find when no problems show up at all. 687b890a184fef263ebb773926e1f4aa69240d01 is the first bad commit. Does it make sense? It can not be reverted from the current git to be sure it is guilty due to merge conflicts. From a.beregalov@gmail.com Sun Jan 11 20:25:55 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0C2Ppc7028508 for ; Sun, 11 Jan 2009 20:25:55 -0600 X-ASG-Debug-ID: 1231727150-685100980000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from yw-out-1718.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D1C9B1778B7F for ; Sun, 11 Jan 2009 18:25:50 -0800 (PST) Received: from yw-out-1718.google.com (yw-out-1718.google.com [74.125.46.156]) by cuda.sgi.com with ESMTP id 3BvDKchT1aNy6YwF for ; Sun, 11 Jan 2009 18:25:50 -0800 (PST) Received: by yw-out-1718.google.com with SMTP id 5so4248524ywm.32 for ; Sun, 11 Jan 2009 18:25:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=I929yQp2g6ZafTntfAxePZx54NYB6a5qOEfeAzWcNFQ=; b=LHOhnWnmJv7f9HzxtBLiMd7xdQiykoeFC97EBuZdd5oHgPh7ZS6ZBvAJmA6mZ3fgF6 R/JZ9+vVy7yKeJgnoBMI5ynLlt8sS6+F+O1tAZmLGxcx6+Red9/cBiB/QGlDOQuRqkm1 fzar8Kc0CTeNnzPPmAghYIXnodcU+BxcO7AlI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=kjudsbgabUtLMO0hE+tz9YZu4zy0O8x4Oh2CrRLPSMCuwTRvDIfPSIq2ayI7fCfS45 YrThPLgR9+baKchuYReo1+OX6vg9qFz9gLT0PemzlgkqBOpKxVxPXtWp7ML1vvgeEkqD akRZZu1YcIN/tK1V1AKMpx+3nPaezt4pNosmU= Received: by 10.100.32.6 with SMTP id f6mr14909483anf.87.1231726761807; Sun, 11 Jan 2009 18:19:21 -0800 (PST) Received: by 10.100.3.15 with HTTP; Sun, 11 Jan 2009 18:19:21 -0800 (PST) Message-ID: Date: Mon, 12 Jan 2009 05:19:21 +0300 From: "Alexander Beregalov" To: "Dave Chinner" , "Christoph Hellwig" , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090109044121.GA31280@orion> <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> X-Barracuda-Connect: yw-out-1718.google.com[74.125.46.156] X-Barracuda-Start-Time: 1231727150 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14990 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8853/Sun Jan 11 18:26:44 2009 on oss.sgi.com X-Virus-Status: Clean 2009/1/12 Alexander Beregalov : >> Hmmmm - this might be getting closer to the source of the bug. >> It's being detecting when reading in the buffer to do a left shift >> now, not during the delete of a record. >> >> I'd suggest that you treat this as the same failure and continue >> the bisect to try to find when no problems show up at all. > > 687b890a184fef263ebb773926e1f4aa69240d01 is the first bad commit. > Does it make sense? > It can not be reverted from the current git to be sure it is guilty > due to merge conflicts. > No! I got similar bug message on 9eaead5 two hours later. 9eaead5 is previous to 687b890. 9eaead5 might be the first bad commit or earlier one. It seems I need to test the kernel for few hours before mark it good. Filesystem "sdb1": XFS internal error xfs_btree_check_lblock at line 200 of file fs/xfs/xfs_btree.c. Caller 0xc024c132 Pid: 2481, comm: pdflush Not tainted 2.6.28-rc2-00208-g9eaead5 #4 Call Trace: [] ? xfs_cmn_err+0x32/0x60 [] xfs_error_report+0x4e/0x50 [] ? xfs_btree_check_block+0x32/0x40 [] xfs_btree_check_lblock+0x4d/0x190 [] ? xfs_btree_check_block+0x32/0x40 <...> Assertion failed: cur->bc_btnum != XFS_BTNUM_BMAP || cur->bc_private.b.allocated == 0, file: fs/xfs/xfs_btree.c, line: 348 ------------[ cut here ]------------ kernel BUG at fs/xfs/support/debug.c:81! invalid opcode: 0000 [#1] PREEMPT DEBUG_PAGEALLOC last sysfs file: /sys/devices/platform/w83627hf.656/name Modules linked in: w83627hf hwmon_vid i2c_nforce2 Pid: 2481, comm: pdflush Not tainted (2.6.28-rc2-00208-g9eaead5 #4) EIP: 0060:[] EFLAGS: 00010282 CPU: 0 EIP is at assfail+0x1e/0x30 <..> Call Trace: [] ? xfs_btree_del_cursor+0x60/0x80 [] ? xfs_bmapi+0x48e/0x1c90 [] ? __lock_acquire+0x2c5/0x1000 [] ? __lock_acquire+0x2c5/0x1000 [] ? xfs_iomap_write_allocate+0x254/0x450 From david@fromorbit.com Sun Jan 11 21:45:58 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0C3jwgU004219 for ; Sun, 11 Jan 2009 21:45:58 -0600 X-ASG-Debug-ID: 1231731953-684c02dc0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7449A17D825E; Sun, 11 Jan 2009 19:45:53 -0800 (PST) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id 4LMOIpGGIGejjaVb; Sun, 11 Jan 2009 19:45:53 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAANMakl5LDnl/2dsb2JhbADSGoVv X-IronPort-AV: E=Sophos;i="4.37,250,1231075800"; d="scan'208";a="291654556" Received: from ppp121-44-57-229.lns10.syd7.internode.on.net (HELO disturbed) ([121.44.57.229]) by ipmail05.adl2.internode.on.net with ESMTP; 12 Jan 2009 14:15:51 +1030 Received: from dave by disturbed with local (Exim 4.69) (envelope-from ) id 1LMDkM-00085c-Fk; Mon, 12 Jan 2009 14:45:50 +1100 Date: Mon, 12 Jan 2009 14:45:50 +1100 From: Dave Chinner To: Alexander Beregalov Cc: Christoph Hellwig , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090112034550.GI8071@disturbed> Mail-Followup-To: Alexander Beregalov , Christoph Hellwig , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org References: <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Barracuda-Connect: ipmail05.adl2.internode.on.net[203.16.214.145] X-Barracuda-Start-Time: 1231731957 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14993 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8853/Sun Jan 11 18:26:44 2009 on oss.sgi.com X-Virus-Status: Clean On Mon, Jan 12, 2009 at 03:48:13AM +0300, Alexander Beregalov wrote: > > Hmmmm - this might be getting closer to the source of the bug. > > It's being detecting when reading in the buffer to do a left shift > > now, not during the delete of a record. > > > > I'd suggest that you treat this as the same failure and continue > > the bisect to try to find when no problems show up at all. > > 687b890a184fef263ebb773926e1f4aa69240d01 is the first bad commit. [XFS] implement generic xfs_btree_lshift Make the btree left shift code generic. Based on a patch from David Chinner with lots of changes to follow the original btree implementations more closely. While this loses some of the generic helper routines for inserting/moving/removing records it also solves some of the one off bugs in the original code and makes it easier to verify. > Does it make sense? Yes, a bug in that patch could corrupt the btree in memory which we then trip over later in delrec before it has been written to disk. Thank you for isolating the problem to that commit - it greatly narrows down the amount of code we need to search to find the bug. I'll have a look tonight to see if I can spot the problem. Cheers, Dave. -- Dave Chinner david@fromorbit.com From a.beregalov@gmail.com Mon Jan 12 02:08:57 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0C88vW7025933 for ; Mon, 12 Jan 2009 02:08:57 -0600 X-ASG-Debug-ID: 1231747735-1959024c0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from an-out-0708.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 81CF717D8B23; Mon, 12 Jan 2009 00:08:55 -0800 (PST) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.240]) by cuda.sgi.com with ESMTP id O6NU3zwxqv1IWPkV; Mon, 12 Jan 2009 00:08:55 -0800 (PST) Received: by an-out-0708.google.com with SMTP id c37so4275337anc.32 for ; Mon, 12 Jan 2009 00:08:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=FwbXX/3AtsW4uWQnYQX6bTx64OFbJtYffmeI1RShqco=; b=jHP5JplZcIiqts0LOmBtTGnH+w2EWwyga8IqA1FAn+qAAFnxuNtL3ON8h4QPl4rlMc U6yPUxZKgeSCqLiSkAppdB0ZPj3rYYaappFXcWrGDeE5i3+THTlH5HfalosWmtaL9sD3 EOBWqSwWR56J36mTaMExBfBxlzo3oLEs9Te9s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=RGtfBoyzj/TslgcvsB2IxQhSpZgOU5HSncxn46YM5uaTl5o0rNF7/rIZZ+M+SAFNjm vEsdCfePqFHhgI33EsijgjWLEwDrlEwbw0XnQCtEOryXRYbTpTpYMERxf6LeyEoryEj6 mP17hwf8WdLaPwyjxeHGIlWbtI+m0Zuud0Nl8= Received: by 10.100.144.11 with SMTP id r11mr15011085and.56.1231747735431; Mon, 12 Jan 2009 00:08:55 -0800 (PST) Received: by 10.100.3.15 with HTTP; Mon, 12 Jan 2009 00:08:55 -0800 (PST) Message-ID: Date: Mon, 12 Jan 2009 11:08:55 +0300 From: "Alexander Beregalov" To: "Dave Chinner" , "Christoph Hellwig" , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 In-Reply-To: <20090112034550.GI8071@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> <20090112034550.GI8071@disturbed> X-Barracuda-Connect: an-out-0708.google.com[209.85.132.240] X-Barracuda-Start-Time: 1231747736 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15009 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV 0.91.2/8853/Sun Jan 11 18:26:44 2009 on oss.sgi.com X-Virus-Status: Clean 2009/1/12 Dave Chinner : > On Mon, Jan 12, 2009 at 03:48:13AM +0300, Alexander Beregalov wrote: >> > Hmmmm - this might be getting closer to the source of the bug. >> > It's being detecting when reading in the buffer to do a left shift >> > now, not during the delete of a record. >> > >> > I'd suggest that you treat this as the same failure and continue >> > the bisect to try to find when no problems show up at all. >> >> 687b890a184fef263ebb773926e1f4aa69240d01 is the first bad commit. > > [XFS] implement generic xfs_btree_lshift > > Make the btree left shift code generic. Based on a patch from David > Chinner with lots of changes to follow the original btree implementations > more closely. While this loses some of the generic helper routines for > inserting/moving/removing records it also solves some of the one off bugs > in the original code and makes it easier to verify. > >> Does it make sense? > > Yes, a bug in that patch could corrupt the btree in memory which we then trip > over later in delrec before it has been written to disk. > > Thank you for isolating the problem to that commit - it greatly narrows down > the amount of code we need to search to find the bug. I'll have a look tonight > to see if I can spot the problem. It seems 9eaead5 (implement generic xfs_btree_rshift) is really guilty, unless the bug "XFS internal error xfs_btree_check_lblock at line 200 of file fs/xfs/xfs_btree.c:" which I posted 5 hours ago is completely different from the original bug message. I can not reproduce the bug on 278d0ca14. From wwwrun@oss.sgi.com Mon Jan 12 13:09:14 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,BAYES_00, J_CHICKENPOX_43,J_CHICKENPOX_51,J_CHICKENPOX_71,J_CHICKENPOX_73 autolearn=unavailable version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0CJ9EUp007752 for ; Mon, 12 Jan 2009 13:09:14 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n0CJ9EUE007751; Mon, 12 Jan 2009 13:09:14 -0600 Date: Mon, 12 Jan 2009 13:09:14 -0600 Message-Id: <200901121909.n0CJ9EUE007751@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 813] New: logsize parsing in xfs_mkfs is broken for small blocksizes X-Bugzilla-Reason: AssignedTo X-Virus-Scanned: ClamAV 0.91.2/8856/Mon Jan 12 10:36:19 2009 on oss.sgi.com X-Virus-Status: Clean http://oss.sgi.com/bugzilla/show_bug.cgi?id=813 Summary: logsize parsing in xfs_mkfs is broken for small blocksizes Product: Linux XFS Version: Current Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: xfsprogs AssignedTo: xfs-masters@oss.sgi.com ReportedBy: hch@xfs.org When specifying 512 or 1024 byte blocksizes the parsing of the log size is broken in xfs_mkfs: qemu1:~# mkfs.xfs -f -l size=128m /dev/vdb meta-data=/dev/vdb isize=256 agcount=4, agsize=458752 blks = sectsz=512 attr=2 data = bsize=4096 blocks=1835008, imaxpct=25 = sunit=0 swidth=0 blks naming =version 2 bsize=4096 ascii-ci=0 log =internal log bsize=4096 blocks=32768, version=2 = sectsz=512 sunit=0 blks, lazy-count=0 realtime =none extsz=4096 blocks=0, rtextents=0 qemu1:~# mkfs.xfs -f -b size=512 -l size=128m /dev/vdb log size 262144 blocks too large, maximum size is 65536 blocks Usage: mkfs.xfs /* blocksize */ [-b log=n|size=num] /* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num, (sunit=value,swidth=value|su=num,sw=num), sectlog=n|sectsize=num /* inode size */ [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2] /* log subvol */ [-l agnum=n,internal,size=num,logdev=xxx,version=n sunit=value|su=num,sectlog=n|sectsize=num, lazy-count=0|1] /* label */ [-L label (maximum 12 characters)] /* naming */ [-n log=n|size=num,version=2|ci] /* prototype file */ [-p fname] /* quiet */ [-q] /* realtime subvol */ [-r extsize=num,size=num,rtdev=xxx] /* sectorsize */ [-s log=n|size=num] /* version */ [-V] devicename is required unless -d name=xxx is given. is xxx (bytes), xxxs (sectors), xxxb (fs blocks), xxxk (xxx KiB), xxxm (xxx MiB), xxxg (xxx GiB), xxxt (xxx TiB) or xxxp (xxx PiB). is xxx (512 byte blocks). -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From akpm@linux-foundation.org Mon Jan 12 14:18:48 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,J_CHICKENPOX_53 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0CKIj1Q016826 for ; Mon, 12 Jan 2009 14:18:48 -0600 X-ASG-Debug-ID: 1231791523-6312023e0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5A9B317DDF21 for ; Mon, 12 Jan 2009 12:18:43 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id iWn0uAE4Ucvkwc0N for ; Mon, 12 Jan 2009 12:18:43 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0CK8fYP031518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 12 Jan 2009 12:14:10 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0CJw3HB027239; Mon, 12 Jan 2009 11:58:03 -0800 Message-Id: <200901121958.n0CJw3HB027239@imap1.linux-foundation.org> X-ASG-Orig-Subj: - filesystem-freeze-implement-generic-freeze-feature.patch removed from -mm tree Subject: - filesystem-freeze-implement-generic-freeze-feature.patch removed from -mm tree To: t-sato@yk.jp.nec.com, agk@redhat.com, david@fromorbit.com, hch@lst.de, linux-ext4@vger.kernel.org, m-hamaguchi@ys.jp.nec.com, shaggy@austin.ibm.com, viro@zeniv.linux.org.uk, xfs-masters@oss.sgi.com, mm-commits@vger.kernel.org From: akpm@linux-foundation.org Date: Mon, 12 Jan 2009 11:58:03 -0800 X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231791524 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.42 X-Barracuda-Spam-Status: No, SCORE=-1.42 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=MARKETING_SUBJECT, NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15046 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name 0.60 MARKETING_SUBJECT Subject contains popular marketing words X-Virus-Scanned: ClamAV 0.91.2/8856/Mon Jan 12 10:36:19 2009 on oss.sgi.com X-Virus-Status: Clean The patch titled filesystem freeze: implement generic freeze feature has been removed from the -mm tree. Its filename was filesystem-freeze-implement-generic-freeze-feature.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: filesystem freeze: implement generic freeze feature From: Takashi Sato The ioctls for the generic freeze feature are below. o Freeze the filesystem int ioctl(int fd, int FIFREEZE, arg) fd: The file descriptor of the mountpoint FIFREEZE: request code for the freeze arg: Ignored Return value: 0 if the operation succeeds. Otherwise, -1 o Unfreeze the filesystem int ioctl(int fd, int FITHAW, arg) fd: The file descriptor of the mountpoint FITHAW: request code for unfreeze arg: Ignored Return value: 0 if the operation succeeds. Otherwise, -1 Error number: If the filesystem has already been unfrozen, errno is set to EINVAL. [akpm@linux-foundation.org: fix CONFIG_BLOCK=n] Signed-off-by: Takashi Sato Signed-off-by: Masayuki Hamaguchi Cc: Cc: Cc: Christoph Hellwig Cc: Dave Kleikamp Cc: Dave Chinner Cc: Alasdair G Kergon Cc: Al Viro Signed-off-by: Andrew Morton --- fs/block_dev.c | 2 fs/buffer.c | 74 +++++++++++++++++++++++++++++----- fs/ioctl.c | 46 +++++++++++++++++++++ include/linux/buffer_head.h | 11 ++++- include/linux/fs.h | 7 +++ 5 files changed, 130 insertions(+), 10 deletions(-) diff -puN fs/block_dev.c~filesystem-freeze-implement-generic-freeze-feature fs/block_dev.c --- a/fs/block_dev.c~filesystem-freeze-implement-generic-freeze-feature +++ a/fs/block_dev.c @@ -285,6 +285,8 @@ static void init_once(void *foo) INIT_LIST_HEAD(&bdev->bd_holder_list); #endif inode_init_once(&ei->vfs_inode); + /* Initialize mutex for freeze. */ + mutex_init(&bdev->bd_fsfreeze_mutex); } static inline void __bd_forget(struct inode *inode) diff -puN fs/buffer.c~filesystem-freeze-implement-generic-freeze-feature fs/buffer.c --- a/fs/buffer.c~filesystem-freeze-implement-generic-freeze-feature +++ a/fs/buffer.c @@ -203,10 +203,25 @@ int fsync_bdev(struct block_device *bdev * happen on bdev until thaw_bdev() is called. * If a superblock is found on this device, we take the s_umount semaphore * on it to make sure nobody unmounts until the snapshot creation is done. + * The reference counter (bd_fsfreeze_count) guarantees that only the last + * unfreeze process can unfreeze the frozen filesystem actually when multiple + * freeze requests arrive simultaneously. It counts up in freeze_bdev() and + * count down in thaw_bdev(). When it becomes 0, thaw_bdev() will unfreeze + * actually. */ struct super_block *freeze_bdev(struct block_device *bdev) { struct super_block *sb; + int error = 0; + + mutex_lock(&bdev->bd_fsfreeze_mutex); + if (bdev->bd_fsfreeze_count > 0) { + bdev->bd_fsfreeze_count++; + sb = get_super(bdev); + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return sb; + } + bdev->bd_fsfreeze_count++; down(&bdev->bd_mount_sem); sb = get_super(bdev); @@ -221,11 +236,24 @@ struct super_block *freeze_bdev(struct b sync_blockdev(sb->s_bdev); - if (sb->s_op->freeze_fs) - sb->s_op->freeze_fs(sb); + if (sb->s_op->freeze_fs) { + error = sb->s_op->freeze_fs(sb); + if (error) { + printk(KERN_ERR + "VFS:Filesystem freeze failed\n"); + sb->s_frozen = SB_UNFROZEN; + drop_super(sb); + up(&bdev->bd_mount_sem); + bdev->bd_fsfreeze_count--; + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return ERR_PTR(error); + } + } } sync_blockdev(bdev); + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return sb; /* thaw_bdev releases s->s_umount and bd_mount_sem */ } EXPORT_SYMBOL(freeze_bdev); @@ -237,20 +265,48 @@ EXPORT_SYMBOL(freeze_bdev); * * Unlocks the filesystem and marks it writeable again after freeze_bdev(). */ -void thaw_bdev(struct block_device *bdev, struct super_block *sb) +int thaw_bdev(struct block_device *bdev, struct super_block *sb) { + int error = 0; + + mutex_lock(&bdev->bd_fsfreeze_mutex); + if (!bdev->bd_fsfreeze_count) { + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return -EINVAL; + } + + bdev->bd_fsfreeze_count--; + if (bdev->bd_fsfreeze_count > 0) { + if (sb) + drop_super(sb); + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return 0; + } + if (sb) { BUG_ON(sb->s_bdev != bdev); - - if (sb->s_op->unfreeze_fs) - sb->s_op->unfreeze_fs(sb); - sb->s_frozen = SB_UNFROZEN; - smp_wmb(); - wake_up(&sb->s_wait_unfrozen); + if (!(sb->s_flags & MS_RDONLY)) { + if (sb->s_op->unfreeze_fs) { + error = sb->s_op->unfreeze_fs(sb); + if (error) { + printk(KERN_ERR + "VFS:Filesystem thaw failed\n"); + sb->s_frozen = SB_FREEZE_TRANS; + bdev->bd_fsfreeze_count++; + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return error; + } + } + sb->s_frozen = SB_UNFROZEN; + smp_wmb(); + wake_up(&sb->s_wait_unfrozen); + } drop_super(sb); } up(&bdev->bd_mount_sem); + mutex_unlock(&bdev->bd_fsfreeze_mutex); + return 0; } EXPORT_SYMBOL(thaw_bdev); diff -puN fs/ioctl.c~filesystem-freeze-implement-generic-freeze-feature fs/ioctl.c --- a/fs/ioctl.c~filesystem-freeze-implement-generic-freeze-feature +++ a/fs/ioctl.c @@ -439,6 +439,43 @@ static int ioctl_fioasync(unsigned int f return error; } +static int ioctl_fsfreeze(struct file *filp) +{ + struct super_block *sb = filp->f_path.dentry->d_inode->i_sb; + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + /* If filesystem doesn't support freeze feature, return. */ + if (sb->s_op->freeze_fs == NULL) + return -EOPNOTSUPP; + + /* If a blockdevice-backed filesystem isn't specified, return. */ + if (sb->s_bdev == NULL) + return -EINVAL; + + /* Freeze */ + sb = freeze_bdev(sb->s_bdev); + if (IS_ERR(sb)) + return PTR_ERR(sb); + return 0; +} + +static int ioctl_fsthaw(struct file *filp) +{ + struct super_block *sb = filp->f_path.dentry->d_inode->i_sb; + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + /* If a blockdevice-backed filesystem isn't specified, return EINVAL. */ + if (sb->s_bdev == NULL) + return -EINVAL; + + /* Thaw */ + return thaw_bdev(sb->s_bdev, sb); +} + /* * When you add any new common ioctls to the switches above and below * please update compat_sys_ioctl() too. @@ -486,6 +523,15 @@ int do_vfs_ioctl(struct file *filp, unsi } else error = -ENOTTY; break; + + case FIFREEZE: + error = ioctl_fsfreeze(filp); + break; + + case FITHAW: + error = ioctl_fsthaw(filp); + break; + default: if (S_ISREG(filp->f_path.dentry->d_inode->i_mode)) error = file_ioctl(filp, cmd, arg); diff -puN include/linux/buffer_head.h~filesystem-freeze-implement-generic-freeze-feature include/linux/buffer_head.h --- a/include/linux/buffer_head.h~filesystem-freeze-implement-generic-freeze-feature +++ a/include/linux/buffer_head.h @@ -171,7 +171,7 @@ void __wait_on_buffer(struct buffer_head wait_queue_head_t *bh_waitq_head(struct buffer_head *bh); int fsync_bdev(struct block_device *); struct super_block *freeze_bdev(struct block_device *); -void thaw_bdev(struct block_device *, struct super_block *); +int thaw_bdev(struct block_device *, struct super_block *); int fsync_super(struct super_block *); int fsync_no_super(struct block_device *); struct buffer_head *__find_get_block(struct block_device *bdev, sector_t block, @@ -346,6 +346,15 @@ static inline int remove_inode_buffers(s static inline int sync_mapping_buffers(struct address_space *mapping) { return 0; } static inline void invalidate_bdev(struct block_device *bdev) {} +static inline struct super_block *freeze_bdev(struct block_device *sb) +{ + return NULL; +} + +static inline int thaw_bdev(struct block_device *bdev, struct super_block *sb) +{ + return 0; +} #endif /* CONFIG_BLOCK */ #endif /* _LINUX_BUFFER_HEAD_H */ diff -puN include/linux/fs.h~filesystem-freeze-implement-generic-freeze-feature include/linux/fs.h --- a/include/linux/fs.h~filesystem-freeze-implement-generic-freeze-feature +++ a/include/linux/fs.h @@ -234,6 +234,8 @@ struct inodes_stat_t { #define BMAP_IOCTL 1 /* obsolete - kept for compatibility */ #define FIBMAP _IO(0x00,1) /* bmap access */ #define FIGETBSZ _IO(0x00,2) /* get the block size used for bmap */ +#define FIFREEZE _IOWR('X', 119, int) /* Freeze */ +#define FITHAW _IOWR('X', 120, int) /* Thaw */ #define FS_IOC_GETFLAGS _IOR('f', 1, long) #define FS_IOC_SETFLAGS _IOW('f', 2, long) @@ -591,6 +593,11 @@ struct block_device { * care to not mess up bd_private for that case. */ unsigned long bd_private; + + /* The counter of freeze processes */ + int bd_fsfreeze_count; + /* Mutex for freeze */ + struct mutex bd_fsfreeze_mutex; }; /* _ Patches currently in -mm which might be from t-sato@yk.jp.nec.com are From akpm@linux-foundation.org Mon Jan 12 14:18:48 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0CKIk2t016828 for ; Mon, 12 Jan 2009 14:18:48 -0600 X-ASG-Debug-ID: 1231791523-6312023e0002-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5BE8817DDF2D for ; Mon, 12 Jan 2009 12:18:44 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id D36S0KHggDLaMj1Z for ; Mon, 12 Jan 2009 12:18:44 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0CJw1KM030501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 12 Jan 2009 11:58:02 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0CJvxkC027198; Mon, 12 Jan 2009 11:57:59 -0800 Message-Id: <200901121957.n0CJvxkC027198@imap1.linux-foundation.org> X-ASG-Orig-Subj: - filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs.patch removed from -mm tree Subject: - filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs.patch removed from -mm tree To: t-sato@yk.jp.nec.com, agk@redhat.com, david@fromorbit.com, hch@lst.de, linux-ext4@vger.kernel.org, m-hamaguchi@ys.jp.nec.com, shaggy@austin.ibm.com, viro@zeniv.linux.org.uk, xfs-masters@oss.sgi.com, mm-commits@vger.kernel.org From: akpm@linux-foundation.org Date: Mon, 12 Jan 2009 11:57:59 -0800 X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231791525 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15046 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8856/Mon Jan 12 10:36:19 2009 on oss.sgi.com X-Virus-Status: Clean The patch titled filesystem freeze: add error handling of write_super_lockfs/unlockfs has been removed from the -mm tree. Its filename was filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: filesystem freeze: add error handling of write_super_lockfs/unlockfs From: Takashi Sato Currently, ext3 in mainline Linux doesn't have the freeze feature which suspends write requests. So, we cannot take a backup which keeps the filesystem's consistency with the storage device's features (snapshot and replication) while it is mounted. In many case, a commercial filesystem (e.g. VxFS) has the freeze feature and it would be used to get the consistent backup. If Linux's standard filesystem ext3 has the freeze feature, we can do it without a commercial filesystem. So I have implemented the ioctls of the freeze feature. I think we can take the consistent backup with the following steps. 1. Freeze the filesystem with the freeze ioctl. 2. Separate the replication volume or create the snapshot with the storage device's feature. 3. Unfreeze the filesystem with the unfreeze ioctl. 4. Take the backup from the separated replication volume or the snapshot. This patch: VFS: Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that they can return an error. Rename write_super_lockfs and unlockfs of the super block operation freeze_fs and unfreeze_fs to avoid a confusion. ext3, ext4, xfs, gfs2, jfs: Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that write_super_lockfs returns an error if needed, and unlockfs always returns 0. reiserfs: Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that they always return 0 (success) to keep a current behavior. Signed-off-by: Takashi Sato Signed-off-by: Masayuki Hamaguchi Cc: Cc: Cc: Christoph Hellwig Cc: Dave Kleikamp Cc: Dave Chinner Cc: Alasdair G Kergon Cc: Al Viro Signed-off-by: Andrew Morton --- Documentation/filesystems/Locking | 8 ++-- Documentation/filesystems/vfs.txt | 8 ++-- fs/buffer.c | 8 ++-- fs/ext3/super.c | 45 ++++++++++++++++++---------- fs/ext4/super.c | 45 +++++++++++++++++++--------- fs/gfs2/ops_super.c | 16 +++++---- fs/jfs/super.c | 10 +++--- fs/reiserfs/super.c | 10 +++--- fs/xfs/linux-2.6/xfs_super.c | 8 ++-- fs/xfs/xfs_fsops.c | 11 ++++-- fs/xfs/xfs_fsops.h | 2 - include/linux/fs.h | 4 +- 12 files changed, 107 insertions(+), 68 deletions(-) diff -puN Documentation/filesystems/Locking~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs Documentation/filesystems/Locking --- a/Documentation/filesystems/Locking~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/Documentation/filesystems/Locking @@ -97,8 +97,8 @@ prototypes: void (*put_super) (struct super_block *); void (*write_super) (struct super_block *); int (*sync_fs)(struct super_block *sb, int wait); - void (*write_super_lockfs) (struct super_block *); - void (*unlockfs) (struct super_block *); + int (*freeze_fs) (struct super_block *); + int (*unfreeze_fs) (struct super_block *); int (*statfs) (struct dentry *, struct kstatfs *); int (*remount_fs) (struct super_block *, int *, char *); void (*clear_inode) (struct inode *); @@ -119,8 +119,8 @@ delete_inode: no put_super: yes yes no write_super: no yes read sync_fs: no no read -write_super_lockfs: ? -unlockfs: ? +freeze_fs: ? +unfreeze_fs: ? statfs: no no no remount_fs: yes yes maybe (see below) clear_inode: no diff -puN Documentation/filesystems/vfs.txt~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs Documentation/filesystems/vfs.txt --- a/Documentation/filesystems/vfs.txt~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/Documentation/filesystems/vfs.txt @@ -210,8 +210,8 @@ struct super_operations { void (*put_super) (struct super_block *); void (*write_super) (struct super_block *); int (*sync_fs)(struct super_block *sb, int wait); - void (*write_super_lockfs) (struct super_block *); - void (*unlockfs) (struct super_block *); + int (*freeze_fs) (struct super_block *); + int (*unfreeze_fs) (struct super_block *); int (*statfs) (struct dentry *, struct kstatfs *); int (*remount_fs) (struct super_block *, int *, char *); void (*clear_inode) (struct inode *); @@ -270,11 +270,11 @@ or bottom half). a superblock. The second parameter indicates whether the method should wait until the write out has been completed. Optional. - write_super_lockfs: called when VFS is locking a filesystem and + freeze_fs: called when VFS is locking a filesystem and forcing it into a consistent state. This method is currently used by the Logical Volume Manager (LVM). - unlockfs: called when VFS is unlocking a filesystem and making it writable + unfreeze_fs: called when VFS is unlocking a filesystem and making it writable again. statfs: called when the VFS needs to get filesystem statistics. This diff -puN fs/buffer.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/buffer.c --- a/fs/buffer.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/buffer.c @@ -221,8 +221,8 @@ struct super_block *freeze_bdev(struct b sync_blockdev(sb->s_bdev); - if (sb->s_op->write_super_lockfs) - sb->s_op->write_super_lockfs(sb); + if (sb->s_op->freeze_fs) + sb->s_op->freeze_fs(sb); } sync_blockdev(bdev); @@ -242,8 +242,8 @@ void thaw_bdev(struct block_device *bdev if (sb) { BUG_ON(sb->s_bdev != bdev); - if (sb->s_op->unlockfs) - sb->s_op->unlockfs(sb); + if (sb->s_op->unfreeze_fs) + sb->s_op->unfreeze_fs(sb); sb->s_frozen = SB_UNFROZEN; smp_wmb(); wake_up(&sb->s_wait_unfrozen); diff -puN fs/ext3/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/ext3/super.c --- a/fs/ext3/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/ext3/super.c @@ -48,8 +48,8 @@ static int ext3_load_journal(struct supe unsigned long journal_devnum); static int ext3_create_journal(struct super_block *, struct ext3_super_block *, unsigned int); -static void ext3_commit_super (struct super_block * sb, - struct ext3_super_block * es, +static int ext3_commit_super(struct super_block *sb, + struct ext3_super_block *es, int sync); static void ext3_mark_recovery_complete(struct super_block * sb, struct ext3_super_block * es); @@ -60,9 +60,9 @@ static const char *ext3_decode_error(str char nbuf[16]); static int ext3_remount (struct super_block * sb, int * flags, char * data); static int ext3_statfs (struct dentry * dentry, struct kstatfs * buf); -static void ext3_unlockfs(struct super_block *sb); +static int ext3_unfreeze(struct super_block *sb); static void ext3_write_super (struct super_block * sb); -static void ext3_write_super_lockfs(struct super_block *sb); +static int ext3_freeze(struct super_block *sb); /* * Wrappers for journal_start/end. @@ -759,8 +759,8 @@ static const struct super_operations ext .put_super = ext3_put_super, .write_super = ext3_write_super, .sync_fs = ext3_sync_fs, - .write_super_lockfs = ext3_write_super_lockfs, - .unlockfs = ext3_unlockfs, + .freeze_fs = ext3_freeze, + .unfreeze_fs = ext3_unfreeze, .statfs = ext3_statfs, .remount_fs = ext3_remount, .clear_inode = ext3_clear_inode, @@ -2311,21 +2311,23 @@ static int ext3_create_journal(struct su return 0; } -static void ext3_commit_super (struct super_block * sb, - struct ext3_super_block * es, +static int ext3_commit_super(struct super_block *sb, + struct ext3_super_block *es, int sync) { struct buffer_head *sbh = EXT3_SB(sb)->s_sbh; + int error = 0; if (!sbh) - return; + return error; es->s_wtime = cpu_to_le32(get_seconds()); es->s_free_blocks_count = cpu_to_le32(ext3_count_free_blocks(sb)); es->s_free_inodes_count = cpu_to_le32(ext3_count_free_inodes(sb)); BUFFER_TRACE(sbh, "marking dirty"); mark_buffer_dirty(sbh); if (sync) - sync_dirty_buffer(sbh); + error = sync_dirty_buffer(sbh); + return error; } @@ -2439,12 +2441,14 @@ static int ext3_sync_fs(struct super_blo * LVM calls this function before a (read-only) snapshot is created. This * gives us a chance to flush the journal completely and mark the fs clean. */ -static void ext3_write_super_lockfs(struct super_block *sb) +static int ext3_freeze(struct super_block *sb) { + int error = 0; + journal_t *journal; sb->s_dirt = 0; if (!(sb->s_flags & MS_RDONLY)) { - journal_t *journal = EXT3_SB(sb)->s_journal; + journal = EXT3_SB(sb)->s_journal; /* Now we set up the journal barrier. */ journal_lock_updates(journal); @@ -2453,20 +2457,28 @@ static void ext3_write_super_lockfs(stru * We don't want to clear needs_recovery flag when we failed * to flush the journal. */ - if (journal_flush(journal) < 0) - return; + error = journal_flush(journal); + if (error < 0) + goto out; /* Journal blocked and flushed, clear needs_recovery flag. */ EXT3_CLEAR_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER); - ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1); + error = ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1); + if (error) + goto out; } + return 0; + +out: + journal_unlock_updates(journal); + return error; } /* * Called by LVM after the snapshot is done. We need to reset the RECOVER * flag here, even though the filesystem is not technically dirty yet. */ -static void ext3_unlockfs(struct super_block *sb) +static int ext3_unfreeze(struct super_block *sb) { if (!(sb->s_flags & MS_RDONLY)) { lock_super(sb); @@ -2476,6 +2488,7 @@ static void ext3_unlockfs(struct super_b unlock_super(sb); journal_unlock_updates(EXT3_SB(sb)->s_journal); } + return 0; } static int ext3_remount (struct super_block * sb, int * flags, char * data) diff -puN fs/ext4/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/ext4/super.c --- a/fs/ext4/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/ext4/super.c @@ -51,7 +51,7 @@ struct proc_dir_entry *ext4_proc_root; static int ext4_load_journal(struct super_block *, struct ext4_super_block *, unsigned long journal_devnum); -static void ext4_commit_super(struct super_block *sb, +static int ext4_commit_super(struct super_block *sb, struct ext4_super_block *es, int sync); static void ext4_mark_recovery_complete(struct super_block *sb, struct ext4_super_block *es); @@ -62,9 +62,9 @@ static const char *ext4_decode_error(str char nbuf[16]); static int ext4_remount(struct super_block *sb, int *flags, char *data); static int ext4_statfs(struct dentry *dentry, struct kstatfs *buf); -static void ext4_unlockfs(struct super_block *sb); +static int ext4_unfreeze(struct super_block *sb); static void ext4_write_super(struct super_block *sb); -static void ext4_write_super_lockfs(struct super_block *sb); +static int ext4_freeze(struct super_block *sb); ext4_fsblk_t ext4_block_bitmap(struct super_block *sb, @@ -978,8 +978,8 @@ static const struct super_operations ext .put_super = ext4_put_super, .write_super = ext4_write_super, .sync_fs = ext4_sync_fs, - .write_super_lockfs = ext4_write_super_lockfs, - .unlockfs = ext4_unlockfs, + .freeze_fs = ext4_freeze, + .unfreeze_fs = ext4_unfreeze, .statfs = ext4_statfs, .remount_fs = ext4_remount, .clear_inode = ext4_clear_inode, @@ -2888,13 +2888,14 @@ static int ext4_load_journal(struct supe return 0; } -static void ext4_commit_super(struct super_block *sb, +static int ext4_commit_super(struct super_block *sb, struct ext4_super_block *es, int sync) { struct buffer_head *sbh = EXT4_SB(sb)->s_sbh; + int error = 0; if (!sbh) - return; + return error; if (buffer_write_io_error(sbh)) { /* * Oh, dear. A previous attempt to write the @@ -2918,14 +2919,19 @@ static void ext4_commit_super(struct sup BUFFER_TRACE(sbh, "marking dirty"); mark_buffer_dirty(sbh); if (sync) { - sync_dirty_buffer(sbh); - if (buffer_write_io_error(sbh)) { + error = sync_dirty_buffer(sbh); + if (error) + return error; + + error = buffer_write_io_error(sbh); + if (error) { printk(KERN_ERR "EXT4-fs: I/O error while writing " "superblock for %s.\n", sb->s_id); clear_buffer_write_io_error(sbh); set_buffer_uptodate(sbh); } } + return error; } @@ -3058,12 +3064,14 @@ static int ext4_sync_fs(struct super_blo * LVM calls this function before a (read-only) snapshot is created. This * gives us a chance to flush the journal completely and mark the fs clean. */ -static void ext4_write_super_lockfs(struct super_block *sb) +static int ext4_freeze(struct super_block *sb) { + int error = 0; + journal_t *journal; sb->s_dirt = 0; if (!(sb->s_flags & MS_RDONLY)) { - journal_t *journal = EXT4_SB(sb)->s_journal; + journal = EXT4_SB(sb)->s_journal; if (journal) { /* Now we set up the journal barrier. */ @@ -3073,21 +3081,29 @@ static void ext4_write_super_lockfs(stru * We don't want to clear needs_recovery flag when we * failed to flush the journal. */ - if (jbd2_journal_flush(journal) < 0) - return; + error = jbd2_journal_flush(journal); + if (error < 0) + goto out; } /* Journal blocked and flushed, clear needs_recovery flag. */ EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER); ext4_commit_super(sb, EXT4_SB(sb)->s_es, 1); + error = ext4_commit_super(sb, EXT4_SB(sb)->s_es, 1); + if (error) + goto out; } + return 0; +out: + jbd2_journal_unlock_updates(journal); + return error; } /* * Called by LVM after the snapshot is done. We need to reset the RECOVER * flag here, even though the filesystem is not technically dirty yet. */ -static void ext4_unlockfs(struct super_block *sb) +static int ext4_unfreeze(struct super_block *sb) { if (EXT4_SB(sb)->s_journal && !(sb->s_flags & MS_RDONLY)) { lock_super(sb); @@ -3097,6 +3113,7 @@ static void ext4_unlockfs(struct super_b unlock_super(sb); jbd2_journal_unlock_updates(EXT4_SB(sb)->s_journal); } + return 0; } static int ext4_remount(struct super_block *sb, int *flags, char *data) diff -puN fs/gfs2/ops_super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/gfs2/ops_super.c --- a/fs/gfs2/ops_super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/gfs2/ops_super.c @@ -211,18 +211,18 @@ static int gfs2_sync_fs(struct super_blo } /** - * gfs2_write_super_lockfs - prevent further writes to the filesystem + * gfs2_freeze - prevent further writes to the filesystem * @sb: the VFS structure for the filesystem * */ -static void gfs2_write_super_lockfs(struct super_block *sb) +static int gfs2_freeze(struct super_block *sb) { struct gfs2_sbd *sdp = sb->s_fs_info; int error; if (test_bit(SDF_SHUTDOWN, &sdp->sd_flags)) - return; + return -EINVAL; for (;;) { error = gfs2_freeze_fs(sdp); @@ -242,17 +242,19 @@ static void gfs2_write_super_lockfs(stru fs_err(sdp, "retrying...\n"); msleep(1000); } + return 0; } /** - * gfs2_unlockfs - reallow writes to the filesystem + * gfs2_unfreeze - reallow writes to the filesystem * @sb: the VFS structure for the filesystem * */ -static void gfs2_unlockfs(struct super_block *sb) +static int gfs2_unfreeze(struct super_block *sb) { gfs2_unfreeze_fs(sb->s_fs_info); + return 0; } /** @@ -688,8 +690,8 @@ const struct super_operations gfs2_super .put_super = gfs2_put_super, .write_super = gfs2_write_super, .sync_fs = gfs2_sync_fs, - .write_super_lockfs = gfs2_write_super_lockfs, - .unlockfs = gfs2_unlockfs, + .freeze_fs = gfs2_freeze, + .unfreeze_fs = gfs2_unfreeze, .statfs = gfs2_statfs, .remount_fs = gfs2_remount_fs, .clear_inode = gfs2_clear_inode, diff -puN fs/jfs/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/jfs/super.c --- a/fs/jfs/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/jfs/super.c @@ -543,7 +543,7 @@ out_kfree: return ret; } -static void jfs_write_super_lockfs(struct super_block *sb) +static int jfs_freeze(struct super_block *sb) { struct jfs_sb_info *sbi = JFS_SBI(sb); struct jfs_log *log = sbi->log; @@ -553,9 +553,10 @@ static void jfs_write_super_lockfs(struc lmLogShutdown(log); updateSuper(sb, FM_CLEAN); } + return 0; } -static void jfs_unlockfs(struct super_block *sb) +static int jfs_unfreeze(struct super_block *sb) { struct jfs_sb_info *sbi = JFS_SBI(sb); struct jfs_log *log = sbi->log; @@ -568,6 +569,7 @@ static void jfs_unlockfs(struct super_bl else txResume(sb); } + return 0; } static int jfs_get_sb(struct file_system_type *fs_type, @@ -735,8 +737,8 @@ static const struct super_operations jfs .delete_inode = jfs_delete_inode, .put_super = jfs_put_super, .sync_fs = jfs_sync_fs, - .write_super_lockfs = jfs_write_super_lockfs, - .unlockfs = jfs_unlockfs, + .freeze_fs = jfs_freeze, + .unfreeze_fs = jfs_unfreeze, .statfs = jfs_statfs, .remount_fs = jfs_remount, .show_options = jfs_show_options, diff -puN fs/reiserfs/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/reiserfs/super.c --- a/fs/reiserfs/super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/reiserfs/super.c @@ -83,7 +83,7 @@ static void reiserfs_write_super(struct reiserfs_sync_fs(s, 1); } -static void reiserfs_write_super_lockfs(struct super_block *s) +static int reiserfs_freeze(struct super_block *s) { struct reiserfs_transaction_handle th; reiserfs_write_lock(s); @@ -101,11 +101,13 @@ static void reiserfs_write_super_lockfs( } s->s_dirt = 0; reiserfs_write_unlock(s); + return 0; } -static void reiserfs_unlockfs(struct super_block *s) +static int reiserfs_unfreeze(struct super_block *s) { reiserfs_allow_writes(s); + return 0; } extern const struct in_core_key MAX_IN_CORE_KEY; @@ -613,8 +615,8 @@ static const struct super_operations rei .put_super = reiserfs_put_super, .write_super = reiserfs_write_super, .sync_fs = reiserfs_sync_fs, - .write_super_lockfs = reiserfs_write_super_lockfs, - .unlockfs = reiserfs_unlockfs, + .freeze_fs = reiserfs_freeze, + .unfreeze_fs = reiserfs_unfreeze, .statfs = reiserfs_statfs, .remount_fs = reiserfs_remount, .show_options = generic_show_options, diff -puN fs/xfs/linux-2.6/xfs_super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/xfs/linux-2.6/xfs_super.c --- a/fs/xfs/linux-2.6/xfs_super.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/xfs/linux-2.6/xfs_super.c @@ -1269,14 +1269,14 @@ xfs_fs_remount( * need to take care of the metadata. Once that's done write a dummy * record to dirty the log in case of a crash while frozen. */ -STATIC void -xfs_fs_lockfs( +STATIC int +xfs_fs_freeze( struct super_block *sb) { struct xfs_mount *mp = XFS_M(sb); xfs_quiesce_attr(mp); - xfs_fs_log_dummy(mp); + return -xfs_fs_log_dummy(mp); } STATIC int @@ -1557,7 +1557,7 @@ static struct super_operations xfs_super .put_super = xfs_fs_put_super, .write_super = xfs_fs_write_super, .sync_fs = xfs_fs_sync_super, - .write_super_lockfs = xfs_fs_lockfs, + .freeze_fs = xfs_fs_freeze, .statfs = xfs_fs_statfs, .remount_fs = xfs_fs_remount, .show_options = xfs_fs_show_options, diff -puN fs/xfs/xfs_fsops.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/xfs/xfs_fsops.c --- a/fs/xfs/xfs_fsops.c~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/xfs/xfs_fsops.c @@ -595,17 +595,19 @@ out: return 0; } -void +int xfs_fs_log_dummy( xfs_mount_t *mp) { xfs_trans_t *tp; xfs_inode_t *ip; + int error; tp = _xfs_trans_alloc(mp, XFS_TRANS_DUMMY1); - if (xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0)) { + error = xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0); + if (error) { xfs_trans_cancel(tp, 0); - return; + return error; } ip = mp->m_rootip; @@ -615,9 +617,10 @@ xfs_fs_log_dummy( xfs_trans_ihold(tp, ip); xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); xfs_trans_set_sync(tp); - xfs_trans_commit(tp, 0); + error = xfs_trans_commit(tp, 0); xfs_iunlock(ip, XFS_ILOCK_EXCL); + return error; } int diff -puN fs/xfs/xfs_fsops.h~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs fs/xfs/xfs_fsops.h --- a/fs/xfs/xfs_fsops.h~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/fs/xfs/xfs_fsops.h @@ -25,6 +25,6 @@ extern int xfs_fs_counts(xfs_mount_t *mp extern int xfs_reserve_blocks(xfs_mount_t *mp, __uint64_t *inval, xfs_fsop_resblks_t *outval); extern int xfs_fs_goingdown(xfs_mount_t *mp, __uint32_t inflags); -extern void xfs_fs_log_dummy(xfs_mount_t *mp); +extern int xfs_fs_log_dummy(xfs_mount_t *mp); #endif /* __XFS_FSOPS_H__ */ diff -puN include/linux/fs.h~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs include/linux/fs.h --- a/include/linux/fs.h~filesystem-freeze-add-error-handling-of-write_super_lockfs-unlockfs +++ a/include/linux/fs.h @@ -1377,8 +1377,8 @@ struct super_operations { void (*put_super) (struct super_block *); void (*write_super) (struct super_block *); int (*sync_fs)(struct super_block *sb, int wait); - void (*write_super_lockfs) (struct super_block *); - void (*unlockfs) (struct super_block *); + int (*freeze_fs) (struct super_block *); + int (*unfreeze_fs) (struct super_block *); int (*statfs) (struct dentry *, struct kstatfs *); int (*remount_fs) (struct super_block *, int *, char *); void (*clear_inode) (struct inode *); _ Patches currently in -mm which might be from t-sato@yk.jp.nec.com are From akpm@linux-foundation.org Mon Jan 12 14:28:14 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0CKSEqg017337 for ; Mon, 12 Jan 2009 14:28:14 -0600 X-ASG-Debug-ID: 1231792092-62f402b10000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C821517DD763 for ; Mon, 12 Jan 2009 12:28:12 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id LhcfUyAdyVGWnUZo for ; Mon, 12 Jan 2009 12:28:12 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0CK8fYN031518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 12 Jan 2009 12:13:42 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0CJw6mt027334; Mon, 12 Jan 2009 11:58:06 -0800 Message-Id: <200901121958.n0CJw6mt027334@imap1.linux-foundation.org> X-ASG-Orig-Subj: - filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature.patch removed from -mm tree Subject: - filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature.patch removed from -mm tree To: t-sato@yk.jp.nec.com, agk@redhat.com, david@fromorbit.com, dgc@sgi.com, hch@lst.de, linux-ext4@vger.kernel.org, shaggy@austin.ibm.com, viro@zeniv.linux.org.uk, xfs-masters@oss.sgi.com, mm-commits@vger.kernel.org From: akpm@linux-foundation.org Date: Mon, 12 Jan 2009 11:58:06 -0800 X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231792093 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15048 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8856/Mon Jan 12 10:36:19 2009 on oss.sgi.com X-Virus-Status: Clean The patch titled filesystem freeze: remove XFS specific ioctl interfaces for freeze feature has been removed from the -mm tree. Its filename was filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: filesystem freeze: remove XFS specific ioctl interfaces for freeze feature From: Takashi Sato It removes XFS specific ioctl interfaces and request codes for freeze feature. This patch has been supplied by David Chinner. Signed-off-by: Dave Chinner Signed-off-by: Takashi Sato Cc: Dave Chinner Cc: Cc: Cc: Christoph Hellwig Cc: Dave Kleikamp Cc: Alasdair G Kergon Cc: Al Viro Signed-off-by: Andrew Morton --- fs/xfs/linux-2.6/xfs_ioctl.c | 15 --------------- fs/xfs/linux-2.6/xfs_ioctl32.c | 2 -- fs/xfs/xfs_fs.h | 4 ++-- 3 files changed, 2 insertions(+), 19 deletions(-) diff -puN fs/xfs/linux-2.6/xfs_ioctl.c~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature fs/xfs/linux-2.6/xfs_ioctl.c --- a/fs/xfs/linux-2.6/xfs_ioctl.c~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature +++ a/fs/xfs/linux-2.6/xfs_ioctl.c @@ -1546,21 +1546,6 @@ xfs_file_ioctl( return -error; } - case XFS_IOC_FREEZE: - if (!capable(CAP_SYS_ADMIN)) - return -EPERM; - - if (inode->i_sb->s_frozen == SB_UNFROZEN) - freeze_bdev(inode->i_sb->s_bdev); - return 0; - - case XFS_IOC_THAW: - if (!capable(CAP_SYS_ADMIN)) - return -EPERM; - if (inode->i_sb->s_frozen != SB_UNFROZEN) - thaw_bdev(inode->i_sb->s_bdev, inode->i_sb); - return 0; - case XFS_IOC_GOINGDOWN: { __uint32_t in; diff -puN fs/xfs/linux-2.6/xfs_ioctl32.c~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature fs/xfs/linux-2.6/xfs_ioctl32.c --- a/fs/xfs/linux-2.6/xfs_ioctl32.c~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature +++ a/fs/xfs/linux-2.6/xfs_ioctl32.c @@ -632,8 +632,6 @@ xfs_file_compat_ioctl( case XFS_IOC_SET_RESBLKS: case XFS_IOC_GET_RESBLKS: case XFS_IOC_FSGROWFSLOG: - case XFS_IOC_FREEZE: - case XFS_IOC_THAW: case XFS_IOC_GOINGDOWN: case XFS_IOC_ERROR_INJECTION: case XFS_IOC_ERROR_CLEARALL: diff -puN fs/xfs/xfs_fs.h~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature fs/xfs/xfs_fs.h --- a/fs/xfs/xfs_fs.h~filesystem-freeze-remove-xfs-specific-ioctl-interfaces-for-freeze-feature +++ a/fs/xfs/xfs_fs.h @@ -465,8 +465,8 @@ typedef struct xfs_handle { #define XFS_IOC_ERROR_INJECTION _IOW ('X', 116, struct xfs_error_injection) #define XFS_IOC_ERROR_CLEARALL _IOW ('X', 117, struct xfs_error_injection) /* XFS_IOC_ATTRCTL_BY_HANDLE -- deprecated 118 */ -#define XFS_IOC_FREEZE _IOWR('X', 119, int) -#define XFS_IOC_THAW _IOWR('X', 120, int) +/* XFS_IOC_FREEZE -- FIFREEZE 119 */ +/* XFS_IOC_THAW -- FITHAW 120 */ #define XFS_IOC_FSSETDM_BY_HANDLE _IOW ('X', 121, struct xfs_fsop_setdm_handlereq) #define XFS_IOC_ATTRLIST_BY_HANDLE _IOW ('X', 122, struct xfs_fsop_attrlist_handlereq) #define XFS_IOC_ATTRMULTI_BY_HANDLE _IOW ('X', 123, struct xfs_fsop_attrmulti_handlereq) _ Patches currently in -mm which might be from t-sato@yk.jp.nec.com are From david@fromorbit.com Mon Jan 12 15:18:58 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0CLIte1020451 for ; Mon, 12 Jan 2009 15:18:58 -0600 X-ASG-Debug-ID: 1231795132-200d00170000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id CA4E517DE723; Mon, 12 Jan 2009 13:18:53 -0800 (PST) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id W7xS5NZGB167B2N1; Mon, 12 Jan 2009 13:18:53 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlQDABtCa0l5LDnlgWdsb2JhbACUFgEBFiK/B4Vv X-IronPort-AV: E=Sophos;i="4.37,254,1231075800"; d="scan'208";a="292118112" Received: from ppp121-44-57-229.lns10.syd7.internode.on.net (HELO disturbed) ([121.44.57.229]) by ipmail05.adl2.internode.on.net with ESMTP; 13 Jan 2009 07:48:50 +1030 Received: from dave by disturbed with local (Exim 4.69) (envelope-from ) id 1LMUBM-0003lJ-NL; Tue, 13 Jan 2009 08:18:48 +1100 Date: Tue, 13 Jan 2009 08:18:48 +1100 From: Dave Chinner To: Alexander Beregalov Cc: Christoph Hellwig , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090112211848.GL8071@disturbed> Mail-Followup-To: Alexander Beregalov , Christoph Hellwig , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org References: <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> <20090112034550.GI8071@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Barracuda-Connect: ipmail05.adl2.internode.on.net[203.16.214.145] X-Barracuda-Start-Time: 1231795134 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15050 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV 0.91.2/8856/Mon Jan 12 10:36:19 2009 on oss.sgi.com X-Virus-Status: Clean On Mon, Jan 12, 2009 at 11:08:55AM +0300, Alexander Beregalov wrote: > 2009/1/12 Dave Chinner : > > On Mon, Jan 12, 2009 at 03:48:13AM +0300, Alexander Beregalov wrote: > >> > Hmmmm - this might be getting closer to the source of the bug. > >> > It's being detecting when reading in the buffer to do a left shift > >> > now, not during the delete of a record. > >> > > >> > I'd suggest that you treat this as the same failure and continue > >> > the bisect to try to find when no problems show up at all. > >> > >> 687b890a184fef263ebb773926e1f4aa69240d01 is the first bad commit. > > > > [XFS] implement generic xfs_btree_lshift > > > > Make the btree left shift code generic. Based on a patch from David > > Chinner with lots of changes to follow the original btree implementations > > more closely. While this loses some of the generic helper routines for > > inserting/moving/removing records it also solves some of the one off bugs > > in the original code and makes it easier to verify. > > > >> Does it make sense? > > > > Yes, a bug in that patch could corrupt the btree in memory which we then trip > > over later in delrec before it has been written to disk. > > > > Thank you for isolating the problem to that commit - it greatly narrows down > > the amount of code we need to search to find the bug. I'll have a look tonight > > to see if I can spot the problem. > > It seems 9eaead5 (implement generic xfs_btree_rshift) is really guilty, unless > the bug "XFS internal error xfs_btree_check_lblock at line 200 of file > fs/xfs/xfs_btree.c:" > which I posted 5 hours ago is completely different from the original > bug message. > I can not reproduce the bug on 278d0ca14. Ok, Thanks for clarifying. ;) I'll have a look through the rshift patch and try to find what we broke by inspection. Cheers, Dave. -- Dave Chinner david@fromorbit.com From wwwrun@oss.sgi.com Mon Jan 12 18:16:05 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0D0G4NE001208 for ; Mon, 12 Jan 2009 18:16:05 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n0CNG30f029879; Mon, 12 Jan 2009 17:16:03 -0600 Date: Mon, 12 Jan 2009 17:16:03 -0600 Message-Id: <200901122316.n0CNG30f029879@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 813] logsize parsing in xfs_mkfs is broken for small blocksizes X-Bugzilla-Reason: AssignedTo X-Virus-Scanned: ClamAV 0.91.2/8856/Mon Jan 12 10:36:19 2009 on oss.sgi.com X-Virus-Status: Clean http://oss.sgi.com/bugzilla/show_bug.cgi?id=813 ------- Additional Comments From david@fromorbit.com 2009-01-12 17:15 CST ------- The parse is not broken - the log size #defines prevent this. The 2GB log size patches I posted a while back sorta fix this (allows 1x10^6 blocks for the log): http://oss.sgi.com/archives/xfs/2008-05/msg00335.html and the qa test: http://oss.sgi.com/archives/xfs/2008-05/msg00338.html -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Tue Jan 13 15:05:11 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0DL5B52008799 for ; Tue, 13 Jan 2009 15:05:11 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n0DL5Buf008798; Tue, 13 Jan 2009 15:05:11 -0600 Date: Tue, 13 Jan 2009 15:05:11 -0600 Message-Id: <200901132105.n0DL5Buf008798@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 680] XFS_WANT_CORRUPTED_RETURN in xfs_alloc.c X-Bugzilla-Reason: AssignedTo X-Virus-Scanned: ClamAV 0.91.2/8861/Tue Jan 13 10:09:19 2009 on oss.sgi.com X-Virus-Status: Clean http://oss.sgi.com/bugzilla/show_bug.cgi?id=680 bo@vircio.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | ------- Additional Comments From bo@vircio.com 2009-01-13 15:05 CST ------- This is still a problem.... Happening on a machine with a 16 drive RAID 5 array running on a 3ware 9650SE controller. The machine is a backup server and we're doing 4 simultaneous reverse binary diffs on 2GB files. Stack trace and system information below. [105249.002236] XFS internal error XFS_WANT_CORRUPTED_RETURN at line 296 of file /build/buildd/linux-2.6.24/fs/xfs/xfs_alloc.c. Caller 0xf92e9138 [105249.015164] Pid: 16747, comm: rdiff-backup Not tainted 2.6.24-22-server #1 [105249.022154] [] xfs_alloc_fixup_trees+0x2e6/0x3a0 [xfs] [105249.028464] [] xfs_alloc_ag_vextent_near+0x448/0xa00 [xfs] [105249.035116] [] xfs_alloc_ag_vextent_near+0x448/0xa00 [xfs] [105249.041774] [] xfs_alloc_ag_vextent+0xc7/0x120 [xfs] [105249.047933] [] xfs_alloc_vextent+0x285/0x510 [xfs] [105249.053868] [] xfs_bmap_btalloc+0x513/0xc50 [xfs] [105249.059698] [] xfs_iomap_eof_want_preallocate+0x149/0x220 [xfs] [105249.066757] [] xfs_bmapi+0x751/0x16a0 [xfs] [105249.072065] [] xfs_iext_bno_to_ext+0xad/0x1f0 [xfs] [105249.078085] [] xlog_grant_log_space+0x22f/0x270 [xfs] [105249.084280] [] xfs_trans_reserve+0x84/0x200 [xfs] [105249.090120] [] xfs_iomap_write_allocate+0x2df/0x510 [xfs] [105249.096661] [] xlog_assign_tail_lsn+0x28/0x60 [xfs] [105249.102696] [] xfs_log_release_iclog+0x11/0x40 [xfs] [105249.108805] [] xfs_iomap+0x4ba/0x510 [xfs] [105249.114039] [] xfs_map_blocks+0x43/0x90 [xfs] [105249.119520] [] xfs_page_state_convert+0x3e6/0x7f0 [xfs] [105249.125917] [] xfs_vm_writepage+0x61/0xf0 [xfs] [105249.131578] [] __writepage+0x8/0x30 [105249.136177] [] write_cache_pages+0x20f/0x300 [105249.141551] [] __writepage+0x0/0x30 [105249.146156] [] generic_writepages+0x20/0x30 [105249.151446] [] do_writepages+0x2b/0x50 [105249.156314] [] __filemap_fdatawrite_range+0x7a/0xa0 [105249.162315] [] filemap_fdatawrite+0x23/0x30 [105249.167594] [] do_fsync+0x4e/0xb0 [105249.172024] [] __do_fsync+0x25/0x40 [105249.176658] [] sysenter_past_esp+0x6b/0xa1 [105249.181844] ======================= # uname -a Linux st02 2.6.24-22-server #1 SMP Mon Nov 24 19:14:19 UTC 2008 i686 GNU/Linux # df -h Filesystem Size Used Avail Use% Mounted on /dev/sda1 487M 270M 217M 56% / varrun 2.0G 3.9M 2.0G 1% /var/run varlock 2.0G 0 2.0G 0% /var/lock udev 2.0G 100K 2.0G 1% /dev devshm 2.0G 0 2.0G 0% /dev/shm /dev/sda2 244M 90M 154M 37% /boot /dev/sda8 1.6G 33M 1.6G 3% /export /dev/mapper/backup-tmp 4.5G 33M 4.5G 1% /tmp /dev/sda6 3.9G 338M 3.5G 9% /usr /dev/sda7 3.9G 1.1G 2.8G 29% /var /dev/mapper/backup-vmbackup 4.0T 3.3T 749G 82% /vmbackup /dev/mapper/backup-filekeeper 1.5T 12G 1.5T 1% /filekeeper # xfs_info /vmbackup meta-data=/dev/mapper/backup-vmbackup isize=256 agcount=43, agsize=25165824 blks = sectsz=512 attr=1 data = bsize=4096 blocks=1073741824, imaxpct=25 = sunit=0 swidth=0 blks, unwritten=1 naming =version 2 bsize=4096 log =internal bsize=4096 blocks=32768, version=1 = sectsz=512 sunit=0 blks, lazy-count=0 realtime =none extsz=4096 blocks=0, rtextents=0 # tw_cli //st02> info Ctl Model Ports Drives Units NotOpt RRate VRate BBU ------------------------------------------------------------------------ c0 9650SE-16ML 16 16 1 0 4 4 OK //st02> /c0 show all /c0 Driver Version = 2.26.02.010 /c0 Model = 9650SE-16ML /c0 Memory Installed = 224MB /c0 Firmware Version = FE9X 3.06.00.003 /c0 Bios Version = BE9X 3.06.00.002 /c0 Monitor Version = BL9X 3.05.00.002 /c0 Serial Number = L322621A6510250 /c0 PCB Version = Rev 032 /c0 PCHIP Version = 2.00 /c0 ACHIP Version = 1.90 /c0 Number of Ports = 16 /c0 Number of Units = 1 /c0 Number of Drives = 16 /c0 Total Optimal Units = 1 /c0 Not Optimal Units = 0 /c0 JBOD Export Policy = off /c0 Disk Spinup Policy = 1 /c0 Spinup Stagger Time Policy (sec) = 1 /c0 Auto-Carving Policy = off /c0 Auto-Carving Size = 2048 GB /c0 Auto-Rebuild Policy = on /c0 Controller Bus Type = PCIE /c0 Controller Bus Width = 8 lanes /c0 Controller Bus Speed = 2.5 Ghz Unit UnitType Status %Cmpl Stripe Size(GB) Cache AVerify IgnECC ------------------------------------------------------------------------------ u0 RAID-5 OK - 64K 9778.74 ON OFF OFF Port Status Unit Size Blocks Serial --------------------------------------------------------------- p0 OK u0 698.63 GB 1465149168 3QD0WK3Z p1 OK u0 698.63 GB 1465149168 3QD0J9F6 p2 OK u0 698.63 GB 1465149168 3QD0E328 p3 OK u0 698.63 GB 1465149168 3QD0W4A5 p4 OK - 698.63 GB 1465149168 3QD0LGRD p5 OK u0 698.63 GB 1465149168 3QD0XPA9 p6 OK u0 698.63 GB 1465149168 3QD0JGC5 p7 OK u0 698.63 GB 1465149168 3QD0FHWE p8 OK u0 698.63 GB 1465149168 3QD0XR9E p9 OK u0 698.63 GB 1465149168 3QD0DB8H p10 OK u0 698.63 GB 1465149168 3QD0VYKF p11 OK u0 698.63 GB 1465149168 3QD0MRRD p12 OK u0 698.63 GB 1465149168 3QD0XL2M p13 OK u0 698.63 GB 1465149168 3QD0JGLM p14 OK u0 698.63 GB 1465149168 3QD0E978 p15 OK u0 698.63 GB 1465149168 3QD0L4KC Name OnlineState BBUReady Status Volt Temp Hours LastCapTest --------------------------------------------------------------------------- bbu On Yes OK OK OK 255 10-Aug-2007 -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Wed Jan 14 04:15:41 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0EAFfJu028574 for ; Wed, 14 Jan 2009 04:15:41 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n0EAFfn7028573; Wed, 14 Jan 2009 04:15:41 -0600 Date: Wed, 14 Jan 2009 04:15:41 -0600 Message-Id: <200901141015.n0EAFfn7028573@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 680] XFS_WANT_CORRUPTED_RETURN in xfs_alloc.c X-Bugzilla-Reason: AssignedTo X-Virus-Scanned: ClamAV 0.91.2/8863/Wed Jan 14 01:08:56 2009 on oss.sgi.com X-Virus-Status: Clean http://oss.sgi.com/bugzilla/show_bug.cgi?id=680 ------- Additional Comments From bgs@bgs.hu 2009-01-14 04:15 CST ------- Looks like the problem is somehow related to 3ware+xfs setups. Might be a good idea to confer with the 3ware devs. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From akpm@linux-foundation.org Wed Jan 14 15:38:20 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0ELcIIq000602 for ; Wed, 14 Jan 2009 15:38:20 -0600 X-ASG-Debug-ID: 1231969086-58b902820000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4BC5E8B923 for ; Wed, 14 Jan 2009 13:38:06 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id Ilk82j24w3QJL0tw for ; Wed, 14 Jan 2009 13:38:06 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0ELbYQX025691 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 14 Jan 2009 13:37:35 -0800 Received: from akpm.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id n0ELbXp8024050 for ; Wed, 14 Jan 2009 13:37:33 -0800 Date: Wed, 14 Jan 2009 13:37:33 -0800 From: Andrew Morton To: xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: [linux-dvb] compiling on 2.6.28 broken? Subject: Re: [linux-dvb] compiling on 2.6.28 broken? Message-Id: <20090114133733.bc5624f4.akpm@linux-foundation.org> In-Reply-To: <496E56EB.2030301@gmx.de> References: <20090112190420.51f75853@pedra.chehab.org> <20090112132130.6c932b85.akpm@linux-foundation.org> <20090112220624.4fbfee34@pedra.chehab.org> <20090112162337.318dd61d.akpm@linux-foundation.org> <20090113184755.87720@gmx.net> <20090113105947.9e774b69.akpm@linux-foundation.org> <20090113191757.74290@gmx.net> <20090113113700.776a94b5.akpm@linux-foundation.org> <20090113203843.GJ29283@parisc-linux.org> <1231957750.8269.28.camel@think.oraclecorp.com> <496E56EB.2030301@gmx.de> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1231969095 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15220 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8865/Wed Jan 14 11:37:08 2009 on oss.sgi.com X-Virus-Status: Clean On Wed, 14 Jan 2009 22:19:39 +0100 wk wrote: > From: wk > To: Chris Mason > CC: Matthew Wilcox , Andrew Morton , rjw@sisk.pl, HWerner4@gmx.de, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mchehab@infradead.org > Subject: Re: [linux-dvb] compiling on 2.6.28 broken? > Date: Wed, 14 Jan 2009 22:19:39 +0100 Guys, the above thread seems to point at an xfs-related regression. From akpm@linux-foundation.org Thu Jan 15 15:14:35 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0FLEXdt027772 for ; Thu, 15 Jan 2009 15:14:34 -0600 X-ASG-Debug-ID: 1232054068-06ae00a50000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 8283C914EA; Thu, 15 Jan 2009 13:14:29 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id gCEbOuQom3h3m27j; Thu, 15 Jan 2009 13:14:29 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0FLEB6v028037 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 15 Jan 2009 13:14:12 -0800 Received: from akpm.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id n0FLEBFR009286; Thu, 15 Jan 2009 13:14:11 -0800 Date: Thu, 15 Jan 2009 13:14:11 -0800 From: Andrew Morton To: Greg KH Cc: stable@kernel.org, Lachlan McIlroy , Christoph Hellwig , xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: [stable] [linux-dvb] compiling on 2.6.28 broken? Subject: Re: [stable] [linux-dvb] compiling on 2.6.28 broken? Message-Id: <20090115131411.4259538d.akpm@linux-foundation.org> In-Reply-To: <20090115210354.GA22973@kroah.com> References: <20090113184755.87720@gmx.net> <20090113105947.9e774b69.akpm@linux-foundation.org> <20090113191757.74290@gmx.net> <20090113113700.776a94b5.akpm@linux-foundation.org> <20090113203843.GJ29283@parisc-linux.org> <1231957750.8269.28.camel@think.oraclecorp.com> <496E56EB.2030301@gmx.de> <20090114223016.GY8071@disturbed> <496F9174.5080907@gmx.de> <20090115114745.59e9ca9d.akpm@linux-foundation.org> <20090115210354.GA22973@kroah.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232054072 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15296 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8869/Thu Jan 15 11:37:21 2009 on oss.sgi.com X-Virus-Status: Clean On Thu, 15 Jan 2009 13:03:54 -0800 Greg KH wrote: > On Thu, Jan 15, 2009 at 11:47:45AM -0800, Andrew Morton wrote: > > > > Guys, please check that the xfs people don't forget that > > 2.6.28.x need this: > > > > http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs.git;a=commit;h=15440319767942a363f282d6585303d3d75088ba > > Ah, thanks, I missed that this was commited to Linus's tree. > > I'll go add it to the .28 queue > Cool, thanks. (cc xfs people) Guys, pleeeeze don't forget to think about the backports! We really rely upon the originators and committers to choose which fixes are needed in earlier kernels, prevent things from falling through cracks. The appropriate and reliable way in which to do this is to add Cc: to the changelog. Then everything happens by magic :) From bugme-daemon@bugzilla.kernel.org Sat Jan 17 12:58:38 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_27, J_CHICKENPOX_43 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HIwbCb031659 for ; Sat, 17 Jan 2009 12:58:38 -0600 X-ASG-Debug-ID: 1232218714-408e009a0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D533A98AC7 for ; Sat, 17 Jan 2009 10:58:34 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id 2oDWiEnFEBkTZ1sM for ; Sat, 17 Jan 2009 10:58:34 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HIw0RE024204 for ; Sat, 17 Jan 2009 10:58:01 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id DB8E310800D; Sat, 17 Jan 2009 10:58:00 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] New: XFS : Corruption of in-memory data Subject: [Bug 12469] New: XFS : Corruption of in-memory data X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: Message-Id: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Date: Sat, 17 Jan 2009 10:58:00 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232218715 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.02 X-Barracuda-Spam-Status: No, SCORE=-1.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_SC1_TG172a, NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15448 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name 1.00 BSF_SC1_TG172a Custom Rule TG172a X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 Summary: XFS : Corruption of in-memory data Product: File System Version: 2.5 KernelVersion: 2.6.29-rc1 (20090116 last tested) Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: XFS AssignedTo: xfs-masters@oss.sgi.com ReportedBy: phreytaz@gmail.com Latest working kernel version: 2.6.28-rc8 Distribution: slackware current (20090116) Hardware Environment: Intel(R) Pentium(R) 4 CPU 2.66GHz on a ECS p4m800pro-m 2gb Software Envitonment: Gnu C 4.2.4 Gnu make 3.81 binutils 2.18.50.0.9.20080822 util-linux 2.12r mount 2.12r module-init-tools 3.5 e2fsprogs 1.41.3 jfsutils 1.1.12 reiserfsprogs 3.6.20 xfsprogs 2.10.1 Linux C Library 2.7 Dynamic linker (ldd) 2.7 Linux C++ Library 6.0.9 Procps 3.2.7 Net-tools 1.60 Kbd 1.12 Sh-utils 6.12 XFS memory corruption The problem occurs in kernels >= 2.6.28-rc8 last git kernel tested: 2.6.29-rc1 (20090116) simple and clean test: mkfs.xfs -b size=1024 /dev/sdb1 mount /dev/sdb1 /mnt/sdb1 -o rw,noatime,nodiratime create/copy a file and try "clear" the data [root@0x29A]# cp /opt/firefox/profile/urlclassifier3.sqlite /mnt/sdb1 ; sync ; cd /mnt/sdb1 ; sync [root@0x29A]# > urlclassifier3.sqlite XFS internal error XFS_WANT_CORRUPTED_GOTO at line 3327 of file fs/xfs/xfs_btree.c. Caller 0xc023884c Filesystem "sdb1": XFS internal error XFS_TRANS_CALCEL at line 1164 of file fs/xfs/xfs_trnas.c. Caller 0xc02637c9 Filesystem "sdb1": Corruption of in-memory data detected. Shutting down filesystem: sdb1 Please umount the filesystem ans rectify the problem(s) bash: urlclassifier3.sqlite : structure needs cleaning ---------------------------------------------------------- tested in more 2 hdds and in another computer (my old pMMX 233mhz/64mb, just for hardware sanity test =) on my lilo: append = "printk.time=1 noisapnp acpi=off irqpool" but with out this append the problem still occurs [root@0x29A]# xfs_info /dev/sdb1 meta-data=/dev/root isize=256 agcount=16, agsize=2509162 blks = sectsz=512 attr=0 data = bsize=1024 blocks=40146592, imaxpct=25 = sunit=0 swidth=0 blks naming =version 2 bsize=4096 ascii-ci=0 log =internal bsize=1024 blocks=19602, version=1 = sectsz=512 sunit=0 blks, lazy-count=0 realtime =none extsz=4096 blocks=0, rtextents=0 [root@0x29A]# cat /proc/cpuinfo processor : 0 vendor_id : GenuineIntel cpu family : 15 model : 4 model name : Intel(R) Pentium(R) 4 CPU 2.66GHz stepping : 9 cpu MHz : 2666.440 cache size : 1024 KB fdiv_bug : no hlt_bug : no f00f_bug : no coma_bug : no fpu : yes fpu_exception : yes cpuid level : 5 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe lm constant_tsc pebs bts pni dtes64 monitor ds_cpl tm2 cid cx16 xtpr bogomips : 5332.95 clflush size : 64 power management: [root@0x29A]# cat /proc/modules snd_pcm_oss 33056 1 - Live 0xf93d7000 snd_mixer_oss 12864 1 snd_pcm_oss, Live 0xf93c5000 ext2 44708 1 - Live 0xfa7a2000 apm 15092 1 - Live 0xfa766000 via 37728 2 - Live 0xfa743000 drm 74592 3 via, Live 0xfa701000 brd 5196 1 - Live 0xfa6ac000 snd_via82xx 21016 1 - Live 0xf864c000 gameport 9064 1 snd_via82xx, Live 0xf8637000 snd_ac97_codec 95908 1 snd_via82xx, Live 0xf8610000 ac97_bus 1312 1 snd_ac97_codec, Live 0xf85e5000 snd_pcm 54632 3 snd_pcm_oss,snd_via82xx,snd_ac97_codec, Live 0xf85cf000 snd_timer 17252 1 snd_pcm, Live 0xf85b3000 snd_page_alloc 7624 2 snd_via82xx,snd_pcm, Live 0xf85a4000 snd_mpu401_uart 5696 1 snd_via82xx, Live 0xf859b000 snd_rawmidi 17248 1 snd_mpu401_uart, Live 0xf8580000 snd_seq_device 5836 1 snd_rawmidi, Live 0xf8541000 via_agp 7744 1 - Live 0xf8594000 uhci_hcd 20364 0 - Live 0xf8569000 snd 43140 9 snd_pcm_oss,snd_mixer_oss,snd_via82xx,snd_ac97_codec,snd_pcm,snd_timer,snd_mpu401_uart,snd_rawmidi,snd_seq_device, Live 0xf854c000 agpgart 27504 2 drm,via_agp, Live 0xf8524000 ehci_hcd 31628 0 - Live 0xf8508000 via_rhine 19880 0 - Live 0xf8acd000 mii 4256 1 via_rhine, Live 0xf8ab8000 shpchp 29364 0 - Live 0xf8aa7000 i2c_viapro 7476 0 - Live 0xf8a94000 psmouse 39408 0 - Live 0xf8a58000 soundcore 5120 2 snd, Live 0xf8a43000 rtc_cmos 8460 0 - Live 0xf8a27000 pci_hotplug 11432 1 shpchp, Live 0xf8a1a000 usbcore 118128 3 uhci_hcd,ehci_hcd, Live 0xf895a000 rtc_core 13496 1 rtc_cmos, Live 0xf8920000 i2c_core 19408 1 i2c_viapro, Live 0xf890b000 rtc_lib 2240 1 rtc_core, Live 0xf88f4000 serio_raw 4612 0 - Live 0xf88ea000 evdev 8352 0 - Live 0xf88ce000 sg 22512 0 - Live 0xf88a8000 -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 13:18:43 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HJIgno000378 for ; Sat, 17 Jan 2009 13:18:43 -0600 X-ASG-Debug-ID: 1232219920-434a00e60000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id BCA9198B7C for ; Sat, 17 Jan 2009 11:18:41 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id 4s1ugvFk7qWPsHcl for ; Sat, 17 Jan 2009 11:18:41 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HJIAqq025289 for ; Sat, 17 Jan 2009 11:18:11 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id E361E10800F; Sat, 17 Jan 2009 11:18:09 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117191809.E361E10800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 11:18:09 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232219921 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15448 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 akpm@osdl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Regression|0 |1 -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From akpm@linux-foundation.org Sat Jan 17 13:19:42 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HJJf2L000443 for ; Sat, 17 Jan 2009 13:19:42 -0600 X-ASG-Debug-ID: 1232219979-2ffd024d0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 78B629894E for ; Sat, 17 Jan 2009 11:19:40 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id 4VJyeHEBQoYQc9uy for ; Sat, 17 Jan 2009 11:19:40 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HJJ6eG025342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 17 Jan 2009 11:19:07 -0800 Received: from sony (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id n0HJJ58X030340; Sat, 17 Jan 2009 11:19:06 -0800 Date: Sat, 17 Jan 2009 11:19:01 -0800 From: Andrew Morton To: "Rafael J. Wysocki" Cc: xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: [Bugme-new] [Bug 12469] New: XFS : Corruption of in-memory data Subject: Re: [Bugme-new] [Bug 12469] New: XFS : Corruption of in-memory data Message-Id: <20090117111901.b474d532.akpm@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.19; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232219980 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15448 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean > On Sat, 17 Jan 2009 10:58:00 -0800 (PST) bugme-daemon@bugzilla.kernel.org wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=12469 a post-2.6.28 regression. From sandeen@sandeen.net Sat Jan 17 13:34:07 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HJY6Sf001153 for ; Sat, 17 Jan 2009 13:34:07 -0600 X-ASG-Debug-ID: 1232220845-2ffd02dd0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.sandeen.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6079298BEC for ; Sat, 17 Jan 2009 11:34:05 -0800 (PST) Received: from mail.sandeen.net (sandeen.net [209.173.210.139]) by cuda.sgi.com with ESMTP id I3Est1lRbjUFTFJD for ; Sat, 17 Jan 2009 11:34:05 -0800 (PST) Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sandeen.net (Postfix) with ESMTP id D85289F59B2; Sat, 17 Jan 2009 13:33:31 -0600 (CST) Message-ID: <4972328B.2010301@sandeen.net> Date: Sat, 17 Jan 2009 13:33:31 -0600 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: Andrew Morton CC: "Rafael J. Wysocki" , xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: [xfs-masters] [Bugme-new] [Bug 12469] New: XFS : Corruption of in-memory data Subject: Re: [xfs-masters] [Bugme-new] [Bug 12469] New: XFS : Corruption of in-memory data References: <20090117111901.b474d532.akpm@linux-foundation.org> In-Reply-To: <20090117111901.b474d532.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: sandeen.net[209.173.210.139] X-Barracuda-Start-Time: 1232220845 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15450 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean Andrew Morton wrote: >> On Sat, 17 Jan 2009 10:58:00 -0800 (PST) bugme-daemon@bugzilla.kernel.org wrote: >> http://bugzilla.kernel.org/show_bug.cgi?id=12469 > > a post-2.6.28 regression. > others have reported similar on the xfs lists, likely a result of btree rework that went in post-.28 dgc & hch are both looking at it ... -Eric From bugme-daemon@bugzilla.kernel.org Sat Jan 17 15:00:21 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HL0KVA005348 for ; Sat, 17 Jan 2009 15:00:21 -0600 X-ASG-Debug-ID: 1232226018-06ca020a0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 9CE9F98D32 for ; Sat, 17 Jan 2009 13:00:19 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id chSl2FEnRY292wKl for ; Sat, 17 Jan 2009 13:00:19 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HKxjXY031494 for ; Sat, 17 Jan 2009 12:59:46 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id E44EB10800F; Sat, 17 Jan 2009 12:59:44 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117205944.E44EB10800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 12:59:44 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232226019 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15455 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #1 from sandeen@redhat.com 2009-01-17 12:59 ------- So your reproducer steps hit it every time? That'd be awesome. I'll go test it (though I only have x86_64 to do so...) Could you attach the file /opt/firefox/profile/urlclassifier3.sqlite to the bug please? -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 15:02:44 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HL2i9v005479 for ; Sat, 17 Jan 2009 15:02:44 -0600 X-ASG-Debug-ID: 1232226163-151201140000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B457498D42 for ; Sat, 17 Jan 2009 13:02:43 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id BkP81Fygpb7fLRz3 for ; Sat, 17 Jan 2009 13:02:43 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HL2DNT031682 for ; Sat, 17 Jan 2009 13:02:14 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id CF20610800F; Sat, 17 Jan 2009 13:02:13 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117210213.CF20610800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 13:02:13 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232226163 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15455 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #2 from sandeen@redhat.com 2009-01-17 13:02 ------- Oh, of course we don't need that file itself :) But can you please provide info on exactly how large it is (ls -l) -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 15:50:47 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HLogMR008320 for ; Sat, 17 Jan 2009 15:50:47 -0600 X-ASG-Debug-ID: 1232229040-0ba203770000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A7CAF99065 for ; Sat, 17 Jan 2009 13:50:40 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id khWHI1XsTGpvy0ol for ; Sat, 17 Jan 2009 13:50:40 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HLo8bx002032 for ; Sat, 17 Jan 2009 13:50:09 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id A916D108040; Sat, 17 Jan 2009 13:50:08 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117215008.A916D108040@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 13:50:08 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232229040 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15458 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #3 from sandeen@redhat.com 2009-01-17 13:50 ------- One other thing, can you confirm that the xfs_info geometry shown is that which is failing? I'm a little confused because xfsprogs 2.10.1 with "mkfs.xfs -b size=1024" should not have those defaults (attr=0, logver=0, agcount=16) -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 16:02:45 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HM2jP4010174 for ; Sat, 17 Jan 2009 16:02:45 -0600 X-ASG-Debug-ID: 1232229763-151b03460000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2F967990A1 for ; Sat, 17 Jan 2009 14:02:43 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id 8vd6DRxsDdH1eBLI for ; Sat, 17 Jan 2009 14:02:43 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HM1tZJ002905 for ; Sat, 17 Jan 2009 14:01:56 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 966F910800F; Sat, 17 Jan 2009 14:01:55 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117220155.966F910800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 14:01:55 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232229764 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15458 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #4 from sandeen@redhat.com 2009-01-17 14:01 ------- and still one more thing :) If the source sqlite file is on xfs, can you paste the results of xfs_bmap -v for it? And also xfs_bmap -v of the file after you copy it to your test fs and sync it? Thanks, -Eric -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 16:13:55 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_24 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HMDrwM011948 for ; Sat, 17 Jan 2009 16:13:55 -0600 X-ASG-Debug-ID: 1232230431-5408002b0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 132DA990CC for ; Sat, 17 Jan 2009 14:13:51 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id ZbcCHikFOP9FaxM5 for ; Sat, 17 Jan 2009 14:13:51 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HMDnUZ003927 for ; Sat, 17 Jan 2009 14:13:50 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id B8FBE10800F; Sat, 17 Jan 2009 14:13:49 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117221349.B8FBE10800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 14:13:49 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232230432 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15458 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #5 from phreytaz@gmail.com 2009-01-17 14:13 ------- (In reply to comment #1) > So your reproducer steps hit it every time? That'd be awesome. > > I'll go test it (though I only have x86_64 to do so...) > > Could you attach the file /opt/firefox/profile/urlclassifier3.sqlite to the bug > please? > hi Eric on very first time, i was dumped the audio from a .mkv file after boot with the new kernel (heavily r/w) occurs randomly, when i copy/move a "big" file (~100mb) to a XFS fs... but, if i "zeroes" a file (1mb bigger) the XFS screw up more frequently... (9/10 times) # > bzImage, crash (my 1.9mb kernel img) # dd if=/dev/zero of=file bs=10M count=1 ; sync ; > file , crash # > /etc/fstab , does not crash (~500 bytes) # dd if=/dev/zero of=file bs=64K count=1 ; sync ; > file , does not crash -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 16:16:42 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HMGgqZ012783 for ; Sat, 17 Jan 2009 16:16:42 -0600 X-ASG-Debug-ID: 1232230601-5408003e0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C070899178 for ; Sat, 17 Jan 2009 14:16:41 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id K7PO2sXMPlR5DaRl for ; Sat, 17 Jan 2009 14:16:41 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HMGAVc004319 for ; Sat, 17 Jan 2009 14:16:11 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 37FAE10800F; Sat, 17 Jan 2009 14:16:09 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117221610.37FAE10800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 14:16:10 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232230601 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15458 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #6 from phreytaz@gmail.com 2009-01-17 14:16 ------- (In reply to comment #2) > Oh, of course we don't need that file itself :) But can you please provide > info on exactly how large it is (ls -l) > -rw-r--r-- 1 root root 15765504 2009-01-17 20:17 /opt/firefox/profile/urlclassifier3.sqlite -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 16:19:42 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HMJgNh012945 for ; Sat, 17 Jan 2009 16:19:42 -0600 X-ASG-Debug-ID: 1232230780-540800530000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 49783990F8 for ; Sat, 17 Jan 2009 14:19:40 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id 25bhr31Jb30fHj3P for ; Sat, 17 Jan 2009 14:19:40 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HMItST004600 for ; Sat, 17 Jan 2009 14:18:56 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id D61BF10800F; Sat, 17 Jan 2009 14:18:55 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117221855.D61BF10800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 14:18:55 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232230781 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15458 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #7 from phreytaz@gmail.com 2009-01-17 14:18 ------- (In reply to comment #3) > One other thing, can you confirm that the xfs_info geometry shown is that which > is failing? I'm a little confused because xfsprogs 2.10.1 with "mkfs.xfs -b > size=1024" should not have those defaults (attr=0, logver=0, agcount=16) > [root@0x29A]# xfs_info /dev/sdb1 meta-data=/dev/root isize=256 agcount=16, agsize=2509162 blks = sectsz=512 attr=0 data = bsize=1024 blocks=40146592, imaxpct=25 = sunit=0 swidth=0 blks naming =version 2 bsize=4096 ascii-ci=0 log =internal bsize=1024 blocks=19602, version=1 = sectsz=512 sunit=0 blks, lazy-count=0 realtime =none extsz=4096 blocks=0, rtextents=0 i use only -b size=1024, no other arg -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 16:22:34 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HMMYhF013073 for ; Sat, 17 Jan 2009 16:22:34 -0600 X-ASG-Debug-ID: 1232230952-151203b70000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 3EE6C99062 for ; Sat, 17 Jan 2009 14:22:32 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id fsOhnLr00fhMu0V2 for ; Sat, 17 Jan 2009 14:22:32 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HMLfCL004835 for ; Sat, 17 Jan 2009 14:21:42 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 990F610800F; Sat, 17 Jan 2009 14:21:41 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117222141.990F610800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 14:21:41 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232230953 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15460 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #8 from phreytaz@gmail.com 2009-01-17 14:21 ------- (In reply to comment #4) > and still one more thing :) > > If the source sqlite file is on xfs, can you paste the results of xfs_bmap -v > for it? > > And also xfs_bmap -v of the file after you copy it to your test fs and sync it? > > Thanks, > -Eric > [root@0x29A]# xfs_bmap -v urlclassifier3.sqlite urlclassifier3.sqlite: EXT: FILE-OFFSET BLOCK-RANGE AG AG-OFFSET TOTAL 0: [0..31039]: 24796346..24827385 4 (4723050..4754089) 31040 -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 16:30:30 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HMUU7X013453 for ; Sat, 17 Jan 2009 16:30:30 -0600 X-ASG-Debug-ID: 1232231428-151a03c20000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DDAAC98E8A for ; Sat, 17 Jan 2009 14:30:28 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id dIaI9CyidAaW4IIe for ; Sat, 17 Jan 2009 14:30:28 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HMTwGe005496 for ; Sat, 17 Jan 2009 14:29:59 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 5D3A1108042; Sat, 17 Jan 2009 14:29:58 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117222958.5D3A1108042@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 14:29:58 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232231428 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15460 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #9 from phreytaz@gmail.com 2009-01-17 14:29 ------- (In reply to comment #8) > (In reply to comment #4) > > and still one more thing :) > > > > If the source sqlite file is on xfs, can you paste the results of xfs_bmap -v > > for it? > > > > And also xfs_bmap -v of the file after you copy it to your test fs and sync it? > > > > Thanks, > > -Eric > > > before: [root@0x29A]# xfs_bmap -v urlclassifier3.sqlite urlclassifier3.sqlite: EXT: FILE-OFFSET BLOCK-RANGE AG AG-OFFSET TOTAL 0: [0..1727]: 2835266..2836993 0 (2835266..2836993) 1728 1: [1728..4999]: 2597070..2600341 0 (2597070..2600341) 3272 2: [5000..6455]: 2595614..2597069 0 (2595614..2597069) 1456 3: [6456..8791]: 2593278..2595613 0 (2593278..2595613) 2336 4: [8792..11343]: 2590726..2593277 0 (2590726..2593277) 2552 5: [11344..12151]: 3459672..3460479 0 (3459672..3460479) 808 6: [12152..14047]: 3461146..3463041 0 (3461146..3463041) 1896 7: [14048..15167]: 3467366..3468485 0 (3467366..3468485) 1120 8: [15168..16927]: 3469670..3471429 0 (3469670..3471429) 1760 9: [16928..17839]: 3474238..3475149 0 (3474238..3475149) 912 10: [17840..19231]: 3477534..3478925 0 (3477534..3478925) 1392 11: [19232..19679]: 3480350..3480797 0 (3480350..3480797) 448 12: [19680..20607]: 3486738..3487665 0 (3486738..3487665) 928 13: [20608..21615]: 3708944..3709951 0 (3708944..3709951) 1008 14: [21616..24367]: 4253798..4256549 0 (4253798..4256549) 2752 15: [24368..27215]: 4256972..4259819 0 (4256972..4259819) 2848 16: [27216..29535]: 4262584..4264903 0 (4262584..4264903) 2320 17: [29536..29687]: 4266048..4266199 0 (4266048..4266199) 152 18: [29688..30319]: 4272432..4273063 0 (4272432..4273063) 632 19: [30320..30791]: 4273532..4274003 0 (4273532..4274003) 472 20: [30792..31039]: 5717636..5717883 1 (699312..699559) 248 after: [root@0x29A]# xfs_bmap -v urlclassifier3.sqlite urlclassifier3.sqlite: EXT: FILE-OFFSET BLOCK-RANGE AG AG-OFFSET TOTAL 0: [0..31039]: 24796346..24827385 4 (4723050..4754089) 31040 -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 16:31:53 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_27, J_CHICKENPOX_42,J_CHICKENPOX_43 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HMVqsY013539 for ; Sat, 17 Jan 2009 16:31:53 -0600 X-ASG-Debug-ID: 1232231511-31f302490000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A40E398E97 for ; Sat, 17 Jan 2009 14:31:51 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id bsAKHYHw6hUG0ZiW for ; Sat, 17 Jan 2009 14:31:51 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HMVHZo005679 for ; Sat, 17 Jan 2009 14:31:18 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id B6E3A10800F; Sat, 17 Jan 2009 14:31:17 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117223117.B6E3A10800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 14:31:17 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232231511 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15460 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #10 from sandeen@redhat.com 2009-01-17 14:31 ------- Does this reproduce it for you, then? doesn't for me, unfortunately: mkdir mnt mkfs.xfs -b size=1024 -d file,name=fsfile,size=40146592b,agcount=16 -i attr=0 -l version=1 dd if=/dev/zero bs=1 count=1 seek=15765503 of=bigfile mount -o loop,rw,noatime,nodiratime fsfile mnt/ cp --sparse=never bigfile mnt/ sync cd mnt sync > bigfile cd .. dmesg | grep CORRUPTED -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sat Jan 17 16:51:35 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0HMpYiX014818 for ; Sat, 17 Jan 2009 16:51:35 -0600 X-ASG-Debug-ID: 1232232691-64a800f10000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 62BEC991A0 for ; Sat, 17 Jan 2009 14:51:31 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id X2EJN1GoeScTKvDF for ; Sat, 17 Jan 2009 14:51:31 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0HMp19R007310 for ; Sat, 17 Jan 2009 14:51:02 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 87DF310800F; Sat, 17 Jan 2009 14:51:01 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090117225101.87DF310800F@picon.linux-foundation.org> Date: Sat, 17 Jan 2009 14:51:01 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232232692 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15462 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8873/Fri Jan 16 21:33:31 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #11 from sandeen@redhat.com 2009-01-17 14:51 ------- One more thing to try for a reproducer if the above doesn't work. mkfs, populate, sync as shown in the original comment. unmount make an xfs_metadump image of the device xfs_mdrestore back to the device mount the device with your mount options do the "> testfile" test does that reproduce it? if so, please provide the xfs_metadump image. if you need a hand with these steps, please let me know. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Sun Jan 18 15:24:07 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_43 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0ILO7SA028823 for ; Sun, 18 Jan 2009 15:24:07 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.12.11.20060308/8.12.11/Submit) id n0ILO7Dp028821; Sun, 18 Jan 2009 15:24:07 -0600 Date: Sun, 18 Jan 2009 15:24:07 -0600 Message-Id: <200901182124.n0ILO7Dp028821@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 806] mkfs.xfs or xfs_repair problem with small filesystems X-Bugzilla-Reason: AssignedTo X-Virus-Scanned: ClamAV 0.91.2/8874/Sat Jan 17 23:02:00 2009 on oss.sgi.com X-Virus-Status: Clean http://oss.sgi.com/bugzilla/show_bug.cgi?id=806 hch@xfs.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Additional Comments From hch@xfs.org 2009-01-18 15:24 CST ------- I've put in a fix to allow repairing these single allocation group filesystems: http://git.kernel.org/?p=fs/xfs/xfsprogs-dev.git;a=commitdiff;h=d4dd6ab5c60449b4e05f5c591ce698e4c94ddbb3 -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 18 15:32:42 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0ILWfsa029273 for ; Sun, 18 Jan 2009 15:32:42 -0600 X-ASG-Debug-ID: 1232314357-108000af0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 195AE9AE4E for ; Sun, 18 Jan 2009 13:32:37 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id xyETVDDhF63PrpsG for ; Sun, 18 Jan 2009 13:32:37 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0ILWXG3002993 for ; Sun, 18 Jan 2009 13:32:34 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 8E64F10800F; Sun, 18 Jan 2009 13:32:33 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090118213233.8E64F10800F@picon.linux-foundation.org> Date: Sun, 18 Jan 2009 13:32:33 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232314359 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15543 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8874/Sat Jan 17 23:02:00 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #12 from sandeen@redhat.com 2009-01-18 13:32 ------- another thing could you attach your mkfs binary? It may help us reproduce, since you seem to have something ... unique. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 18 21:35:31 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0J3ZSdO024921 for ; Sun, 18 Jan 2009 21:35:30 -0600 X-ASG-Debug-ID: 1232336125-63aa01b20000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DD61F9B80E for ; Sun, 18 Jan 2009 19:35:25 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id i1DqIGdvmZBULm8k for ; Sun, 18 Jan 2009 19:35:25 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0J3ZNFA026051 for ; Sun, 18 Jan 2009 19:35:24 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 433F210800F; Sun, 18 Jan 2009 19:35:23 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090119033523.433F210800F@picon.linux-foundation.org> Date: Sun, 18 Jan 2009 19:35:23 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232336126 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15563 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8875/Sun Jan 18 18:02:33 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #13 from david@fromorbit.com 2009-01-18 19:35 ------- Eric, your test won't reproduce because it doesn't fragment sufficiently. can I suggest using xfs_io to write each extent in reverse order (i.e. write the file backwards) synchronously using direct IO to get the file written out into 20 extents before nulling it.... -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 18 21:37:17 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0J3bHUf025028 for ; Sun, 18 Jan 2009 21:37:17 -0600 X-ASG-Debug-ID: 1232336235-796c01670000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DE20D9B81B for ; Sun, 18 Jan 2009 19:37:15 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id E2oFewUX3f0V7yPs for ; Sun, 18 Jan 2009 19:37:15 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0J3bDJ4026266 for ; Sun, 18 Jan 2009 19:37:14 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 0608510800F; Sun, 18 Jan 2009 19:37:12 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090119033713.0608510800F@picon.linux-foundation.org> Date: Sun, 18 Jan 2009 19:37:12 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232336235 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15563 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8875/Sun Jan 18 18:02:33 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #14 from sandeen@redhat.com 2009-01-18 19:37 ------- Dave, according to comment #9, the file on the filesystem in question has a single extent (although the source was fragmented). -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 18 21:52:46 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0J3qjS6026119 for ; Sun, 18 Jan 2009 21:52:46 -0600 X-ASG-Debug-ID: 1232337163-796b01a50000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A862A9BB8F for ; Sun, 18 Jan 2009 19:52:44 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id 5QQlnV7RDArU0Qwz for ; Sun, 18 Jan 2009 19:52:44 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0J3qgKx027255 for ; Sun, 18 Jan 2009 19:52:43 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 7774410800F; Sun, 18 Jan 2009 19:52:42 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090119035242.7774410800F@picon.linux-foundation.org> Date: Sun, 18 Jan 2009 19:52:42 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232337164 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15565 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8875/Sun Jan 18 18:02:33 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #15 from felixb@sgi.com 2009-01-18 19:52 ------- It doesn't seem that multiextent file is the only condition for the bug. I created 100M file with 72K+ extents and no corruption. cxfsopus16 6# l /xfstest/file1 -rw-r--r-- 1 root root 104857600 2009-01-17 16:56 /xfstest/file1 cxfsopus16 7# xfs_bmap -v /xfstest/file1 | wc 72802 436807 5086085 cxfsopus16 8# -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 18 22:11:32 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0J4BV6v027887 for ; Sun, 18 Jan 2009 22:11:32 -0600 X-ASG-Debug-ID: 1232338289-63a9027a0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id BA6C09BACD for ; Sun, 18 Jan 2009 20:11:30 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id jQbk2JCXwSNUWRXn for ; Sun, 18 Jan 2009 20:11:30 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0J4BSYQ028504 for ; Sun, 18 Jan 2009 20:11:29 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 19F3910800F; Sun, 18 Jan 2009 20:11:28 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090119041128.19F3910800F@picon.linux-foundation.org> Date: Sun, 18 Jan 2009 20:11:28 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232338290 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15565 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV 0.91.2/8875/Sun Jan 18 18:02:33 2009 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 ------- Comment #16 from david@fromorbit.com 2009-01-18 20:11 ------- Out of curiousity, so we can see what btree operations are actually happening on your machine, can you dump /proc/fs/xfs/stats and post it? Eric, i can't reproduce it with the xfs_io trick - I've produced an identical block map and it doesn't corrupt when overwriting it. Also, "> to_a_file" leaves me with a zero length file with new extents, not file full of zeroed blocks.... -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Mon Jan 19 10:45:23 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0JGjMxS009662 for ; Mon, 19 Jan 2009 10:45:23 -0600 X-ASG-Debug-ID: 1232383520-08e900b50000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DDCDEC12577 for ; Mon, 19 Jan 2009 08:45:20 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id xhIw8rooGCzoS9C2 for ; Mon, 19 Jan 2009 08:45:20 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0JGijQq013717 for ; Mon, 19 Jan 2009 08:44:47 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id E1BCB108040; Mon, 19 Jan 2009 08:44:45 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090119164445.E1BCB108040@picon.linux-foundation.org> Date: Mon, 19 Jan 2009 08:44:45 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232383520 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15606 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name http://bugzilla.kernel.org/show_bug.cgi?id=12469 rjw@sisk.pl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rjw@sisk.pl OtherBugsDependingO| |12398 nThis| | -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From a.beregalov@gmail.com Tue Jan 20 13:26:37 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,J_CHICKENPOX_23 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0KJQas0010463 for ; Tue, 20 Jan 2009 13:26:37 -0600 X-ASG-Debug-ID: 1232479595-0af200fd0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from yw-out-1718.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1D867182B033 for ; Tue, 20 Jan 2009 11:26:35 -0800 (PST) Received: from yw-out-1718.google.com (yw-out-1718.google.com [74.125.46.152]) by cuda.sgi.com with ESMTP id 3VceDGU7ScJa5YiQ for ; Tue, 20 Jan 2009 11:26:35 -0800 (PST) Received: by yw-out-1718.google.com with SMTP id 5so1329885ywm.32 for ; Tue, 20 Jan 2009 11:26:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=fAyEZehKhoKbAG+OfYYaQ5RW9zGG+6E8mDXXevUnQRE=; b=kPyXnSapotCNjOC3RFefGNBG0Ohb6SiRg8Xm7/rdkbB1qA2Mv3WEOas5Xjedcgq3vI 2b8JfEDCuwL7VoSlghhxvS0JKVOEynDRy4XAZ47e/soRXSLqg/0ZGr2rKTGinKZ5xN+i CANWyVLTKCTX4gGn9paI/6aDwfRPQK9v17y+E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=vuZ3EcT4JvLaTmyoVldaLvstQSNLXiXtAapwwD7BGsFTSm3jqCNnM074yfxzbOactn yUg9Hdan4Ovc2omMfEwwZPMHQ7udbLplDc5wAZUvuP23q4hdBmSNoQWwr1f9M7NkoJ3w 4hN4W6qMkDITMjLhtdXTTDsoyb9FuBCbAceBw= MIME-Version: 1.0 Received: by 10.100.132.14 with SMTP id f14mr5047890and.107.1232477684585; Tue, 20 Jan 2009 10:54:44 -0800 (PST) In-Reply-To: <20090112211848.GL8071@disturbed> References: <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> <20090112034550.GI8071@disturbed> <20090112211848.GL8071@disturbed> Date: Tue, 20 Jan 2009 21:54:44 +0300 Message-ID: X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 From: Alexander Beregalov To: Dave Chinner , Christoph Hellwig , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: yw-out-1718.google.com[74.125.46.152] X-Barracuda-Start-Time: 1232479596 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15693 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on oss.sgi.com X-Virus-Status: Clean Hi Is it a new bug? It is pre-2.6.29-rc1 kernel, which was supossed to be free of the bug "fs_is_ok, file: fs/xfs/xfs_btree.c, line: 3327" Assertion failed: fsbno != NULLFSBLOCK, file: fs/xfs/xfs_btree.c, line: 816 ------------[ cut here ]------------ kernel BUG at fs/xfs/support/debug.c:81! invalid opcode: 0000 [#1] PREEMPT DEBUG_PAGEALLOC last sysfs file: /sys/devices/platform/w83627hf.656/name Modules linked in: w83627hf hwmon_vid i2c_nforce2 Pid: 10156, comm: pdflush Not tainted (2.6.28-rc2-00207-g278d0ca #5) EIP: 0060:[] EFLAGS: 00010282 CPU: 0 EIP is at assfail+0x1e/0x30 EAX: 0000005f EBX: f7325a10 ECX: d3a24000 EDX: 00000000 ESI: ffffffff EDI: 00000001 EBP: d3a25880 ESP: d3a25870 DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068 Process pdflush (pid: 10156, ti=d3a24000 task=f6223cf0 task.ti=d3a24000) Stack: c04d6c04 c04b6a80 c04b6da8 00000330 d3a2589c c024c01e f6aca408 00cc8bc4 00000001 ffffffff 00000001 d3a258b4 c024c0e5 f0a45000 f0a45000 00000000 00000001 d3a258cc c024c161 00000003 d3a25a04 f0a45000 f0a45000 d3a2590c Call Trace: [] ? xfs_btree_reada_bufl+0x2e/0x80 [] ? xfs_btree_readahead_lblock+0x75/0x80 [] ? xfs_btree_readahead+0x71/0x90 [] ? xfs_btree_decrement+0x3c/0x2e0 [] ? xfs_bmbt_delete+0x2c/0xa0 [] ? xfs_bmap_add_extent_delay_real+0x1674/0x1700 [] ? _spin_unlock+0x27/0x50 [] ? xfs_alloc_search_busy+0x8b/0xd0 [] ? slab_pad_check+0x3c/0x120 [] ? xfs_alloc_vextent+0x2e9/0x760 [] ? check_object+0x13d/0x200 [] ? xfs_bmap_add_extent+0x626/0x670 [] ? xfs_bmbt_init_cursor+0x2c/0x100 [] ? xfs_bmapi+0xfcb/0x1c90 [] ? check_object+0x13d/0x200 [] ? xfs_iomap_write_allocate+0x254/0x450 [] ? xfs_iomap+0x3a7/0x3f0 [] ? submit_bio+0x66/0x100 [] ? xfs_map_blocks+0x3e/0x90 [] ? xfs_page_state_convert+0x2ea/0x740 [] ? xfs_vm_writepage+0x5e/0xf0 [] ? __writepage+0xb/0x40 [] ? write_cache_pages+0x1f1/0x330 [] ? __writepage+0x0/0x40 [] ? generic_writepages+0x23/0x30 [] ? xfs_vm_writepages+0x43/0x50 [] ? xfs_vm_writepages+0x0/0x50 [] ? do_writepages+0x2e/0x50 [] ? __writeback_single_inode+0x82/0x320 [] ? _spin_lock+0x63/0x70 [] ? generic_sync_sb_inodes+0x23a/0x320 [] ? writeback_inodes+0x56/0xe0 [] ? wb_kupdate+0x7b/0xf0 [] ? pdflush+0x0/0x180 [] ? pdflush+0xc0/0x180 [] ? wb_kupdate+0x0/0xf0 [] ? kthread+0x3a/0x70 [] ? kthread+0x0/0x70 [] ? kernel_thread_helper+0x7/0x10 Code: 00 e8 97 73 02 00 c9 c3 90 8d 74 26 00 55 89 e5 83 ec 10 89 4c 24 0c 89 54 24 08 89 44 24 04 c7 04 24 04 6c 4d c0 e8 fb de 16 00 <0f> 0b eb fe 8d b4 26 00 00 00 00 8d bc 27 00 00 00 00 55 89 e5 EIP: [] assfail+0x1e/0x30 SS:ESP 0068:d3a25870 From sandeen@sandeen.net Tue Jan 20 14:01:58 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,J_CHICKENPOX_23 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0KK1vnq012071 for ; Tue, 20 Jan 2009 14:01:57 -0600 X-ASG-Debug-ID: 1232481715-0b33016e0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx2.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B7765182ABF7; Tue, 20 Jan 2009 12:01:55 -0800 (PST) Received: from mx2.redhat.com (mx2.redhat.com [66.187.237.31]) by cuda.sgi.com with ESMTP id l4uEjtM0w4uidjC8; Tue, 20 Jan 2009 12:01:55 -0800 (PST) Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0KJXGai009882; Tue, 20 Jan 2009 14:33:16 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n0KJXGsn018611; Tue, 20 Jan 2009 14:33:16 -0500 Received: from neon.msp.redhat.com (neon.msp.redhat.com [10.15.80.10]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n0KJXE8n030041; Tue, 20 Jan 2009 14:33:15 -0500 Message-ID: <497626F9.2080605@sandeen.net> Date: Tue, 20 Jan 2009 13:33:13 -0600 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Alexander Beregalov CC: Dave Chinner , Christoph Hellwig , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 References: <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> <20090112034550.GI8071@disturbed> <20090112211848.GL8071@disturbed> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-Barracuda-Connect: mx2.redhat.com[66.187.237.31] X-Barracuda-Start-Time: 1232481716 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15694 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on oss.sgi.com X-Virus-Status: Clean Alexander Beregalov wrote: > Hi > > Is it a new bug? > It is pre-2.6.29-rc1 kernel, which was supossed to be free of the bug > "fs_is_ok, file: fs/xfs/xfs_btree.c, line: 3327" Do you have CONFIG_LBD on, and if not, can you enable it and retest? hch narrowed a btree bug down to this... -Eric > Assertion failed: fsbno != NULLFSBLOCK, file: fs/xfs/xfs_btree.c, line: 816 > ------------[ cut here ]------------ > kernel BUG at fs/xfs/support/debug.c:81! > invalid opcode: 0000 [#1] PREEMPT DEBUG_PAGEALLOC > last sysfs file: /sys/devices/platform/w83627hf.656/name > Modules linked in: w83627hf hwmon_vid i2c_nforce2 > > Pid: 10156, comm: pdflush Not tainted (2.6.28-rc2-00207-g278d0ca #5) > EIP: 0060:[] EFLAGS: 00010282 CPU: 0 > EIP is at assfail+0x1e/0x30 > EAX: 0000005f EBX: f7325a10 ECX: d3a24000 EDX: 00000000 > ESI: ffffffff EDI: 00000001 EBP: d3a25880 ESP: d3a25870 > DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068 > Process pdflush (pid: 10156, ti=d3a24000 task=f6223cf0 task.ti=d3a24000) > Stack: > c04d6c04 c04b6a80 c04b6da8 00000330 d3a2589c c024c01e f6aca408 00cc8bc4 > 00000001 ffffffff 00000001 d3a258b4 c024c0e5 f0a45000 f0a45000 00000000 > 00000001 d3a258cc c024c161 00000003 d3a25a04 f0a45000 f0a45000 d3a2590c > Call Trace: > [] ? xfs_btree_reada_bufl+0x2e/0x80 > [] ? xfs_btree_readahead_lblock+0x75/0x80 > [] ? xfs_btree_readahead+0x71/0x90 > [] ? xfs_btree_decrement+0x3c/0x2e0 > [] ? xfs_bmbt_delete+0x2c/0xa0 > [] ? xfs_bmap_add_extent_delay_real+0x1674/0x1700 > [] ? _spin_unlock+0x27/0x50 > [] ? xfs_alloc_search_busy+0x8b/0xd0 > [] ? slab_pad_check+0x3c/0x120 > [] ? xfs_alloc_vextent+0x2e9/0x760 > [] ? check_object+0x13d/0x200 > [] ? xfs_bmap_add_extent+0x626/0x670 > [] ? xfs_bmbt_init_cursor+0x2c/0x100 > [] ? xfs_bmapi+0xfcb/0x1c90 > [] ? check_object+0x13d/0x200 > [] ? xfs_iomap_write_allocate+0x254/0x450 > [] ? xfs_iomap+0x3a7/0x3f0 > [] ? submit_bio+0x66/0x100 > [] ? xfs_map_blocks+0x3e/0x90 > [] ? xfs_page_state_convert+0x2ea/0x740 > [] ? xfs_vm_writepage+0x5e/0xf0 > [] ? __writepage+0xb/0x40 > [] ? write_cache_pages+0x1f1/0x330 > [] ? __writepage+0x0/0x40 > [] ? generic_writepages+0x23/0x30 > [] ? xfs_vm_writepages+0x43/0x50 > [] ? xfs_vm_writepages+0x0/0x50 > [] ? do_writepages+0x2e/0x50 > [] ? __writeback_single_inode+0x82/0x320 > [] ? _spin_lock+0x63/0x70 > [] ? generic_sync_sb_inodes+0x23a/0x320 > [] ? writeback_inodes+0x56/0xe0 > [] ? wb_kupdate+0x7b/0xf0 > [] ? pdflush+0x0/0x180 > [] ? pdflush+0xc0/0x180 > [] ? wb_kupdate+0x0/0xf0 > [] ? kthread+0x3a/0x70 > [] ? kthread+0x0/0x70 > [] ? kernel_thread_helper+0x7/0x10 > Code: 00 e8 97 73 02 00 c9 c3 90 8d 74 26 00 55 89 e5 83 ec 10 89 4c > 24 0c 89 54 24 08 89 44 24 04 c7 04 24 04 6c 4d c0 e8 fb de 16 00 <0f> > 0b eb fe 8d b4 26 00 00 00 00 8d bc 27 00 00 00 00 55 89 e5 > EIP: [] assfail+0x1e/0x30 SS:ESP 0068:d3a25870 > > _______________________________________________ > xfs-masters mailing list > xfs-masters@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs-masters > From SRS0+165be4d7b757c2ec7256+1976+infradead.org+hch@bombadil.srs.infradead.org Tue Jan 20 14:33:24 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0KKXNZX013694 for ; Tue, 20 Jan 2009 14:33:24 -0600 X-ASG-Debug-ID: 1232483600-0c5f01e90000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 787D6A30DC; Tue, 20 Jan 2009 12:33:20 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id uWEnFYFkFbpE4Nje; Tue, 20 Jan 2009 12:33:20 -0800 (PST) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.69 #1 (Red Hat Linux)) id 1LPNHj-00029n-Mf; Tue, 20 Jan 2009 20:33:19 +0000 Date: Tue, 20 Jan 2009 15:33:19 -0500 From: Christoph Hellwig To: Alexander Beregalov Cc: Dave Chinner , Christoph Hellwig , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090120203319.GA7103@infradead.org> References: <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> <20090112034550.GI8071@disturbed> <20090112211848.GL8071@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1232483603 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on oss.sgi.com X-Virus-Status: Clean On Tue, Jan 20, 2009 at 09:54:44PM +0300, Alexander Beregalov wrote: > Hi > > Is it a new bug? > It is pre-2.6.29-rc1 kernel, which was supossed to be free of the bug > "fs_is_ok, file: fs/xfs/xfs_btree.c, line: 3327" >From the trace it's a post-btree consolidation kernel, so all the bugs in -rc1 are there, too. It looks like this is the readahead type cockup that Geert noticed, so this particular one should be fixed in -rc2. I would strongly recommend to just turn on CNFIG_LBD for post-2.6.28 kernels for now as all the problems showing up are without CONFIG_LBD. From cattelan@thebarn.com Wed Jan 21 10:32:15 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0LGWE5Z028833 for ; Wed, 21 Jan 2009 10:32:15 -0600 X-ASG-Debug-ID: 1232555533-6c3500540000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from slurp.thebarn.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7D2EE1839183 for ; Wed, 21 Jan 2009 08:32:13 -0800 (PST) Received: from slurp.thebarn.com (cattelan-host202.dsl.visi.com [208.42.117.202]) by cuda.sgi.com with ESMTP id SBzl7z1YmxAUcGoo for ; Wed, 21 Jan 2009 08:32:13 -0800 (PST) Received: from funky.thebarn.com (slurp.thebarn.com [208.42.117.201]) (authenticated bits=0) by slurp.thebarn.com (8.14.3/8.14.0) with ESMTP id n0LGWRcB033194 for ; Wed, 21 Jan 2009 10:32:30 -0600 (CST) (envelope-from cattelan@thebarn.com) Message-ID: <49774E0A.9070402@thebarn.com> Date: Wed, 21 Jan 2009 10:32:10 -0600 From: Russell Cattelan User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: xfs-masters@oss.sgi.com X-ASG-Orig-Subj: no more ptools -> oss.sgi.com Subject: no more ptools -> oss.sgi.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.91.2/8882/Wed Jan 21 06:07:20 2009 on oss.sgi.com X-Virus-Scanned: ClamAV 0.91.2/8835/Sun Jan 4 21:47:36 2009 on slurp.thebarn.com X-Virus-Status: Clean X-Barracuda-Connect: cattelan-host202.dsl.visi.com[208.42.117.202] X-Barracuda-Start-Time: 1232555534 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0655 1.0000 -1.6028 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.60 X-Barracuda-Spam-Status: No, SCORE=-1.60 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15761 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- At this point I going to to assume all "current" XFS code will be going into the git trees on oss directly and things headed for ptools will be a pull based on sgi's internal needs. So I have shut down the cron jobs/scripts that move the ptools tree out to oss. The cvs trees will left on oss since they are still good a good reference resource but at this point they are no longer being updated. There are also git cvsimport trees that also have full xfs history and probably provide better reference, since with Christoph's change to cvsps the commits to git should accurately represent the ptools mods. -Russell From cattelan@thebarn.com Wed Jan 21 18:52:55 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0M0qtUe011496 for ; Wed, 21 Jan 2009 18:52:55 -0600 X-ASG-Debug-ID: 1232585527-11c503e50000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from slurp.thebarn.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2BBE6183C6FD; Wed, 21 Jan 2009 16:52:08 -0800 (PST) Received: from slurp.thebarn.com (cattelan-host202.dsl.visi.com [208.42.117.202]) by cuda.sgi.com with ESMTP id IHe86Zmb3ocVWlaJ; Wed, 21 Jan 2009 16:52:07 -0800 (PST) Received: from funky.thebarn.com (slurp.thebarn.com [208.42.117.201]) (authenticated bits=0) by slurp.thebarn.com (8.14.3/8.14.0) with ESMTP id n0M0qHDV043233; Wed, 21 Jan 2009 18:52:19 -0600 (CST) (envelope-from cattelan@xfs.org) Message-ID: <4977C330.1080700@xfs.org> Date: Wed, 21 Jan 2009 18:52:00 -0600 From: Russell Cattelan User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: lachlan@sgi.com CC: Russell Cattelan , Felix Blyakher , Mark Goodwin , xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: [Fwd: Fwd: Undelivered Mail Returned to Sender] Subject: Re: [Fwd: Fwd: Undelivered Mail Returned to Sender] References: <4977C147.7070807@sgi.com> In-Reply-To: <4977C147.7070807@sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: ClamAV 0.91.2/8835/Sun Jan 4 21:47:36 2009 on slurp.thebarn.com X-Virus-Status: Clean X-Barracuda-Connect: cattelan-host202.dsl.visi.com[208.42.117.202] X-Barracuda-Start-Time: 1232585530 X-Barracuda-Bayes: INNOCENT GLOBAL 0.4744 1.0000 0.0000 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15792 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sorry my bad. oss is now back running on the old hardware but with sles10sp2 as the base. (finally) The aliases.db files were out of date with the new version of sendmail so it was rejecting emails send to address in the aliases file. Fixed now. Also note: bugzilla has been ungraded to the latest stable release (3.2) Please check things out and let me know if anything else is not functioning correctly. Lachlan McIlroy wrote: > Russ, > > Mails to xfs@oss.sgi.com are bouncing. Any idea what's going on? > > Lachlan > > -------- Original Message -------- > Subject: Fwd: Undelivered Mail Returned to Sender > Date: Wed, 21 Jan 2009 18:29:36 -0600 > From: Felix Blyakher > To: ^Lachlan McIlroy , Mark Goodwin > CC: Gary Hagensen > References: <20090122002647.9698570001C8@estes.americas.sgi.com> > > > > Lachlan, Mark, > > Who is responsible for oss? All my mails to the > xfs mailing list bounce up. :( > > Thanks, > Felix > > Begin forwarded message: > >> *From: *MAILER-DAEMON@sgi.com (Mail >> Delivery System) >> *Date: *January 21, 2009 6:26:47 PM CST >> *To: *felixb@sgi.com >> *Subject: **Undelivered Mail Returned to Sender* >> >> This is the Postfix program at host estes.americas.sgi.com. >> >> I'm sorry to have to inform you that your message could not be >> be delivered to one or more recipients. It's attached below. >> >> For further assistance, please send mail to >> >> If you do so, please include this problem report. You can >> delete your own text from the attached returned message. >> >> The Postfix program >> >> >: host >> relay.sgi.com[137.38.102.111] said: 550 5.1.1 >> >: Recipient address >> rejected: undeliverable address: host >> oss.sgi.com[192.48.182.195] said: 550 5.1.1 > >... User >> unknown (in reply to RCPT TO command) (in reply to RCPT TO command) >> Reporting-MTA: dns; estes.americas.sgi.com >> X-Postfix-Queue-ID: 5F007700016A >> X-Postfix-Sender: rfc822; felixb@sgi.com >> Arrival-Date: Wed, 21 Jan 2009 18:26:44 -0600 (CST) >> >> Final-Recipient: rfc822; xfs@oss.sgi.com >> Action: failed >> Status: 5.0.0 >> Diagnostic-Code: X-Postfix; host relay.sgi.com[137.38.102.111] said: >> 550 5.1.1 >> >: Recipient address >> rejected: undeliverable address: host >> oss.sgi.com[192.48.182.195] said: 550 5.1.1 > >... User >> unknown (in reply to RCPT TO command) (in reply to RCPT TO command) >> >> *From: *Felix Blyakher > >> *Date: *January 21, 2009 6:26:44 PM CST >> *To: *Felix Blyakher > >> *Cc: *xfs@oss.sgi.com >> *Subject: **Re: [PATCH] [XFS] Warn on transaction in flight on >> read-only remount* >> >> >> Just wanted to point out to discussion on this topic: >> >> http://oss.sgi.com/archives/xfs/2008-12/msg00019.html >> >> I merely took a suggestion from it, and put it in a patch. >> >> Felix >> >> On Jan 21, 2009, at 4:57 PM, Felix Blyakher wrote: >> >>> Till VFS can correctly support read-only remount without racing, >>> use WARN_ON instead of BUG_ON on detecting transaction in flight >>> after quiescing filesystem. >>> >>> Signed-off-by: Felix Blyakher >>> --- >>> fs/xfs/linux-2.6/xfs_sync.c | 5 ++++- >>> 1 files changed, 4 insertions(+), 1 deletions(-) >>> >>> diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c >>> index 2ed0353..d8373ee 100644 >>> --- a/fs/xfs/linux-2.6/xfs_sync.c >>> +++ b/fs/xfs/linux-2.6/xfs_sync.c >>> @@ -371,7 +371,10 @@ xfs_quiesce_attr( >>> /* flush inodes and push all remaining buffers out to disk */ >>> xfs_quiesce_fs(mp); >>> >>> - ASSERT_ALWAYS(atomic_read(&mp->m_active_trans) == 0); >>> + /* Just warn here till VFS can correctly support >>> + * read-only remount without racing. >>> + */ >>> + WARN_ON(atomic_read(&mp->m_active_trans) == 0); >>> >>> /* Push the superblock and write an unmount record */ >>> error = xfs_log_sbcount(mp, 1); >>> -- >>> 1.6.1 >>> >> >> >> > From wwwrun@oss.sgi.com Wed Jan 21 19:53:28 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_82 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0M1rRjG015490 for ; Wed, 21 Jan 2009 19:53:27 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0M1rRFK015489; Wed, 21 Jan 2009 19:53:27 -0600 Date: Wed, 21 Jan 2009 19:53:27 -0600 Message-Id: <200901220153.n0M1rRFK015489@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 810] shutdown xfs filesystem. X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: critical X-Bugzilla-Who: cattelan@thebarn.com X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Platform In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=810 Russell Cattelan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cattelan@thebarn.com Platform|HP |All -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Wed Jan 21 19:53:40 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_82 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0M1re2d015519 for ; Wed, 21 Jan 2009 19:53:40 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0M1re9b015518; Wed, 21 Jan 2009 19:53:40 -0600 Date: Wed, 21 Jan 2009 19:53:40 -0600 Message-Id: <200901220153.n0M1re9b015518@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 809] s X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: critical X-Bugzilla-Who: cattelan@thebarn.com X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Platform In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=809 Russell Cattelan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cattelan@thebarn.com Platform|HP |All -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugme-daemon@bugzilla.kernel.org Wed Jan 21 21:07:57 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0M37vG9028271 for ; Wed, 21 Jan 2009 21:07:57 -0600 X-ASG-Debug-ID: 1232593631-168b000b0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DD0471830BB1 for ; Wed, 21 Jan 2009 19:07:11 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id 9JlvWLE1GzyBpRYB for ; Wed, 21 Jan 2009 19:07:11 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0M36d7S012503 for ; Wed, 21 Jan 2009 19:06:40 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 74138108040; Wed, 21 Jan 2009 19:06:39 -0800 (PST) X-ASG-Orig-Subj: [Bug 12469] XFS : Corruption of in-memory data Subject: [Bug 12469] XFS : Corruption of in-memory data In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090122030639.74138108040@picon.linux-foundation.org> Date: Wed, 21 Jan 2009 19:06:39 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232593632 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15800 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12469 david@fromorbit.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|xfs-masters@oss.sgi.com |david@fromorbit.com Status|NEW |ASSIGNED ------- Comment #17 from david@fromorbit.com 2009-01-21 19:06 ------- Bug has been found and fixed. See here: http://oss.sgi.com/archives/xfs/2009-01/msg00645.html Should be on it's way up to the main tree now. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You are the assignee for the bug, or are watching the assignee. From sandeen@sandeen.net Wed Jan 21 23:23:20 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0M5NKRE043413 for ; Wed, 21 Jan 2009 23:23:20 -0600 X-ASG-Debug-ID: 1232601755-35bc01d70000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.sandeen.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 03257183D5F0 for ; Wed, 21 Jan 2009 21:22:35 -0800 (PST) Received: from mail.sandeen.net (sandeen.net [209.173.210.139]) by cuda.sgi.com with ESMTP id YIpaGunCC7e1BnjI for ; Wed, 21 Jan 2009 21:22:35 -0800 (PST) Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sandeen.net (Postfix) with ESMTP id E0E31A9C9C3; Wed, 21 Jan 2009 23:21:59 -0600 (CST) Message-ID: <49780277.8050007@sandeen.net> Date: Wed, 21 Jan 2009 23:21:59 -0600 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: Russell Cattelan CC: xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: [xfs-masters] no more ptools -> oss.sgi.com Subject: Re: [xfs-masters] no more ptools -> oss.sgi.com References: <49774E0A.9070402@thebarn.com> In-Reply-To: <49774E0A.9070402@thebarn.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: sandeen.net[209.173.210.139] X-Barracuda-Start-Time: 1232601756 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15810 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Russell Cattelan wrote: > At this point I going to to assume all "current" XFS code will be going > into the > git trees on oss directly and things headed for ptools will be a pull > based on sgi's > internal needs. > > So I have shut down the cron jobs/scripts that move the ptools tree out > to oss. > > The cvs trees will left on oss since they are still good a good > reference resource > but at this point they are no longer being updated. Can you put a big warning or something on cvsweb and/or the source code pages on the website to make that obvious? Otherwise we'll have people pulling cvs and getting ancient code, and/or thinking the project is dead, I'm afraid. Maybe renaming the repo to xfs-historical etc or similar would work, too? -eric > There are also git cvsimport trees that also have full xfs history and > probably > provide better reference, since with Christoph's change to cvsps the commits > to git should accurately represent the ptools mods. > > > -Russell > > _______________________________________________ > xfs-masters mailing list > xfs-masters@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs-masters > From markgw@sgi.com Wed Jan 21 23:37:44 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0M5biaG044170 for ; Wed, 21 Jan 2009 23:37:44 -0600 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by relay2.corp.sgi.com (Postfix) with SMTP id 0FFD4304082; Wed, 21 Jan 2009 21:36:55 -0800 (PST) Received: from [134.14.55.22] (dhcp22.melbourne.sgi.com [134.14.55.22]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id QAA00499; Thu, 22 Jan 2009 16:36:52 +1100 Message-ID: <497805ED.9090004@sgi.com> Date: Thu, 22 Jan 2009 16:36:45 +1100 From: Mark Goodwin Reply-To: markgw@sgi.com Organization: SGI Engineering User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Eric Sandeen CC: Russell Cattelan , xfs-masters@oss.sgi.com Subject: Re: [xfs-masters] no more ptools -> oss.sgi.com References: <49774E0A.9070402@thebarn.com> <49780277.8050007@sandeen.net> In-Reply-To: <49780277.8050007@sandeen.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Eric Sandeen wrote: > ... > Maybe renaming the repo to xfs-historical etc or > similar would work, too? > > -eric > I'll second that idea. Ditto for the xfs-cmds/.git repository. And just to confirm, the old 2.6.x-xfs ptools dev tree will not be used any more. It's easier to use git-show directly to create patches for the SGI internal release trees (quilt stacks) than to check into the ptools expanded tree and then have to use p_mod2patch etc .. not that much of this concerns the community, except that it confirms that the cvs mirror has ceased. Cheers -- Mark From wwwrun@oss.sgi.com Thu Jan 22 13:32:43 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0MJWhS9104338 for ; Thu, 22 Jan 2009 13:32:43 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0MJWh61104334; Thu, 22 Jan 2009 13:32:43 -0600 Date: Thu, 22 Jan 2009 13:32:43 -0600 Message-Id: <200901221932.n0MJWh61104334@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 717] xfs can potentially dead-locks on xfs_ilock while handling page fault of user address X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=717 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hch@xfs.org --- Comment #1 from Christoph Hellwig 2009-01-22 13:32:42 CST --- Yes, that is is a potential dealock. We now also get a lockdep warning for in in xfsqa test 026. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From a.beregalov@gmail.com Fri Jan 23 12:43:40 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=BAYES_00,HEADER_ESQ autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0NIheFw215454 for ; Fri, 23 Jan 2009 12:43:40 -0600 X-ASG-Debug-ID: 1232736176-1a2502c00000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from rn-out-0910.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B05EFB27A2 for ; Fri, 23 Jan 2009 10:42:56 -0800 (PST) Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.186]) by cuda.sgi.com with ESMTP id wc8UhuoqaERiANdA for ; Fri, 23 Jan 2009 10:42:56 -0800 (PST) Received: by rn-out-0910.google.com with SMTP id j36so1188268rne.8 for ; Fri, 23 Jan 2009 10:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=WMY5tJUZGY+wDX10W6rK9EVvsVa691JwmiAEfTgTTY0=; b=JuK7h9QhOTk4EYk5/TEBF7xAgkVYVgYm8thLrX/zK9egNfLKAW2k+wesQeimu7qgkG QKWSfOSN4m2rSKpHGs5p6WqSZQD7wUnp1GZ6TngW9j0rSo21jydSm/CzNeB9sH51llTk DLPAYGYwNJOcdJtGlv8rvdP2RPjilTJL/NCGs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=QJwWBnmBpsR5z3fuv4JBfOYAe0kpQi6t3oXIGnqUbatE+NbkqA7QTdtQZqZLVNBx/A lFbfKMmaQQHzUjm4un8d2Sdwm2ViUqSZT6Fi5js20Hjwmx+ZyGb4vzeoXWUcG5yPNtlW DAG1e7aI/6DJR0EEyaVRpbqSkskvBB2UXdES4= MIME-Version: 1.0 Received: by 10.100.93.19 with SMTP id q19mr954608anb.156.1232735676301; Fri, 23 Jan 2009 10:34:36 -0800 (PST) In-Reply-To: <20090120203319.GA7103@infradead.org> References: <20090110143924.GA25900@infradead.org> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> <20090112034550.GI8071@disturbed> <20090112211848.GL8071@disturbed> <20090120203319.GA7103@infradead.org> Date: Fri, 23 Jan 2009 21:34:36 +0300 Message-ID: X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 From: Alexander Beregalov To: Christoph Hellwig Cc: Dave Chinner , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, kernel-testers@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: rn-out-0910.google.com[64.233.170.186] X-Barracuda-Start-Time: 1232736176 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15944 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean 2009/1/20 Christoph Hellwig : > On Tue, Jan 20, 2009 at 09:54:44PM +0300, Alexander Beregalov wrote: >> Hi >> >> Is it a new bug? >> It is pre-2.6.29-rc1 kernel, which was supossed to be free of the bug >> "fs_is_ok, file: fs/xfs/xfs_btree.c, line: 3327" > > From the trace it's a post-btree consolidation kernel, so all the bugs > in -rc1 are there, too. It looks like this is the readahead type > cockup that Geert noticed, so this particular one should be fixed in > -rc2. > > I would strongly recommend to just turn on CNFIG_LBD for post-2.6.28 > kernels for now as all the problems showing up are without CONFIG_LBD. Yes, both bugs do not appear on kernel with CONFIG_LBD=y. But I do not need LBD. Does XFS strongly require LBD? Should I always turn it on even if I do not have files or devices of size 2Tb+ ? From cattelan@thebarn.com Fri Jan 23 16:01:17 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0NM1HOO227452 for ; Fri, 23 Jan 2009 16:01:17 -0600 X-ASG-Debug-ID: 1232748032-3c0d02670000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from slurp.thebarn.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 56737185A95B for ; Fri, 23 Jan 2009 14:00:32 -0800 (PST) Received: from slurp.thebarn.com (cattelan-host202.dsl.visi.com [208.42.117.202]) by cuda.sgi.com with ESMTP id V0vY0vgij7ArGqyO for ; Fri, 23 Jan 2009 14:00:32 -0800 (PST) Received: from funky.thebarn.com (slurp.thebarn.com [208.42.117.201]) (authenticated bits=0) by slurp.thebarn.com (8.14.3/8.14.0) with ESMTP id n0NM0lMi032899; Fri, 23 Jan 2009 16:00:48 -0600 (CST) (envelope-from cattelan@xfs.org) Message-ID: <497A3DFC.3020800@xfs.org> Date: Fri, 23 Jan 2009 16:00:28 -0600 From: Russell Cattelan User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: markgw@sgi.com CC: Eric Sandeen , Russell Cattelan , xfs-masters@oss.sgi.com X-ASG-Orig-Subj: Re: [xfs-masters] no more ptools -> oss.sgi.com Subject: Re: [xfs-masters] no more ptools -> oss.sgi.com References: <49774E0A.9070402@thebarn.com> <49780277.8050007@sandeen.net> <497805ED.9090004@sgi.com> In-Reply-To: <497805ED.9090004@sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: ClamAV 0.91.2/8835/Sun Jan 4 21:47:36 2009 on slurp.thebarn.com X-Virus-Status: Clean X-Barracuda-Connect: cattelan-host202.dsl.visi.com[208.42.117.202] X-Barracuda-Start-Time: 1232748033 X-Barracuda-Bayes: INNOCENT GLOBAL 0.1933 1.0000 -0.8630 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.86 X-Barracuda-Spam-Status: No, SCORE=-0.86 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15958 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Mark Goodwin wrote: > > > Eric Sandeen wrote: >> ... >> Maybe renaming the repo to xfs-historical etc or >> similar would work, too? >> >> -eric >> > > I'll second that idea. Ditto for the xfs-cmds/.git repository. Sorry forgot to follow up on this. the xfs-cmd are labeled with a description for cvsimport maybe a big depreciated description. I don't want to rename the cvs tree's since it might be confusing for people that have them checkout or bookmarked etc. Maybe a big DEPRECATED file in the base of the trees? > > And just to confirm, the old 2.6.x-xfs ptools dev tree will not > be used any more. It's easier to use git-show directly to > create patches for the SGI internal release trees (quilt stacks) > than to check into the ptools expanded tree and then have to use > p_mod2patch etc .. not that much of this concerns the community, > except that it confirms that the cvs mirror has ceased. > > Cheers > -- Mark > From hch@lst.de Fri Jan 23 21:26:42 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0O3QgDb244587 for ; Fri, 23 Jan 2009 21:26:42 -0600 X-ASG-Debug-ID: 1232767557-2cf003a40000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from verein.lst.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DC4691BA8440; Fri, 23 Jan 2009 19:25:57 -0800 (PST) Received: from verein.lst.de (verein.lst.de [213.95.11.210]) by cuda.sgi.com with ESMTP id pU2Ic4bxbKLW0KRn; Fri, 23 Jan 2009 19:25:57 -0800 (PST) Received: from verein.lst.de (localhost [127.0.0.1]) by verein.lst.de (8.12.3/8.12.3/Debian-7.1) with ESMTP id n0O3MAIF030444 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Sat, 24 Jan 2009 04:22:11 +0100 Received: (from hch@localhost) by verein.lst.de (8.12.3/8.12.3/Debian-6.6) id n0O3MA9s030442; Sat, 24 Jan 2009 04:22:10 +0100 Date: Sat, 24 Jan 2009 04:22:10 +0100 From: Christoph Hellwig To: Alexander Beregalov Cc: Christoph Hellwig , xfs-masters@oss.sgi.com, kernel-testers@vger.kernel.org, xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Message-ID: <20090124032210.GA30366@lst.de> References: <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> <20090112034550.GI8071@disturbed> <20090112211848.GL8071@disturbed> <20090120203319.GA7103@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-Scanned-By: MIMEDefang 2.39 X-Barracuda-Connect: verein.lst.de[213.95.11.210] X-Barracuda-Start-Time: 1232767558 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.15979 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Fri, Jan 23, 2009 at 09:34:36PM +0300, Alexander Beregalov wrote: > But I do not need LBD. Does XFS strongly require LBD? > Should I always turn it on even if I do not have files or devices of size 2Tb+ ? The bug is now fixed in the development tree, but until you upgrade to a kernel with the fix enabling CONFIG_LBD will keep you from hitting the bug. As you unfortunately noticed the !CONFIG_LBD case doesn't really get much test coverage, so I would personally recommend turning it on even if you don't need it. From wwwrun@oss.sgi.com Sat Jan 24 08:41:49 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0OEfnVN016668 for ; Sat, 24 Jan 2009 08:41:49 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0OEfnwf016667; Sat, 24 Jan 2009 08:41:49 -0600 Date: Sat, 24 Jan 2009 08:41:49 -0600 Message-Id: <200901241441.n0OEfnwf016667@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 813] logsize parsing in xfs_mkfs is broken for small blocksizes X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsprogs X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=813 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Sat Jan 24 08:54:48 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0OEsmK0018385 for ; Sat, 24 Jan 2009 08:54:48 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0OEsm3K018384; Sat, 24 Jan 2009 08:54:48 -0600 Date: Sat, 24 Jan 2009 08:54:48 -0600 Message-Id: <200901241454.n0OEsm3K018384@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 708] CIH_DUMPATTR_SUBTREE not properly set on subtree dump X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsdump X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=708 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |hch@xfs.org Resolution| |FIXED --- Comment #5 from Christoph Hellwig 2009-01-24 08:54:46 CST --- I've now put in the original change as removing all those flags seemd a little too intrusive. Here's the commit on gitweb: http://git.kernel.org/?p=fs/xfs/xfsdump-dev.git;a=commitdiff;h=d6a276bd586fd0d8d986d9d6a240aff2bc09e6d0 -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From xfs-master@oss.sgi.com Sat Jan 24 18:08:12 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_50 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0P08CPR074960 for ; Sat, 24 Jan 2009 18:08:12 -0600 Received: (from xfs-master@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0P08CUY074958 for xfs-masters@oss.sgi.com; Sat, 24 Jan 2009 18:08:12 -0600 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0P08BEo074924 for ; Sat, 24 Jan 2009 18:08:11 -0600 X-ASG-Debug-ID: 1232842038-4edf025c0000-lnlpjA X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from show-harmonious-block.cn (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with SMTP id 43A761BAAA5A; Sat, 24 Jan 2009 16:07:20 -0800 (PST) Received: from show-harmonious-block.cn (189-57-126-117.customer.tdatabrasil.net.br [189.57.126.117]) by cuda.sgi.com with SMTP id uOFs3cA1B4Q3Kw1h; Sat, 24 Jan 2009 16:07:20 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s189270; d=show-harmonious-block.cn; h=Message-ID:Date:Reply-To:From:User-Agent:MIME-Version:To:Cc:Subject:Content-Type:Content-Transfer-Encoding; b=I+CarmBD7lJhnbHPElZSu3q8t1UJzZ2DKYZ2as/+kGo0eoCBsUpVLLlAdE0wanKHNmFRZxmb7wexD31H9se2gg==; Message-ID: Date: Sat, 24 Jan 2009 22:49:49 -0100 Reply-To: "Timothy" From: "Timothy" User-Agent: Mozilla 4.79 [en] (Windows NT 5.0; U) MIME-Version: 1.0 To: "Luis" Cc: "Mike" , "Stanley" , "Leonard" X-ASG-Orig-Subj: Prepare yourself for this Subject: Prepare yourself for this Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Barracuda-Connect: 189-57-126-117.customer.tdatabrasil.net.br[189.57.126.117] X-Barracuda-Start-Time: 1232842048 X-Barracuda-Bayes: INNOCENT GLOBAL 0.4998 1.0000 0.0000 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: 0.10 X-Barracuda-Spam-Status: No, SCORE=0.10 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=RDNS_DYNAMIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16051 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 RDNS_DYNAMIC Delivered to trusted network by host with dynamic-looking rDNS X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean This company are your premier Canadian on-line pharmaceutical. We presenting doctor's recommendation medicinals and non-doctor's direction products. You can buy Canadian remedy's from us at greater than 80% off, when compared to your neighborhood . www.show-harmonious-block.cn "What is this?" book The total amount was found to dry be as record well M. Noirtier ha From wwwrun@oss.sgi.com Sat Jan 24 23:15:05 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0P5F5Cr095525 for ; Sat, 24 Jan 2009 23:15:05 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0P5F5XU095524; Sat, 24 Jan 2009 23:15:05 -0600 Date: Sat, 24 Jan 2009 23:15:05 -0600 Message-Id: <200901250515.n0P5F5XU095524@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 430] dont symlink files if libdir and libexecdir are the same X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: dmapi X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=430 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |FIXED --- Comment #7 from Christoph Hellwig 2009-01-24 23:15:03 CST --- After talking to Nathan again I've pushed this update to all packages now. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Sat Jan 24 23:15:49 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0P5FnsY095594 for ; Sat, 24 Jan 2009 23:15:49 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0P5FnO9095593; Sat, 24 Jan 2009 23:15:49 -0600 Date: Sat, 24 Jan 2009 23:15:49 -0600 Message-Id: <200901250515.n0P5FnO9095593@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 785] xfs_io doesn't correctly reallocate struct getbmapx in bmap_f X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsprogs X-Bugzilla-Keywords: X-Bugzilla-Severity: trivial X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=785 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |FIXED --- Comment #3 from Christoph Hellwig 2009-01-24 23:15:48 CST --- I've pushed in the comment fixes, but as per discussion in here I'll leave the resizing algorithm as-is. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Sun Jan 25 07:23:07 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0PDN6jS126909 for ; Sun, 25 Jan 2009 07:23:07 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0PDN6Yo126908; Sun, 25 Jan 2009 07:23:06 -0600 Date: Sun, 25 Jan 2009 07:23:06 -0600 Message-Id: <200901251323.n0PDN6Yo126908@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 810] shutdown xfs filesystem. X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: critical X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=810 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hch@xfs.org --- Comment #11 from Christoph Hellwig 2009-01-25 07:23:04 CST --- Any updates? -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Sun Jan 25 07:23:52 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0PDNqcX126974 for ; Sun, 25 Jan 2009 07:23:52 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0PDNqWa126972; Sun, 25 Jan 2009 07:23:52 -0600 Date: Sun, 25 Jan 2009 07:23:52 -0600 Message-Id: <200901251323.n0PDNqWa126972@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 792] xfs_repair. X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsprogs X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=792 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |FIXED --- Comment #4 from Christoph Hellwig 2009-01-25 07:23:51 CST --- Closing assuming it's the arm packing problem, given the lack of feedback. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Sun Jan 25 14:08:26 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0PK8QBD152314 for ; Sun, 25 Jan 2009 14:08:26 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0PK8PFG152313; Sun, 25 Jan 2009 14:08:26 -0600 Date: Sun, 25 Jan 2009 14:08:26 -0600 Message-Id: <200901252008.n0PK8PFG152313@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 810] shutdown xfs filesystem. X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: critical X-Bugzilla-Who: ammartinez@coitt.es X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=810 --- Comment #12 from ammartinez@coitt.es 2009-01-25 14:08:23 CST --- We will make a proof this week again. Thanks. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugme-daemon@bugzilla.kernel.org Sun Jan 25 15:03:31 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0PL3URc155295 for ; Sun, 25 Jan 2009 15:03:31 -0600 X-ASG-Debug-ID: 1232917366-34e700d90000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B9FA31BABF74 for ; Sun, 25 Jan 2009 13:02:46 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id j8fiVGsoyReqDtpb for ; Sun, 25 Jan 2009 13:02:46 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0PL2f99009877 for ; Sun, 25 Jan 2009 13:02:42 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 108EE10800E; Sun, 25 Jan 2009 13:02:41 -0800 (PST) X-ASG-Orig-Subj: [Bug 12538] New: xfs_fsr fails on 2.6.29-rc kernels Subject: [Bug 12538] New: xfs_fsr fails on 2.6.29-rc kernels X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: Message-Id: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Date: Sun, 25 Jan 2009 13:02:41 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232917367 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16131 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12538 Summary: xfs_fsr fails on 2.6.29-rc kernels Product: File System Version: 2.5 KernelVersion: 2.6.29-rc1 Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: XFS AssignedTo: xfs-masters@oss.sgi.com ReportedBy: pm@debian.org Latest working kernel version: 2.6.28-rc9 Earliest failing kernel version: 2.6.29-rc1 Distribution: Debian Hardware Environment: IBM Thinkpad T42 Software Environment: Problem Description: xfs_fsr -v fails with: XFS_IOC_SWAPEXT failed: ino=XXXXXXX: Invalid argument Steps to reproduce: Run xfs_fsr on a moderately fragmented filesystem. Have git-bisected this to the following patch: commit 743bb4650da9e2595d6cedd01c680b5b9398c74a Author: sandeen@sandeen.net Date: Tue Nov 25 21:20:06 2008 -0600 [XFS] Move copy_from_user calls out of ioctl helpers into ioctl switch. Moving the copy_from_user out of some of the ioctl helpers will make it easier for the compat ioctl switch to copy in the right struct, then just pass to the underlying helper. Also, move common access checks into the helpers themselves, and out of the native ioctl switch code, to reduce code duplication between native & compat ioctl callers. Signed-off-by: Eric Sandeen Reviewed-by: Christoph Hellwig Signed-off-by: Lachlan McIlroy -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 25 15:08:07 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0PL86Ew155580 for ; Sun, 25 Jan 2009 15:08:07 -0600 X-ASG-Debug-ID: 1232917643-34e700eb0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 02D2D185BBF5 for ; Sun, 25 Jan 2009 13:07:23 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id GwUkmYIWHbHX7jW9 for ; Sun, 25 Jan 2009 13:07:23 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0PL75sG010232 for ; Sun, 25 Jan 2009 13:07:06 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id CA78A108040; Sun, 25 Jan 2009 13:07:05 -0800 (PST) X-ASG-Orig-Subj: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels Subject: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090125210705.CA78A108040@picon.linux-foundation.org> Date: Sun, 25 Jan 2009 13:07:05 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232917644 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16131 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12538 pm@debian.org changed: What |Removed |Added ---------------------------------------------------------------------------- Regression|0 |1 -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 25 17:37:00 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0PNaxJE165078 for ; Sun, 25 Jan 2009 17:37:00 -0600 X-ASG-Debug-ID: 1232926575-34f403c80000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id ABC55183C68E for ; Sun, 25 Jan 2009 15:36:15 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id HxLYtFvv7yCoB1Hc for ; Sun, 25 Jan 2009 15:36:15 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0PNaDmw017510 for ; Sun, 25 Jan 2009 15:36:15 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id A783D108041; Sun, 25 Jan 2009 15:36:13 -0800 (PST) X-ASG-Orig-Subj: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels Subject: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090125233613.A783D108041@picon.linux-foundation.org> Date: Sun, 25 Jan 2009 15:36:13 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232926576 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16141 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12538 sandeen@redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandeen@redhat.com ------- Comment #1 from sandeen@redhat.com 2009-01-25 15:36 ------- Thanks for doing the bisecting. Which arch is this on, and if a 64-bit arch, is it 32 bit or 64 bit userspace? -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 25 17:59:26 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0PNxPZu166865 for ; Sun, 25 Jan 2009 17:59:25 -0600 X-ASG-Debug-ID: 1232927922-234102150000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id CDF0E185C0B2 for ; Sun, 25 Jan 2009 15:58:42 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id EZzx5p64EWRnetms for ; Sun, 25 Jan 2009 15:58:42 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0PNwedQ018552 for ; Sun, 25 Jan 2009 15:58:41 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 4477610800E; Sun, 25 Jan 2009 15:58:40 -0800 (PST) X-ASG-Orig-Subj: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels Subject: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090125235840.4477610800E@picon.linux-foundation.org> Date: Sun, 25 Jan 2009 15:58:40 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232927922 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16143 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12538 ------- Comment #2 from pm@debian.org 2009-01-25 15:58 ------- 32-bit i686. processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 13 model name : Intel(R) Pentium(R) M processor 1.70GHz stepping : 6 -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 25 18:20:49 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0Q0KmDV169001 for ; Sun, 25 Jan 2009 18:20:49 -0600 X-ASG-Debug-ID: 1232929205-590101660000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 552C1185BE26 for ; Sun, 25 Jan 2009 16:20:05 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id H75A2CyYpUnKEjgJ for ; Sun, 25 Jan 2009 16:20:05 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0Q0JXWp019601 for ; Sun, 25 Jan 2009 16:19:34 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id 8BC29108041; Sun, 25 Jan 2009 16:19:33 -0800 (PST) X-ASG-Orig-Subj: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels Subject: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090126001933.8BC29108041@picon.linux-foundation.org> Date: Sun, 25 Jan 2009 16:19:33 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232929206 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16145 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12538 ------- Comment #3 from sandeen@redhat.com 2009-01-25 16:19 ------- Created an attachment (id=19986) --> (http://bugzilla.kernel.org/attachment.cgi?id=19986&action=view) potential fix Wow, that was an incredibly dumb mistake on my part, not sure how it ever worked at all. Does this help? -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugme-daemon@bugzilla.kernel.org Sun Jan 25 19:08:36 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0Q18ZhG171501 for ; Sun, 25 Jan 2009 19:08:36 -0600 X-ASG-Debug-ID: 1232932071-690d02490000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6B89E185BCE7 for ; Sun, 25 Jan 2009 17:07:51 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id XGQtUhUN6DgFKb2D for ; Sun, 25 Jan 2009 17:07:51 -0800 (PST) Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0Q17mk9021804 for ; Sun, 25 Jan 2009 17:07:49 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 33) id ED9A3108040; Sun, 25 Jan 2009 17:07:47 -0800 (PST) X-ASG-Orig-Subj: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels Subject: [Bug 12538] xfs_fsr fails on 2.6.29-rc kernels In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo AssignedTo X-Bugzilla-Component: XFS To: xfs-masters@oss.sgi.com From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090126010747.ED9A3108040@picon.linux-foundation.org> Date: Sun, 25 Jan 2009 17:07:47 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1232932072 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16147 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean http://bugzilla.kernel.org/show_bug.cgi?id=12538 sandeen@redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|xfs-masters@oss.sgi.com |sandeen@redhat.com Status|NEW |ASSIGNED -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You are the assignee for the bug, or are watching the assignee. From wwwrun@oss.sgi.com Mon Jan 26 13:17:53 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0QJHrtG246964 for ; Mon, 26 Jan 2009 13:17:53 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0QJHrGZ246963; Mon, 26 Jan 2009 13:17:53 -0600 Date: Mon, 26 Jan 2009 13:17:53 -0600 Message-Id: <200901261917.n0QJHrGZ246963@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 811] /etc/projid and /etc/projects file need manpages X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsprogs X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Severity In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=811 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 13:22:39 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0QJMdxS247505 for ; Mon, 26 Jan 2009 13:22:39 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0QJMdc0247503; Mon, 26 Jan 2009 13:22:39 -0600 Date: Mon, 26 Jan 2009 13:22:39 -0600 Message-Id: <200901261922.n0QJMdc0247503@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 229] xfs_repair unable to repair system X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsprogs X-Bugzilla-Keywords: X-Bugzilla-Severity: critical X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=229 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |INVALID --- Comment #4 from Christoph Hellwig 2009-01-26 13:22:37 CST --- Closing as the original submitter doesn't seem to be around anymore (after five years or ignoring the bug, sorry..) -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 13:24:07 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0QJO6la247573 for ; Mon, 26 Jan 2009 13:24:07 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0QJO6RQ247572; Mon, 26 Jan 2009 13:24:06 -0600 Date: Mon, 26 Jan 2009 13:24:06 -0600 Message-Id: <200901261924.n0QJO6RQ247572@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 327] Indestructible directories X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsprogs X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=327 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |INVALID --- Comment #2 from Christoph Hellwig 2009-01-26 13:24:05 CST --- Closing as we don't seem to be able to get feedback on this anymore, and the code changed too much in the last four years. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 13:25:04 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0QJP3GS247637 for ; Mon, 26 Jan 2009 13:25:04 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0QJP3SZ247636; Mon, 26 Jan 2009 13:25:03 -0600 Date: Mon, 26 Jan 2009 13:25:03 -0600 Message-Id: <200901261925.n0QJP3SZ247636@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 353] kernel BUG at fs/xfs/support/debug.c:106! X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=353 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |INVALID --- Comment #2 from Christoph Hellwig 2009-01-26 13:25:02 CST --- Closing as we don't seem to be able to get feedback on this anymore, and the code changed too much in the last four years. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 13:25:39 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0QJPd2K247670 for ; Mon, 26 Jan 2009 13:25:39 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0QJPdWc247669; Mon, 26 Jan 2009 13:25:39 -0600 Date: Mon, 26 Jan 2009 13:25:39 -0600 Message-Id: <200901261925.n0QJPdWc247669@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 390] xfs_copy produces corrupt copy X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsprogs X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=390 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |INVALID --- Comment #2 from Christoph Hellwig 2009-01-26 13:25:38 CST --- Closing as we don't seem to be able to get feedback on this anymore, and the code changed too much in the last four years. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 13:25:59 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0QJPxNK247717 for ; Mon, 26 Jan 2009 13:25:59 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0QJPxlD247716; Mon, 26 Jan 2009 13:25:59 -0600 Date: Mon, 26 Jan 2009 13:25:59 -0600 Message-Id: <200901261925.n0QJPxlD247716@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 391] unable to copy a 25GB-file from xfs X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=391 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |INVALID --- Comment #3 from Christoph Hellwig 2009-01-26 13:25:58 CST --- Closing as we don't seem to be able to get feedback on this anymore, and the code changed too much in the last four years. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 13:26:49 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0QJQnJF247783 for ; Mon, 26 Jan 2009 13:26:49 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0QJQnho247782; Mon, 26 Jan 2009 13:26:49 -0600 Date: Mon, 26 Jan 2009 13:26:49 -0600 Message-Id: <200901261926.n0QJQnho247782@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 402] xfs_repair Segmentation fault X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsprogs X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=402 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |INVALID --- Comment #2 from Christoph Hellwig 2009-01-26 13:26:46 CST --- Closing as we don't seem to be able to get feedback on this anymore, and the code changed too much in the last four years. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 13:28:29 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0QJSTeI247863 for ; Mon, 26 Jan 2009 13:28:29 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0QJST1W247862; Mon, 26 Jan 2009 13:28:29 -0600 Date: Mon, 26 Jan 2009 13:28:29 -0600 Message-Id: <200901261928.n0QJST1W247862@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 680] XFS_WANT_CORRUPTED_RETURN in xfs_alloc.c X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=680 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hch@xfs.org --- Comment #7 from Christoph Hellwig 2009-01-26 13:28:27 CST --- Actually in recent times we've seen various bugs with these symptoms due to having write caches enabled but no barriers. Does your dmesg say something about barriers not beeing supported? -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 13:30:06 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0QJU60p248053 for ; Mon, 26 Jan 2009 13:30:06 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0QJU62k248052; Mon, 26 Jan 2009 13:30:06 -0600 Date: Mon, 26 Jan 2009 13:30:06 -0600 Message-Id: <200901261930.n0QJU62k248052@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 739] XFS upload to near full file system slows down terribly X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=739 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hch@xfs.org --- Comment #1 from Christoph Hellwig 2009-01-26 13:30:04 CST --- Can you reproduce this on a modern kernel? Some kind of testcase would be extremly useful. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 19:49:26 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0R1nQtl007198 for ; Mon, 26 Jan 2009 19:49:26 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0R1nPQw007197; Mon, 26 Jan 2009 19:49:25 -0600 Date: Mon, 26 Jan 2009 19:49:25 -0600 Message-Id: <200901270149.n0R1nPQw007197@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 789] recovery panic X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cattelan@thebarn.com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=789 Russell Cattelan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 20:21:35 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0R2LZBM009021 for ; Mon, 26 Jan 2009 20:21:35 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0R2LZUu009016; Mon, 26 Jan 2009 20:21:35 -0600 Date: Mon, 26 Jan 2009 20:21:35 -0600 Message-Id: <200901270221.n0R2LZUu009016@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 789] recovery panic X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cattelan@thebarn.com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Flag In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=789 Russell Cattelan changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |NeedInfo+ --- Comment #3 from Russell Cattelan 2009-01-26 20:21:35 CST --- I could at one point hit it reliably, but I have not tried it in a while. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From wwwrun@oss.sgi.com Mon Jan 26 20:26:38 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0R2Qcoq009235 for ; Mon, 26 Jan 2009 20:26:38 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0R2Qcph009233; Mon, 26 Jan 2009 20:26:38 -0600 Date: Mon, 26 Jan 2009 20:26:38 -0600 Message-Id: <200901270226.n0R2Qcph009233@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 712] 2.6.17.7 XFS internal error xfs_da_do_buf X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: XFS kernel code X-Bugzilla-Keywords: X-Bugzilla-Severity: critical X-Bugzilla-Who: cattelan@thebarn.com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=712 Russell Cattelan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cattelan@thebarn.com -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From me@ankitjain.org Wed Jan 28 15:00:36 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,J_CHICKENPOX_75, LOCAL_GNU_PATCH,RCVD_IN_BRBL autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0SL0ZgX152887 for ; Wed, 28 Jan 2009 15:00:36 -0600 X-ASG-Debug-ID: 1233176385-259401c60000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail-gx0-f21.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1A8BCC5151; Wed, 28 Jan 2009 12:59:45 -0800 (PST) Received: from mail-gx0-f21.google.com (mail-gx0-f21.google.com [209.85.217.21]) by cuda.sgi.com with ESMTP id X2zCzWn9FkEXaPB4; Wed, 28 Jan 2009 12:59:45 -0800 (PST) Received: by gxk14 with SMTP id 14so6438537gxk.20 for ; Wed, 28 Jan 2009 12:59:45 -0800 (PST) Received: by 10.142.161.13 with SMTP id j13mr1527195wfe.48.1233176384895; Wed, 28 Jan 2009 12:59:44 -0800 (PST) Received: from ?192.169.1.100? ([122.167.87.145]) by mx.google.com with ESMTPS id 29sm20954407wfg.26.2009.01.28.12.59.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 28 Jan 2009 12:59:44 -0800 (PST) Message-ID: <4980C71F.1010804@ankitjain.org> Date: Thu, 29 Jan 2009 02:29:11 +0530 From: Ankit Jain User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Al Viro CC: Christoph Hellwig , linux-fsdevel@vger.kernel.org, mfasheh@suse.com, joel.becker@oracle.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com X-ASG-Orig-Subj: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Subject: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: mail-gx0-f21.google.com[209.85.217.21] X-Barracuda-Start-Time: 1233176387 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16383 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Al, Could this be included in the vfs queue? This patch adds ioctls to vfs for compatibility with legacy XFS pre-allocation ioctls (XFS_IOC_*RESVP*). The implementation effectively invokes sys_fallocate for the new ioctls. Also handles the compat_ioctl case. Note: These legacy ioctls are also implemented by OCFS2. Signed-off-by: Ankit Jain Reviewed-by: Christoph Hellwig Tested-by: Christoph Hellwig --- fs/compat_ioctl.c | 29 +++++++++++++++++++++++++++ fs/ioctl.c | 35 ++++++++++++++++++++++++++++++++ fs/open.c | 51 +++++++++++++++++++++++------------------------ include/linux/falloc.h | 44 +++++++++++++++++++++++++++++++++++++++++ include/linux/fs.h | 6 +++++ 5 files changed, 139 insertions(+), 26 deletions(-) Index: xfs/fs/compat_ioctl.c =================================================================== --- xfs.orig/fs/compat_ioctl.c 2009-01-21 21:03:26.217449883 +0100 +++ xfs/fs/compat_ioctl.c 2009-01-27 20:36:59.189424147 +0100 @@ -2765,6 +2765,26 @@ static void compat_ioctl_error(struct fi free_page((unsigned long)path); } +#ifdef BROKEN_X86_ALIGNMENT +/* just account for different alignment */ +static unsigned long copy_to_space_resv(unsigned long arg) +{ + struct space_resv_32 __user *p32 = (void __user *)arg; + struct space_resv __user *p = compat_alloc_user_space(sizeof(*p)); + + if (copy_in_user(&p->l_type, &p32->l_type, sizeof(s16)) || + copy_in_user(&p->l_whence, &p32->l_whence, sizeof(s16)) || + copy_in_user(&p->l_start, &p32->l_start, sizeof(s64)) || + copy_in_user(&p->l_len, &p32->l_len, sizeof(s64)) || + copy_in_user(&p->l_sysid, &p32->l_sysid, sizeof(s32)) || + copy_in_user(&p->l_pid, &p32->l_pid, sizeof(u32)) || + copy_in_user(&p->l_pad, &p32->l_pad, 4*sizeof(u32))) + return -EFAULT; + + return (unsigned long)p; +} +#endif + asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg) { @@ -2795,6 +2815,15 @@ asmlinkage long compat_sys_ioctl(unsigne case FIOQSIZE: break; + case F_IOC_RESVSP_32: + case F_IOC_RESVSP64_32: +#ifdef BROKEN_X86_ALIGNMENT + arg = copy_to_space_resv(arg); + cmd = _NATIVE_IOC(cmd, struct space_resv); +#endif + error = ioctl_preallocate(filp, arg); + goto out_fput; + case FIBMAP: case FIGETBSZ: case FIONREAD: Index: xfs/fs/ioctl.c =================================================================== --- xfs.orig/fs/ioctl.c 2009-01-21 21:03:27.321448363 +0100 +++ xfs/fs/ioctl.c 2009-01-27 20:36:59.189424147 +0100 @@ -15,6 +15,7 @@ #include #include #include +#include #include @@ -370,6 +371,37 @@ EXPORT_SYMBOL(generic_block_fiemap); #endif /* CONFIG_BLOCK */ +/* + * This provides compatibility with legacy XFS pre-allocation ioctls + * which predate the fallocate syscall. + * + * Only the l_start, l_len and l_whence fields of the 'struct space_resv' + * are used here, rest are ignored. + */ +int ioctl_preallocate(struct file *filp, unsigned long arg) +{ + struct inode *inode = filp->f_path.dentry->d_inode; + struct space_resv sr; + + if (copy_from_user(&sr, (struct space_resv __user *) arg, sizeof(sr))) + return -EFAULT; + + switch (sr.l_whence) { + case SEEK_SET: + break; + case SEEK_CUR: + sr.l_start += filp->f_pos; + break; + case SEEK_END: + sr.l_start += i_size_read(inode); + break; + default: + return -EINVAL; + } + + return do_fallocate(filp, FALLOC_FL_KEEP_SIZE, sr.l_start, sr.l_len); +} + static int file_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { @@ -385,6 +417,9 @@ static int file_ioctl(struct file *filp, return put_user(inode->i_sb->s_blocksize, p); case FIONREAD: return put_user(i_size_read(inode) - filp->f_pos, p); + case F_IOC_RESVSP: + case F_IOC_RESVSP64: + return ioctl_preallocate(filp, arg); } return vfs_ioctl(filp, cmd, arg); Index: xfs/fs/open.c =================================================================== --- xfs.orig/fs/open.c 2009-01-21 21:03:27.740294372 +0100 +++ xfs/fs/open.c 2009-01-27 20:41:38.208298998 +0100 @@ -377,63 +377,63 @@ SYSCALL_ALIAS(sys_ftruncate64, SyS_ftrun #endif #endif /* BITS_PER_LONG == 32 */ -SYSCALL_DEFINE(fallocate)(int fd, int mode, loff_t offset, loff_t len) + +int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len) { - struct file *file; - struct inode *inode; - long ret = -EINVAL; + struct inode *inode = file->f_path.dentry->d_inode; + long ret; if (offset < 0 || len <= 0) - goto out; + return -EINVAL; /* Return error if mode is not supported */ - ret = -EOPNOTSUPP; if (mode && !(mode & FALLOC_FL_KEEP_SIZE)) - goto out; + return -EOPNOTSUPP; - ret = -EBADF; - file = fget(fd); - if (!file) - goto out; if (!(file->f_mode & FMODE_WRITE)) - goto out_fput; + return -EBADF; /* * Revalidate the write permissions, in case security policy has * changed since the files were opened. */ ret = security_file_permission(file, MAY_WRITE); if (ret) - goto out_fput; + return ret; - inode = file->f_path.dentry->d_inode; - - ret = -ESPIPE; if (S_ISFIFO(inode->i_mode)) - goto out_fput; + return -ESPIPE; - ret = -ENODEV; /* * Let individual file system decide if it supports preallocation * for directories or not. */ if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode)) - goto out_fput; + return -ENODEV; - ret = -EFBIG; /* Check for wrap through zero too */ if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0)) - goto out_fput; + return -EFBIG; - if (inode->i_op->fallocate) - ret = inode->i_op->fallocate(inode, mode, offset, len); - else - ret = -EOPNOTSUPP; + if (!inode->i_op->fallocate) + return -EOPNOTSUPP; -out_fput: - fput(file); -out: - return ret; + return inode->i_op->fallocate(inode, mode, offset, len); } + +SYSCALL_DEFINE(fallocate)(int fd, int mode, loff_t offset, loff_t len) +{ + struct file *file; + int error = -EBADF; + + file = fget(fd); + if (file) { + error = do_fallocate(file, mode, offset, len); + fput(file); + } + + return error; +} + #ifdef CONFIG_HAVE_SYSCALL_WRAPPERS asmlinkage long SyS_fallocate(long fd, long mode, loff_t offset, loff_t len) { Index: xfs/include/linux/falloc.h =================================================================== --- xfs.orig/include/linux/falloc.h 2009-01-21 21:03:28.076324621 +0100 +++ xfs/include/linux/falloc.h 2009-01-27 20:36:59.190423995 +0100 @@ -3,4 +3,48 @@ #define FALLOC_FL_KEEP_SIZE 0x01 /* default is extend size */ +#ifdef __KERNEL__ + +/* + * Space reservation ioctls and argument structure + * are designed to be compatible with the legacy XFS ioctls. + */ +struct space_resv { + __s16 l_type; + __s16 l_whence; + __s64 l_start; + __s64 l_len; /* len == 0 means until end of file */ + __s32 l_sysid; + __u32 l_pid; + __s32 l_pad[4]; /* reserve area */ +}; + +#define F_IOC_RESVSP _IOW('X', 40, struct space_resv) +#define F_IOC_RESVSP64 _IOW('X', 42, struct space_resv) + +#if defined(CONFIG_IA64) || defined(CONFIG_X86_64) +#define BROKEN_X86_ALIGNMENT + +#define _NATIVE_IOC(cmd, type) \ + _IOC(_IOC_DIR(cmd), _IOC_TYPE(cmd), _IOC_NR(cmd), sizeof(type)) + +/* on ia32 l_start is on a 32-bit boundary */ +struct space_resv_32 { + __s16 l_type; + __s16 l_whence; + __s64 l_start __attribute__((packed)); + /* len == 0 means until end of file */ + __s64 l_len __attribute__((packed)); + __s32 l_sysid; + __u32 l_pid; + __s32 l_pad[4]; /* reserve area */ +}; + +#define F_IOC_RESVSP_32 _IOW('X', 40, struct space_resv_32) +#define F_IOC_RESVSP64_32 _IOW('X', 42, struct space_resv_32) + +#endif + +#endif /* __KERNEL__ */ + #endif /* _FALLOC_H_ */ Index: xfs/include/linux/fs.h =================================================================== --- xfs.orig/include/linux/fs.h 2009-01-24 17:58:48.960904090 +0100 +++ xfs/include/linux/fs.h 2009-01-27 20:42:01.675299140 +0100 @@ -1694,6 +1694,8 @@ static inline int break_lease(struct ino extern int do_truncate(struct dentry *, loff_t start, unsigned int time_attrs, struct file *filp); +extern int do_fallocate(struct file *file, int mode, loff_t offset, + loff_t len); extern long do_sys_open(int dfd, const char __user *filename, int flags, int mode); extern struct file *filp_open(const char *, int, int); @@ -1702,6 +1704,10 @@ extern struct file * dentry_open(struct extern int filp_close(struct file *, fl_owner_t id); extern char * getname(const char __user *); +/* fs/ioctl.c */ + +extern int ioctl_preallocate(struct file *filp, unsigned long arg); + /* fs/dcache.c */ extern void __init vfs_caches_init_early(void); extern void __init vfs_caches_init(unsigned long); From akpm@linux-foundation.org Wed Jan 28 19:00:45 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0T10j8G165028 for ; Wed, 28 Jan 2009 19:00:45 -0600 X-ASG-Debug-ID: 1233190783-162202a60000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 36186C5E65 for ; Wed, 28 Jan 2009 16:59:43 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id b4G4Hu2mCUwe4z2A for ; Wed, 28 Jan 2009 16:59:43 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0T0x72n028231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 28 Jan 2009 16:59:08 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0T0x6OV020414; Wed, 28 Jan 2009 16:59:07 -0800 Message-Id: <200901290059.n0T0x6OV020414@imap1.linux-foundation.org> X-ASG-Orig-Subj: + xfs-dont-reallocate-sxp-variable-passed-into-xfs_swapext.patch added to -mm tree Subject: + xfs-dont-reallocate-sxp-variable-passed-into-xfs_swapext.patch added to -mm tree To: mm-commits@vger.kernel.org Cc: sandeen@sandeen.net, felixb@sgi.com, hch@lst.de, pm@debian.org, xfs-masters@oss.sgi.com From: akpm@linux-foundation.org Date: Wed, 28 Jan 2009 16:59:06 -0800 X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1233190785 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16397 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean The patch titled xfs: don't reallocate sxp variable passed into xfs_swapext has been added to the -mm tree. Its filename is xfs-dont-reallocate-sxp-variable-passed-into-xfs_swapext.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: xfs: don't reallocate sxp variable passed into xfs_swapext From: Eric Sandeen Addresses http://bugzilla.kernel.org/show_bug.cgi?id=12538, "xfs_fsr fails on 2.6.29-rc kernels" Regression caused by 743bb4650da9e2595d6cedd01c680b5b9398c74a ("[XFS] Move copy_from_user calls out of ioctl helpers into ioctl switch"). This was an embarrasing mistake, reallocating the sxp pointer passed in from the main ioctl switch. Signed-off-by: Eric Sandeen Tested-by: Paul Martin Reviewed-by Felix Blyakher Reviewed-by: Christoph Hellwig Cc: Signed-off-by: Andrew Morton --- fs/xfs/xfs_dfrag.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff -puN fs/xfs/xfs_dfrag.c~xfs-dont-reallocate-sxp-variable-passed-into-xfs_swapext fs/xfs/xfs_dfrag.c --- a/fs/xfs/xfs_dfrag.c~xfs-dont-reallocate-sxp-variable-passed-into-xfs_swapext +++ a/fs/xfs/xfs_dfrag.c @@ -55,17 +55,11 @@ xfs_swapext( struct file *file, *target_file; int error = 0; - sxp = kmem_alloc(sizeof(xfs_swapext_t), KM_MAYFAIL); - if (!sxp) { - error = XFS_ERROR(ENOMEM); - goto out; - } - /* Pull information for the target fd */ file = fget((int)sxp->sx_fdtarget); if (!file) { error = XFS_ERROR(EINVAL); - goto out_free_sxp; + goto out; } if (!(file->f_mode & FMODE_WRITE) || (file->f_flags & O_APPEND)) { @@ -109,8 +103,6 @@ xfs_swapext( fput(target_file); out_put_file: fput(file); - out_free_sxp: - kmem_free(sxp); out: return error; } _ Patches currently in -mm which might be from sandeen@sandeen.net are linux-next.patch xfs-dont-reallocate-sxp-variable-passed-into-xfs_swapext.patch From akpm@linux-foundation.org Fri Jan 30 18:24:29 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0V0OSAC061635 for ; Fri, 30 Jan 2009 18:24:29 -0600 X-ASG-Debug-ID: 1233361427-7cdf03d40000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0165518965BF; Fri, 30 Jan 2009 16:23:47 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id UYCxjVv0hbGR8odl; Fri, 30 Jan 2009 16:23:47 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0V0MruT022442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 30 Jan 2009 16:22:54 -0800 Received: from akpm.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id n0V0MqYC025981; Fri, 30 Jan 2009 16:22:52 -0800 Date: Fri, 30 Jan 2009 16:22:52 -0800 From: Andrew Morton To: Ankit Jain Cc: viro@zeniv.linux.org.uk, hch@infradead.org, linux-fsdevel@vger.kernel.org, mfasheh@suse.com, joel.becker@oracle.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Subject: Re: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Message-Id: <20090130162252.7bf9c1f4.akpm@linux-foundation.org> In-Reply-To: <4980C71F.1010804@ankitjain.org> References: <4980C71F.1010804@ankitjain.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1233361428 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16577 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Thu, 29 Jan 2009 02:29:11 +0530 Ankit Jain wrote: > --- xfs.orig/include/linux/falloc.h 2009-01-21 21:03:28.076324621 +0100 > +++ xfs/include/linux/falloc.h 2009-01-27 20:36:59.190423995 +0100 > @@ -3,4 +3,48 @@ > > #define FALLOC_FL_KEEP_SIZE 0x01 /* default is extend size */ > > +#ifdef __KERNEL__ > + > +/* > + * Space reservation ioctls and argument structure > + * are designed to be compatible with the legacy XFS ioctls. > + */ > +struct space_resv { > + __s16 l_type; > + __s16 l_whence; > + __s64 l_start; > + __s64 l_len; /* len == 0 means until end of file */ > + __s32 l_sysid; > + __u32 l_pid; > + __s32 l_pad[4]; /* reserve area */ > +}; > + > +#define F_IOC_RESVSP _IOW('X', 40, struct space_resv) > +#define F_IOC_RESVSP64 _IOW('X', 42, struct space_resv) Should this stuff be inside #ifdef __KERNEL__? It is shared with userspace. Are we sure that the aligment of l_start will be reliably the same across all compilers and versions thereof for all time? From arnd@arndb.de Fri Jan 30 18:40:10 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0V0e990062180 for ; Fri, 30 Jan 2009 18:40:10 -0600 X-ASG-Debug-ID: 1233362367-22fb008a0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from moutng.kundenserver.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 55DE7D1FF5; Fri, 30 Jan 2009 16:39:28 -0800 (PST) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.10]) by cuda.sgi.com with ESMTP id A3b4NCtMmovPNxnP; Fri, 30 Jan 2009 16:39:28 -0800 (PST) Received: from noname (port-92-193-120-248.dynamic.qsc.de [92.193.120.248]) by mrelayeu.kundenserver.de (node=mrelayeu7) with ESMTP (Nemesis) id 0ML2xA-1LT3sl2lHd-0002VS; Sat, 31 Jan 2009 01:38:51 +0100 From: Arnd Bergmann To: Andrew Morton X-ASG-Orig-Subj: Re: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Subject: Re: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Date: Sat, 31 Jan 2009 01:38:32 +0100 User-Agent: KMail/1.9.9 References: <4980C71F.1010804@ankitjain.org> <20090130162252.7bf9c1f4.akpm@linux-foundation.org> In-Reply-To: <20090130162252.7bf9c1f4.akpm@linux-foundation.org> X-Face: I@=L^?./?$U,EK.)V[4*>`zSqm0>65YtkOe>TFD'!aw?7OVv#~5xd\s,[~w]-J!)|%=]>=?utf-8?q?+=0A=09=7EohchhkRGW=3F=7C6=5FqTmkd=5Ft=3FLZC=23Q-=60=2E=60Y=2Ea=5E?= =?utf-8?q?3zb?=) =?utf-8?q?+U-JVN=5DWT=25cw=23=5BYo0=267C=26bL12wWGlZi=0A=09=7EJ=3B=5Cwg?= =?utf-8?q?=3B3zRnz?=,J"CT_)=\H'1/{?SR7GDu?WIopm.HaBG=QYj"NZD_[zrM\Gip^U Cc: Ankit Jain , viro@zeniv.linux.org.uk, hch@infradead.org, linux-fsdevel@vger.kernel.org, mfasheh@suse.com, joel.becker@oracle.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901310138.34164.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX1/GODRZ7ZhZoDfTb1DT2vqRkWN5dj4Ddyz24/D GkenMI3+brSdwYV+63Ij1VV1D9GRbQycY/2UQh6mPNJ1KK1g0q YA7rKVPiPoonOHMmWGR0g== X-Barracuda-Connect: moutng.kundenserver.de[212.227.17.10] X-Barracuda-Start-Time: 1233362369 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16577 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Saturday 31 January 2009, Andrew Morton wrote: > On Thu, 29 Jan 2009 02:29:11 +0530 Ankit Jain wrote: > > +struct space_resv { > > + __s16 l_type; > > + __s16 l_whence; > > + __s64 l_start; > > + __s64 l_len; /* len == 0 means until end of file */ > > + __s32 l_sysid; > > + __u32 l_pid; > > + __s32 l_pad[4]; /* reserve area */ > > +}; > > + > > +#define F_IOC_RESVSP _IOW('X', 40, struct space_resv) > > +#define F_IOC_RESVSP64 _IOW('X', 42, struct space_resv) > > Are we sure that the aligment of l_start will be reliably the same > across all compilers and versions thereof for all time? On x86, the alignment differs between 32 and 64 bit, otherwise it's ok. XFS handles the conversion for compat_ioctl in fs/xfs/linux-2.6/xfs_ioctl32.c. If this becomes a generic file ioctl, the conversion code should be moved to fs/compat_ioctl.c. Arnd <>< From akpm@linux-foundation.org Fri Jan 30 19:15:29 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0V1FThO063539 for ; Fri, 30 Jan 2009 19:15:29 -0600 X-ASG-Debug-ID: 1233364487-2f7d03c40000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from smtp1.linux-foundation.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 8E91E189C9AA; Fri, 30 Jan 2009 17:14:47 -0800 (PST) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by cuda.sgi.com with ESMTP id HgwsZNpNag8EHzuI; Fri, 30 Jan 2009 17:14:47 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n0V1EOHj004267 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 30 Jan 2009 17:14:25 -0800 Received: from y.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id n0V1ENbg027141; Fri, 30 Jan 2009 17:14:23 -0800 Date: Fri, 30 Jan 2009 17:14:23 -0800 From: Andrew Morton To: Arnd Bergmann Cc: Ankit Jain , viro@zeniv.linux.org.uk, hch@infradead.org, linux-fsdevel@vger.kernel.org, mfasheh@suse.com, joel.becker@oracle.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Subject: Re: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Message-Id: <20090130171423.f99c88d0.akpm@linux-foundation.org> In-Reply-To: <200901310138.34164.arnd@arndb.de> References: <4980C71F.1010804@ankitjain.org> <20090130162252.7bf9c1f4.akpm@linux-foundation.org> <200901310138.34164.arnd@arndb.de> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Barracuda-Connect: smtp1.linux-foundation.org[140.211.169.13] X-Barracuda-Start-Time: 1233364488 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16579 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Sat, 31 Jan 2009 01:38:32 +0100 Arnd Bergmann wrote: > On Saturday 31 January 2009, Andrew Morton wrote: > > On Thu, 29 Jan 2009 02:29:11 +0530 Ankit Jain wrote: > > > +struct space_resv { > > > + __s16 l_type; > > > + __s16 l_whence; > > > + __s64 l_start; > > > + __s64 l_len; /* len == 0 means until end of file */ > > > + __s32 l_sysid; > > > + __u32 l_pid; > > > + __s32 l_pad[4]; /* reserve area */ > > > +}; > > > + > > > +#define F_IOC_RESVSP _IOW('X', 40, struct space_resv) > > > +#define F_IOC_RESVSP64 _IOW('X', 42, struct space_resv) > > > > Are we sure that the aligment of l_start will be reliably the same > > across all compilers and versions thereof for all time? > > On x86, the alignment differs between 32 and 64 bit, otherwise it's ok. Is this written in a standard somewhere? Is it guaranteed? If some (perhaps non-gcc) compiler were to lay this out differently (perhaps with suitable command-line options) then that's liveable with - as long as the kernel never changes the layout. Of course it would be better to avoid this if poss. The other potential issue with a structure like this is that there's a risk that it will lead us to copy four bytes of uninitialised kernel memory out to userspace. IOW, it seems a generally bad idea to rely upon compiler-added padding for this sort of thing. > XFS handles the conversion for compat_ioctl in > fs/xfs/linux-2.6/xfs_ioctl32.c. If this becomes a generic file ioctl, > the conversion code should be moved to fs/compat_ioctl.c. From arnd@arndb.de Fri Jan 30 19:49:43 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0V1nggd065147 for ; Fri, 30 Jan 2009 19:49:43 -0600 X-ASG-Debug-ID: 1233366540-5267007b0000-7TOuyN X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from moutng.kundenserver.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D6B21D24A1; Fri, 30 Jan 2009 17:49:00 -0800 (PST) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.188]) by cuda.sgi.com with ESMTP id YWNdcvseRQzXd52Q; Fri, 30 Jan 2009 17:49:00 -0800 (PST) Received: from noname (port-92-193-120-248.dynamic.qsc.de [92.193.120.248]) by mrelayeu.kundenserver.de (node=mrelayeu7) with ESMTP (Nemesis) id 0ML2xA-1LT4yc3WGD-0002P4; Sat, 31 Jan 2009 02:48:55 +0100 From: Arnd Bergmann To: Andrew Morton X-ASG-Orig-Subj: Re: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Subject: Re: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Date: Sat, 31 Jan 2009 02:48:41 +0100 User-Agent: KMail/1.9.9 Cc: Ankit Jain , viro@zeniv.linux.org.uk, hch@infradead.org, linux-fsdevel@vger.kernel.org, mfasheh@suse.com, joel.becker@oracle.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com References: <4980C71F.1010804@ankitjain.org> <200901310138.34164.arnd@arndb.de> <20090130171423.f99c88d0.akpm@linux-foundation.org> In-Reply-To: <20090130171423.f99c88d0.akpm@linux-foundation.org> X-Face: I@=L^?./?$U,EK.)V[4*>`zSqm0>65YtkOe>TFD'!aw?7OVv#~5xd\s,[~w]-J!)|%=]>=?utf-8?q?+=0A=09=7EohchhkRGW=3F=7C6=5FqTmkd=5Ft=3FLZC=23Q-=60=2E=60Y=2Ea=5E?= =?utf-8?q?3zb?=) =?utf-8?q?+U-JVN=5DWT=25cw=23=5BYo0=267C=26bL12wWGlZi=0A=09=7EJ=3B=5Cwg?= =?utf-8?q?=3B3zRnz?=,J"CT_)=\H'1/{?SR7GDu?WIopm.HaBG=QYj"NZD_[zrM\Gip^U MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200901310248.42820.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX1/LSDyyGb8Gt/8jQXyiM6+3HUGKwmPeWIVCB5L u2MGn2CvUHIIJJsKpzwyOMBK3peBlI6lyGTJ4vthJv7wxKXmX1 sXJTxPQC5pAx1HfY3GQHA== X-Barracuda-Connect: moutng.kundenserver.de[212.227.126.188] X-Barracuda-Start-Time: 1233366541 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.16581 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Saturday 31 January 2009, Andrew Morton wrote: > Is this written in a standard somewhere? =A0Is it guaranteed? Alignment is defined in the architecture psABI documents.=20 Unfortunately, many of them were written before the 'long long' type became part of the C standard, so it's not strictly guaranteed. AFAICT, the alignment of __u64 on x86 is the same as the alignment of 'double' by convention. However, the problem is well-understood: x86 is the only one that has a problem in 32/64 bit compat mode. m68k has similar issues with 16/32 bit integers, but those don't apply here. > If some (perhaps non-gcc) compiler were to lay this out differently > (perhaps with suitable command-line options) then that's liveable > with - as long as the kernel never changes the layout. =A0Of course > it would be better to avoid this if poss. If a compiler was using irregular structure alignment, all sorts of library interfaces would break. The kernel ABI is only a small part of the problem then. > The other potential issue with a structure like this is that there's a > risk that it will lead us to copy four bytes of uninitialised kernel > memory out to userspace. >=20 > IOW, it seems a generally bad idea to rely upon compiler-added padding > for this sort of thing. Agreed in general, but the whole point of this particular patch was to provide compatibility with an interface that has been part of XFS for many years. Linux already has a better interface for new users (sys_fallocate), so changing the patch would not be helpful and not provide any advantage. There is also no leak of uninitialized data here, because this structure is only read, never written. Arnd <>< From wwwrun@oss.sgi.com Sat Jan 31 09:26:46 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0VFQklF110430 for ; Sat, 31 Jan 2009 09:26:46 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0VFQkto110428; Sat, 31 Jan 2009 09:26:46 -0600 Date: Sat, 31 Jan 2009 09:26:46 -0600 Message-Id: <200901311526.n0VFQkto110428@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: xfs-masters@oss.sgi.com Subject: [Bug 758] xfs-admin/xfs_db segfaults with garbage partition X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: XFS X-Bugzilla-Component: xfsprogs X-Bugzilla-Keywords: X-Bugzilla-Severity: minor X-Bugzilla-Who: hch@xfs.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: xfs-masters@oss.sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=758 Christoph Hellwig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hch@xfs.org Resolution| |FIXED --- Comment #1 from Christoph Hellwig 2009-01-31 09:26:45 CST --- I've checked in a fix for this in the current development tree: http://git.kernel.org/?p=fs/xfs/xfsprogs-dev.git;a=commitdiff;h=7f98455ae9f393b10508c9c46f85e50dc3b0c372 -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.